Lint: PartialResults merging works incorrectly [239337003]

Fixed

Bug

Status Update

No update yet.

Description

li...@gmail.com

created issue #1

Jul 18, 2022 04:46PM

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

Download project from the attach;
Run ./gradlew :app:lintDebug and observe 2 issues;
Run ./gradlew :lint-checks:test and observe tests failing.

It looks like PartialResult#map doesn't follow the contract in unit tests. It claims to return LintMap for the project in context, but under the certain condition it seems to be violated.

The conditions require multimodule setup. A library module must put smth into its LintMap. Then, when the app module accesses its own LintMap for the first time it get a map prefilled with the data from the library module, instead of the fresh one.

To demonstrate the issue I created the following setup:

An :app module and a :library module;
:app module contains app_color color resource, while :library module contains :library_color;
I created a simple detector, which works only in partial analysis mode and does a simple thing: detects the color resource declaration within the module, puts into the partial results and then reports all colors found per module in checkPartialResults method;
There's a unit test, which mimics the same setup.

If you run lint checks using the ./gradlew :app:lintDebug command, you'll observe Lint correctly reporting app_color found in :app and library_color found in :library. However, if you run the unit tests, you'll observe that Lint also reports a library_color found in the :app.

It looks like while scanning the :app module, the first access to partial results, causes LintCliClient to create new instance of results and fill it with results of the dependent module (see LintCliClient#getPartialResults method). For some reason this is happening only in tests.

The replacement of the getPartialResult.map() method call with getPartialResult.mapFor(context.project) method call successfully addresses the issue.

There's still a chance, that my test is wrong. In this case, would be great to know in which way.

Studio Build: Chipmunk | 2021.2.1 Version of Gradle Plugin: 7.2.1, 7.4.0-alpha08 Version of Gradle: 7.4.2 OS: Mac OS Monteray 12.4

LintBug2.zip

803 KB

Download

Comments

li...@gmail.com <li...@gmail.com> #2Jul 18, 2022 04:58PM

I also have the same issue so it seems to be a real problem.

ch...@google.com <ch...@google.com> Jul 20, 2022 01:09PM

Assigned to an...@google.com.

li...@gmail.com <li...@gmail.com> #3Jul 20, 2022 03:45PM

Dup here:

http://code.google.com/p/android/issues/detail?id=27959&can=1&q=fixed%20position&colspec=ID%20Type%20Status%20Owner%20Summary%20Stars

Though it's a bit more detailed with the minimum necessary to reproduce.

je...@google.com <je...@google.com> Jul 26, 2022 01:20AM

Reassigned to sp...@google.com.

sp...@google.com <sp...@google.com> #4Jul 26, 2022 05:00PM

Reassigned to ra...@google.com.

why is this marked has Obsolete? this is still a bug that is happening and its difficult to fix.
for all who are looking for a solution use this:

http://stackoverflow.com/questions/16200972/android-css-positionfixed-after-a-device-rotate

ra...@google.com <ra...@google.com> Aug 15, 2022 06:32PM

Reassigned to pa...@google.com.

pa...@google.com <pa...@google.com> Aug 30, 2022 11:11AM

Reassigned to pa...@google.com.

pa...@google.com <pa...@google.com> #5Aug 30, 2022 07:38PM

Thank you very much for reporting this. I think you are correct; something is broken here. Exactly what is broken depends on what was intended by the Lint authors. I'll continue to investigate.

li...@gmail.com <li...@gmail.com> #6Sep 9, 2022 12:14PM

Any updates on this? Would be great to at least know if the issue is within the tests/testing framework/Lint itself.

pa...@google.com <pa...@google.com> #7Sep 23, 2022 11:46AM

Sorry for the delay. There is definitely an issue with Lint itself; we will fix this.

The Android Gradle Plugin also behaves differently to the testing framework, such that the issue does not show up when using Gradle. This may take longer to fix, but once we fix the above issue with Lint, the difference in behavior probably won't be noticeable. It will only be noticeable if your Detector needs to read partial results from dependent modules (not including when you check all partial results in checkPartialResults).

pa...@google.com <pa...@google.com> #8Oct 25, 2022 09:34AM

Marked as fixed.

Fixed in https://android.googlesource.com/platform/tools/base/+/878bfdb358f80430f3291cf1d1f4daf79d82a2fd

li...@gmail.com <li...@gmail.com> #9Nov 1, 2022 04:59PM

Could you please share which version of Lint will include the fix?

sa...@google.com <sa...@google.com> #10Nov 2, 2022 05:32PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Electric Eel Beta 4 (2022.1.1.14)
Android Gradle Plugin 7.4.0-beta04

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

sa...@google.com <sa...@google.com> #11Nov 3, 2022 01:42PM

The fixes for this issue are now also available in:

Android Studio Flamingo Canary 7 (2022.2.1.7)
Android Gradle Plugin 8.0.0-alpha07

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

li...@gmail.com <li...@gmail.com> #12Jan 13, 2023 03:51PM

Hi again! After the Electric Eel release I went back to this issue. Using the same demo project I update the AGP to 7.4.0, Gradle to 7.5.1, Lint SDK to 30.4.0 and target/compile SDKs to 33. I ran the test, which was previously failing, and it still fails!

Could you please confirm, that after the fix, the issue is no longer reproducible in the demo project, which I shared in the opening message?

Message last modified on Jan 13, 2023 03:56PM

pa...@google.com <pa...@google.com> Jan 13, 2023 03:54PM

Status: Assigned (reopened)

pa...@google.com <pa...@google.com> #13Jan 18, 2023 05:45PM

Marked as fixed.

Sorry, it looks like the fix is only available from: lint-31.0.0-alpha07 (I guess Flamingo Canary 7)

https://dl.google.com/dl/android/maven2/com/android/tools/lint/lint/31.0.0-alpha07/lint-31.0.0-alpha07-sources.jar

li...@gmail.com <li...@gmail.com> #14May 9, 2023 12:04PM

Comment has been deleted.

Message last modified on May 9, 2023 12:06PM

li...@gmail.com <li...@gmail.com> #15May 9, 2023 12:06PM

I can confirm that the issue is fixed. Updating AGP to 8.0 and lint apis to 31.0.0 helps.