Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 571a490c660e85bcccab59c67823274f7eed1ba9
Author: Chet Haase <chet@google.com>
Date: Mon Jul 18 15:07:02 2022
Fixed double-removal of listener delegator
It was possible for the overall listener delegator object to be
removed twice, in both places where the delegator's list of
delegates could reach zero. This fix ensures that it will only ever
be removed once (when that list first reaches a size of zero).
Also cleaned up historical use of Executor in the JankAggregatorActivity
test app.
Bug: 239457413
Test: Manual testing plus JankStatsTest automated runs
RelNote: Fixed crash due to double-removal of OnFrameMetricsAvailableListener
Change-Id: I4409483d6e2f7287a0a93f521f68a4be9e22d969
M metrics/metrics-performance/src/main/java/androidx/metrics/performance/JankStatsApi24Impl.kt
M metrics/metrics-performance/src/main/java/androidx/metrics/performance/JankStatsApi16Impl.kt
M metrics/integration-tests/janktest/src/main/java/androidx/metrics/performance/janktest/JankStatsAggregator.kt
M metrics/integration-tests/janktest/src/main/java/androidx/metrics/performance/janktest/JankAggregatorActivity.kt
https://android-review.googlesource.com/2157617
Branch: androidx-main
commit 571a490c660e85bcccab59c67823274f7eed1ba9
Author: Chet Haase <chet@google.com>
Date: Mon Jul 18 15:07:02 2022
Fixed double-removal of listener delegator
It was possible for the overall listener delegator object to be
removed twice, in both places where the delegator's list of
delegates could reach zero. This fix ensures that it will only ever
be removed once (when that list first reaches a size of zero).
Also cleaned up historical use of Executor in the JankAggregatorActivity
test app.
Bug: 239457413
Test: Manual testing plus JankStatsTest automated runs
RelNote: Fixed crash due to double-removal of OnFrameMetricsAvailableListener
Change-Id: I4409483d6e2f7287a0a93f521f68a4be9e22d969
M metrics/metrics-performance/src/main/java/androidx/metrics/performance/JankStatsApi24Impl.kt
M metrics/metrics-performance/src/main/java/androidx/metrics/performance/JankStatsApi16Impl.kt
M metrics/integration-tests/janktest/src/main/java/androidx/metrics/performance/janktest/JankStatsAggregator.kt
M metrics/integration-tests/janktest/src/main/java/androidx/metrics/performance/janktest/JankAggregatorActivity.kt
Description
java.lang.IllegalArgumentException: attempt to remove OnFrameMetricsAvailableListener that was never added
at android.view.View.removeFrameMetricsListener(View.java:5560)
at android.view.Window.removeOnFrameMetricsAvailableListener(Window.java:863)
at androidx.metrics.performance.DelegatingFrameMetricsListener.onFrameMetricsAvailable(JankStatsApi24Impl.kt:226)
at android.view.FrameMetricsObserver.notifyDataAvailable(FrameMetricsObserver.java:72)
at android.os.MessageQueue.nativePollOnce(Native Method)
at android.os.MessageQueue.next(MessageQueue.java:323)
at android.os.Looper.loop(Looper.java:136)
at android.os.HandlerThread.run(HandlerThread.java:61)
To repro, run the app, then tap the home button. This disables jank stats tracking, which ends up removing a delegate listener and then the delegator itself (apparently twice).
It's not 100%, but it's fairly frequent.
Looks like there are two places in JankStatsApi24Impl where we remove the delegator listener from the window, in removeFrameMetricsListenerDelegate() (when we have removed the last delegate) and in OnFrameMetricsAvailable (when we detect a delegates list size of 0)