[Compose] There's no SelectAll menu in TextToolbar when text is selected in SelectionContainer [240143283]

Fixed

Feature Request

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Jul 26, 2022 02:32AM

- Jetpack Compose version: 1.2.0-rc02 & 1.3.0-alpha01
- Jetpack Compose component used: SelectionContainer & Text
- Android Studio Build:
Android Studio Dolphin | 2021.3.1 Beta 5
Build #AI-213.7172.25.2113.8774922, built on June 28, 2022
Runtime version: 11.0.13+0-b1751.21-8125866 x86_64
- Kotlin version: 1.7.10
- Devices/Android versions reproduced on: Android 12 Pixel 3a
- Keyboard (i.e. Gboard, Samsung, etc): N/A

Compared to TextView in View system, there's only one menu - Copy in text toolbar when text is selected in SelectionContainer.
SelectAll is quite an important feature for our users.
Could you support it in SelectionContainer? Or is there any way to enable it in Compose?
Thank you!

OnlyCopyMenu.png

76 KB

View

Download

OnlyCopyMenuScreen.kt

613 B

Download

Comments

kl...@google.com <kl...@google.com> #2Aug 1, 2022 03:01PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

[Deleted User] <[Deleted User]> #3Aug 12, 2022 07:25AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

gr...@google.com <gr...@google.com> Feb 8, 2023 09:32PM

Reassigned to gr...@google.com.

al...@rockettrade.com <al...@rockettrade.com> #4Oct 31, 2023 05:02PM

Hi, we ran into the same issue using the latest alpha material components. Any possible fixes coming soon, or some workarounds?

ma...@300624.cn <ma...@300624.cn> #5Dec 15, 2023 02:46AM

Any update?

ap...@google.com <ap...@google.com> #6Apr 23, 2024 07:06PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 8a0c81da179bebe6309f996e165fad918327d5e8
Author: Grant Toepfer <grantapher@google.com>
Date: Fri Apr 19 10:26:47 2024

Add "Select all" to `SelectionContainer` contextual menus

Adds the "Select all" operation to both the context menu and text toolbar in `SelectionContainer`. This operation will select all the text across all `BasicText`s in the container.

Relnote: "Added \"Select all\" to all text contextual menus in `SelectionContainer`."
Test: SelectionManagerTest & SelectionContainerContextMenuTest
Fixes:

b/240143283

Change-Id: Ib750e9580a290c68356c02cc83bab4cc048e4cc8

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/selection/SelectionContainerContextMenuTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/selection/gestures/LazyColumnMultiTextRegressionTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.android.kt
M compose/foundation/foundation/src/androidUnitTest/kotlin/androidx/compose/foundation/text/selection/SelectionFakes.kt
M compose/foundation/foundation/src/androidUnitTest/kotlin/androidx/compose/foundation/text/selection/SelectionManagerTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.kt

https://android-review.googlesource.com/3049401

mi...@gmail.com <mi...@gmail.com> #7Aug 13, 2024 09:16AM

I still don't have this "Select all", all versions are new

gr...@google.com <gr...@google.com> #8Aug 13, 2024 06:11PM

Targeting Compose 1.7.