[Compose] There's no SelectAll menu in TextToolbar when text is selected in SelectionContainer [240143283]

Fixed

Feature Request

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Jul 26, 2022 02:32AM

- Jetpack Compose version: 1.2.0-rc02 & 1.3.0-alpha01
- Jetpack Compose component used: SelectionContainer & Text
- Android Studio Build:
Android Studio Dolphin | 2021.3.1 Beta 5
Build #AI-213.7172.25.2113.8774922, built on June 28, 2022
Runtime version: 11.0.13+0-b1751.21-8125866 x86_64
- Kotlin version: 1.7.10
- Devices/Android versions reproduced on: Android 12 Pixel 3a
- Keyboard (i.e. Gboard, Samsung, etc): N/A

Compared to TextView in View system, there's only one menu - Copy in text toolbar when text is selected in SelectionContainer.
SelectAll is quite an important feature for our users.
Could you support it in SelectionContainer? Or is there any way to enable it in Compose?
Thank you!

OnlyCopyMenu.png

76 KB

View

Download

OnlyCopyMenuScreen.kt

613 B

Download

Comments

kl...@google.com <kl...@google.com> #2Aug 1, 2022 03:01PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

[Deleted User] <[Deleted User]> #3Aug 12, 2022 07:25AM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

gr...@google.com <gr...@google.com> Feb 8, 2023 09:32PM

Reassigned to gr...@google.com.

al...@rockettrade.com <al...@rockettrade.com> #4Oct 31, 2023 05:02PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

ma...@300624.cn <ma...@300624.cn> #5Dec 15, 2023 02:46AM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

ap...@google.com <ap...@google.com> #6Apr 23, 2024 07:06PM

Marked as fixed.

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

mi...@gmail.com <mi...@gmail.com> #7Aug 13, 2024 09:16AM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

gr...@google.com <gr...@google.com> #8Aug 13, 2024 06:11PM

Thank you, I'll try it and check.