Fixed
Status Update
No update yet.
Comments
jb...@google.com
Please upload a sample project that reproduces this issue.
[Deleted User] <[Deleted User]>
There is no need. Just check DynamicGraphNavigator code and you will understand the problem with DynamicActivityNavigator.
Besides I pointed out to a class and made a screenshot of what is missing
Besides I pointed out to a class and made a screenshot of what is missing
[Deleted User] <[Deleted User]>
Also, making a sample project means testing in production, because dynamic feature modules are testable only after uploading to play market. We dont have any resources to do that
an...@gmail.com
Also check a screenshot please
[Deleted User] <[Deleted User]>
jb...@google.com
The way Dynamic Navigation has to handle activities is inherently different from other destinations so not returning there could possibly be intentional.
Is this something new that was caused by upgrading to 2.5.0? Or was it pre-existing?
[Deleted User] <[Deleted User]>
It is caused by upgrading from 2.3.0 to 2.5.0.
When we saw this issue we did a rollback to 2.3.5.
2.3.5 - the last version where this issue doesn't exist
When we saw this issue we did a rollback to 2.3.5.
2.3.5 - the last version where this issue doesn't exist
[Deleted User] <[Deleted User]>
and in 2.3.5 you do have a return statement there
jb...@google.com
You're right, looks like we didn't add it back when we made
an...@gmail.com
I n what version we can expect to get it back?
[Deleted User] <[Deleted User]>
any news? :)
be...@google.com
The statement was removed during the migration to V2, when we did not expect this problem to occur.
[Deleted User] <[Deleted User]>
Can you give an ETA please of the fix?
[Deleted User] <[Deleted User]>
any news? :)
fo...@gmail.com
Hi there, I face the same issue. Any progress so far?
pa...@outlook.com
Hey!
Same issue in my project. Any update here?
Same issue in my project. Any update here?
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 0c4ad1856d1b956d8a0da8074557a5a69fb130d9
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Aug 30 16:16:49 2022
Fix navigating to Activities from unloaded modules
Currently, if you are using dynamic Navigation and you attempt to
navigate to a Activity in a module that has not yet be loaded, a
ClassNotFoundException is thrown. This is because the
DynamicActivityNavigator currently attempts to install the module (which
is an async operation) and then immediately navigates to the new class.
Instead, we should return after the install attempt and then allow the
systme to retry the navigation at the appropriate time.
RelNote: "Dynamic Navigation now properly attempts to install Activity
destinations from other modules before navigating to them."
Test: tested on a device using bundletool
Bug: 240292838
Change-Id: Ia2c1645426d2f6a5958a10379a99f2aade3dd03a
M navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigator.kt
https://android-review.googlesource.com/2199792
Branch: androidx-main
commit 0c4ad1856d1b956d8a0da8074557a5a69fb130d9
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Aug 30 16:16:49 2022
Fix navigating to Activities from unloaded modules
Currently, if you are using dynamic Navigation and you attempt to
navigate to a Activity in a module that has not yet be loaded, a
ClassNotFoundException is thrown. This is because the
DynamicActivityNavigator currently attempts to install the module (which
is an async operation) and then immediately navigates to the new class.
Instead, we should return after the install attempt and then allow the
systme to retry the navigation at the appropriate time.
RelNote: "Dynamic Navigation now properly attempts to install Activity
destinations from other modules before navigating to them."
Test: tested on a device using bundletool
Bug: 240292838
Change-Id: Ia2c1645426d2f6a5958a10379a99f2aade3dd03a
M navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigator.kt
jb...@google.com
This has been fixed internally and will be released in Navigation 2.5.2 and 2.6.0-alpha01.
na...@google.com
This bug was linked in a change in the following release(s):
androidx.navigation:navigation-dynamic-features-runtime:2.6.0-alpha01androidx.navigation:navigation-dynamic-features-runtime:2.5.2
Description
Version used: 2.5.0
Devices/Android versions reproduced on: all
package androidx.navigation.dynamicfeatures
public class DynamicActivityNavigator
return statement is missing here after install manager call.
It causes application to crash because you're navigating to not existing class yet.
Fatal Exception: java.lang.RuntimeException
Unable to instantiate activity ComponentInfo{...}: java.lang.ClassNotFoundException: Didn't find class "com....Activity" on path: DexPathList[.....]