IssueTracker

Project: platform/frameworks/support
Branch: androidx-main

commit d8ae257b1d34561fa4838556c41050b79033a18a
Author: Clara Fok <clarafok@google.com>
Date:   Wed Feb 28 12:47:31 2024

    DeepLink query params now allow {argName} values for String types
   
    For arguments of NavType<String>, arg values that are in the form of curly braces around argument name is now allowed as valid values. For all other types, this value is still considered as invalid (or absent of argument value).
   
    Internal tests have been updated to reflect this new change. To be precise:
   
    1. NavControllerRouteTest.kt - tests that are setup with absence of value were passing values of {argName} with StringType. Since this is no longer processed as absence of value, StringType has been changed to IntArrayType.
   
    2. NavDeepLinkTest - likewise as NavControllerRouteTest.kt, with additional new test to assert that {argName} is invalid for non-String types.
   
    Test: ./gradlew navigation:navigation-common:cC
    Test: ./gradlew navigation:navigation-runtime:cC
    Bug: 327274038
    Relnote: "Query parameters in DeepLink now allows values in the form of curly braces around argument name (i.e. {argName}) as valid values for string-based NavTypes. This contrasts with before where such a value would be considered invalid (or absence of value) for all types."
    Change-Id: I183028e2f77d63158a9a567c43da016722397cb8

M       navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
M       navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M       navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt

https://android-review.googlesource.com/2982559

Also check a screenshot please

it is not fixed in 2.5.1, btw
https://android.googlesource.com/platform/frameworks/support/+/4653357b9f99873d663cb5fee267b2f64afa0472/navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigator.kt

The file still has the same error

It is caused by upgrading from 2.3.0 to 2.5.0.
When we saw this issue we did a rollback to 2.3.5.
2.3.5 - the last version where this issue doesn't exist

and in 2.3.5 you do have a return statement there

I n what version we can expect to get it back?

any news? :)

Can you give an ETA please of the fix?

any news? :)

Hi there, I face the same issue. Any progress so far?

Hey!

Same issue in my project. Any update here?

Project: platform/frameworks/support
Branch: androidx-main

commit 0c4ad1856d1b956d8a0da8074557a5a69fb130d9
Author: Jeremy Woods <jbwoods@google.com>
Date:   Tue Aug 30 16:16:49 2022

    Fix navigating to Activities from unloaded modules
   
    Currently, if you are using dynamic Navigation and you attempt to
    navigate to a Activity in a module that has not yet be loaded, a
    ClassNotFoundException is thrown. This is because the
    DynamicActivityNavigator currently attempts to install the module (which
    is an async operation) and then immediately navigates to the new class.
   
    Instead, we should return after the install attempt and then allow the
    systme to retry the navigation at the appropriate time.
   
    RelNote: "Dynamic Navigation now properly attempts to install Activity
    destinations from other modules before navigating to them."
    Test: tested on a device using bundletool
    Bug: 240292838
   
    Change-Id: Ia2c1645426d2f6a5958a10379a99f2aade3dd03a

M       navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigator.kt

https://android-review.googlesource.com/2199792