App crashes when navigating to an Activity in dynamic feature module [240292838]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Jul 27, 2022 11:27AM

Component used: Navigation
Version used: 2.5.0
Devices/Android versions reproduced on: all

package androidx.navigation.dynamicfeatures
public class DynamicActivityNavigator

return statement is missing here after install manager call.
It causes application to crash because you're navigating to not existing class yet.
Fatal Exception: java.lang.RuntimeException
Unable to instantiate activity ComponentInfo{...}: java.lang.ClassNotFoundException: Didn't find class "com....Activity" on path: DexPathList[.....]

Screenshot 2022-07-27 at 14.24.03.png

492 KB

View

Download

Comments

jb...@google.com <jb...@google.com> #2Jul 27, 2022 05:29PM

since these are in public API (:/) we need to do this in 1.2

[Deleted User] <[Deleted User]> #3Jul 27, 2022 06:28PM

since it is already marked as deprecated, we can probably do it by now.

[Deleted User] <[Deleted User]> #4Jul 27, 2022 06:30PM

Opening diff shortly

an...@gmail.com <an...@gmail.com> #5Jul 27, 2022 06:33PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

[Deleted User] <[Deleted User]> #6Jul 29, 2022 12:43PM

it is not fixed in 2.5.1, btw

https://android.googlesource.com/platform/frameworks/support/+/4653357b9f99873d663cb5fee267b2f64afa0472/navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigator.kt

The file still has the same error

jb...@google.com <jb...@google.com> #7Jul 29, 2022 04:45PM

The way Dynamic Navigation has to handle activities is inherently different from other destinations so not returning there could possibly be intentional.

Is this something new that was caused by upgrading to 2.5.0? Or was it pre-existing?

[Deleted User] <[Deleted User]> #8Jul 29, 2022 04:50PM

It is caused by upgrading from 2.3.0 to 2.5.0.
When we saw this issue we did a rollback to 2.3.5.
2.3.5 - the last version where this issue doesn't exist

[Deleted User] <[Deleted User]> #9Jul 29, 2022 04:51PM

and in 2.3.5 you do have a return statement there

jb...@google.com <jb...@google.com> #10Jul 29, 2022 07:38PM

Assigned to be...@google.com.

You're right, looks like we didn't add it back when we made this change.

an...@gmail.com <an...@gmail.com> #11Jul 30, 2022 04:29PM

I n what version we can expect to get it back?

[Deleted User] <[Deleted User]> #12Aug 2, 2022 08:23AM

any news? :)

be...@google.com <be...@google.com> #13Aug 8, 2022 03:04PM

Reassigned to jb...@google.com.

The statement was removed during the migration to V2, when we did not expect this problem to occur.

[Deleted User] <[Deleted User]> #14Aug 9, 2022 07:14AM

Can you give an ETA please of the fix?

[Deleted User] <[Deleted User]> #15Aug 19, 2022 07:45AM

any news? :)

fo...@gmail.com <fo...@gmail.com> #16Aug 29, 2022 02:18PM

Hi there, I face the same issue. Any progress so far?

Message last modified on Aug 29, 2022 02:18PM

pa...@outlook.com <pa...@outlook.com> #17Aug 29, 2022 02:23PM

Hey!

Same issue in my project. Any update here?

ap...@google.com <ap...@google.com> #18Aug 31, 2022 05:43PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0c4ad1856d1b956d8a0da8074557a5a69fb130d9
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Aug 30 16:16:49 2022

Fix navigating to Activities from unloaded modules

Currently, if you are using dynamic Navigation and you attempt to
navigate to a Activity in a module that has not yet be loaded, a
ClassNotFoundException is thrown. This is because the
DynamicActivityNavigator currently attempts to install the module (which
is an async operation) and then immediately navigates to the new class.

Instead, we should return after the install attempt and then allow the
systme to retry the navigation at the appropriate time.

RelNote: "Dynamic Navigation now properly attempts to install Activity
destinations from other modules before navigating to them."
Test: tested on a device using bundletool
Bug: 240292838

Change-Id: Ia2c1645426d2f6a5958a10379a99f2aade3dd03a

M navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigator.kt

https://android-review.googlesource.com/2199792

jb...@google.com <jb...@google.com> #19Aug 31, 2022 05:45PM

Marked as fixed.

This has been fixed internally and will be released in Navigation 2.5.2 and 2.6.0-alpha01.

na...@google.com <na...@google.com> #20Sep 12, 2022 05:52PM

This bug was linked in a change in the following release(s):

androidx.navigation:navigation-dynamic-features-runtime:2.6.0-alpha01
androidx.navigation:navigation-dynamic-features-runtime:2.5.2