Status Update
Comments
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #2
This is a particularly hard device to come by - do you happen to have access to the device? If so could you provide us with the output of: adb shell dumpsys media.camera > info.txt
Thanks!
ap...@google.com <ap...@google.com> #3
Stacktrace:
Caused by: java.lang.IllegalArgumentException: Can not get supported output size under supported maximum for the format: 34
at androidx.camera.camera2.internal.SupportedSurfaceCombination.getSupportedOutputSizes(SupportedSurfaceCombination.java:355)
at androidx.camera.camera2.internal.SupportedSurfaceCombination.getSuggestedResolutions(SupportedSurfaceCombination.java:197)
at androidx.camera.camera2.internal.Camera2DeviceSurfaceManager.getSuggestedResolutions(Camera2DeviceSurfaceManager.java:198)
at androidx.camera.core.CameraX.calculateSuggestedResolutions(CameraX.java:943)
at androidx.camera.core.CameraX.bindToLifecycle(CameraX.java:293)
at androidx.camera.lifecycle.ProcessCameraProvider.bindToLifecycle(ProcessCameraProvider.java:227)
Below are some findings based on our debugging
When Dex is connected
previewConfig.getMaxResolution() is returning "731x411" as maxSize.
Inside Preview.Builder.build() -> Default_MAX_resolution is set to "CameraX.getSurfaceManager().getPreviewSize()" which is 731x411
this is being picked as maxSize.
While rendering maxSize is 731x411 and minSize is 640x480 and below are available outputSizes
0 = {Size@11860} "4032x3024"
1 = {Size@11861} "3984x2988"
2 = {Size@11862} "4032x2268"
3 = {Size@11863} "3024x3024"
4 = {Size@11864} "2976x2976"
5 = {Size@11865} "3840x2160"
6 = {Size@11866} "3264x2448"
7 = {Size@11867} "4032x1960"
8 = {Size@11868} "2880x2160"
9 = {Size@11869} "3264x1836"
10 = {Size@11870} "2160x2160"
11 = {Size@11871} "2560x1440"
12 = {Size@11872} "2224x1080"
13 = {Size@11873} "2048x1152"
14 = {Size@11874} "1920x1080"
15 = {Size@11875} "1440x1080"
16 = {Size@11876} "1088x1088"
17 = {Size@11877} "1280x720"
18 = {Size@11878} "1024x768"
19 = {Size@11879} "1056x704"
20 = {Size@11880} "960x720"
21 = {Size@11881} "960x540"
22 = {Size@11882} "720x720"
23 = {Size@11883} "800x450"
24 = {Size@11884} "720x480"
25 = {Size@11885} "640x480"
26 = {Size@11886} "352x288"
27 = {Size@11887} "320x240"
28 = {Size@11888} "256x144"
29 = {Size@11889} "176x144"
and couldn't find any size in this range.
When Dex not connected
minsize = 640x480
maxsize = 1920x1080
0 = {Size@11836} "4032x3024"
1 = {Size@11837} "3984x2988"
2 = {Size@11838} "4032x2268"
3 = {Size@11839} "3024x3024"
4 = {Size@11840} "2976x2976"
5 = {Size@11841} "3840x2160"
6 = {Size@11842} "3264x2448"
7 = {Size@11843} "4032x1960"
8 = {Size@11844} "2880x2160"
9 = {Size@11845} "3264x1836"
10 = {Size@11846} "2160x2160"
11 = {Size@11847} "2560x1440"
12 = {Size@11848} "2224x1080"
13 = {Size@11849} "2048x1152"
14 = {Size@11850} "1920x1080"
15 = {Size@11851} "1440x1080"
16 = {Size@11852} "1088x1088"
17 = {Size@11853} "1280x720"
18 = {Size@11854} "1024x768"
19 = {Size@11855} "1056x704"
20 = {Size@11856} "960x720"
21 = {Size@11857} "960x540"
22 = {Size@11858} "720x720"
23 = {Size@11859} "800x450"
24 = {Size@11860} "720x480"
25 = {Size@11861} "640x480"
26 = {Size@11862} "352x288"
27 = {Size@11863} "320x240"
28 = {Size@11864} "256x144"
29 = {Size@11865} "176x144"
and we have 12 available sizes in this range
Camera2DeviceSurfaceManager.java:: getPreviewSize()
mCameraSupportedSurfaceCombinationMap.get(cameraId).getSurfaceDefinition().getPreviewSize() = "1920x1080"
cameraId=0
ap...@google.com <ap...@google.com> #4
The issue root cause is that CameraX will default filter out sizes smaller than 640x480. For Preview, the max size will be limited to under display size. I checked the HW spec info for the issue related devices. Display size of FUJITSU F-04J/F-05J is 360x640. That will result int that no size exists in the conditions that is larger or equal to 640x480 and smaller or equal to 360x640.
A temporary workaround for this situation is to use Preview.Builder#setTargetResolution() to set a size smaller than 640x480 to bypass the problem.
For device FUJITSU arrowsM04, I checked its HW spec info and its display size I found is 1280x720. It seems that the problem should not exist in the device.
Could you confirm that the problem exist on arrowsM04 device? What will be the returned value when using Display#getRealSize to obtain the display size?
ap...@google.com <ap...@google.com> #5
> A temporary workaround for this situation is to use Preview.Builder#setTargetResolution() to set a size smaller than 640x480 to bypass the problem.
OK. I will try it.
> Could you confirm that the problem exist on arrowsM04 device?
We receive the crash report (Crashlytics) that this crash has occurred on arrowsM04.
We don't have this device so we can't confirm that the problem really exist on arrowsM04.
> What will be the returned value when using Display#getRealSize to obtain the display size?
We can't investigate it for the same reason.
Thank you.
ap...@google.com <ap...@google.com> #6
This issue happened on devices that the display size is smaller than 640x480. In original auto-resolution mechanism, supported sizes smaller than 640x480 will be default filter out.
The auto-resolution mechanism encodes the guaranteed configurations tables in CameraDevice#createCaptureSession(SessionConfiguration). It defines that the PREVIEW size is the small one of the device display size and 1080p. The PREVIEW size will be the maximal size limitation for Preview use case. The reason it limits the size to display size and 1080p is the stream output in display size or 1080p has been able to provide good enough preview quality. Therefore, auto-resolution mechanism will limit the selected size to be smaller than the small one of the device display size and 1080p.
With above two conditions, in this issue, all sizes smaller than 640x480 have been filter out, therefore, there is no size smaller than the display size 320x240 can be selected to use. And cause the exception.
Solution:
When the display size is smaller than 640x480, auto-resolution mechanism won't filter out those small sizes smaller than 640x480. This makes those small size be left and can be selected for the Preview use case on small display devices.
The solution has been merged and will be included in next CameraX release.
ap...@google.com <ap...@google.com> #7
Hello.
This crash still occurs.
- CAMERAX VERSION: 1.0.0-beta4
- ANDROID OS BUILD NUMBER: Android 7.1.1
- DEVICE NAME: FUJITSU F-02H
We receive following crash report from FUJITSU F-02H. So far We have received this crash report only from F-02H.
java.lang.IllegalArgumentException
Can not get supported output size under supported maximum for the format: 34
androidx.camera.camera2.internal.SupportedSurfaceCombination.getSupportedOutputSizes (SupportedSurfaceCombination.java:349)
androidx.camera.camera2.internal.SupportedSurfaceCombination.getSuggestedResolutions (SupportedSurfaceCombination.java:197)
androidx.camera.camera2.internal.Camera2DeviceSurfaceManager.getSuggestedResolutions (Camera2DeviceSurfaceManager.java:198)
androidx.camera.core.CameraX.calculateSuggestedResolutions (CameraX.java:949)
androidx.camera.core.CameraX.bindToLifecycle (CameraX.java:351)
androidx.camera.lifecycle.ProcessCameraProvider.bindToLifecycle (ProcessCameraProvider.java:230)
(our application's package name).CameraFragment.bindCameraUseCases (CameraFragment.java:174)
ap...@google.com <ap...@google.com> #8
Could you help to provide the following information to clarify the issue?
1. Is the full name of the device Fujitsu Arrows NX F-02H that has a 1440x2560 display?
2. Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
ap...@google.com <ap...@google.com> #9
- Is the full name of the device Fujitsu Arrows NX F-02H that has a 1440x2560 display?
Yes
- Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
Since we don't have this device, we'll try to collect this information in the next version of our app. The next version will be released later this month.
ap...@google.com <ap...@google.com> #10
Hello.
- Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
We have collected the output of the device where the crash occurs.
Device1
- Model : arrows Be F-05J
- Android Version : 7.1.1
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0: 480x480
CameraId 1: 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
Device2
- Model : Fujitsu arrows M04
- Android Version : 7.1.1
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0: 480x480
CameraId 1: 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
Additional Information
CameraX version : 1.0.0-beta04
We collect the supported output sizes by following code.
val errorString = buildString {
append("The supported output sizes of ImageFormat.PRIVATE: ")
(requireContext().getSystemService(Context.CAMERA_SERVICE) as CameraManager).apply {
cameraIdList.forEachIndexed { index, cameraId ->
val msg = if (VERSION.SDK_INT >= VERSION_CODES.M) {
val configurationMap =
getCameraCharacteristics(cameraId).get(CameraCharacteristics.SCALER_STREAM_CONFIGURATION_MAP)
val sizes = configurationMap?.getOutputSizes(ImageFormat.PRIVATE)
"CameraId $index: ${sizes?.joinToString(" ,")}"
} else {
"CameraId $index: This device version is under M."
}
append(msg)
}
}
}
ap...@google.com <ap...@google.com> #11
ap...@google.com <ap...@google.com> #12
I tried to find the device specs and both 720x1280
size display. For the camera id 0 device, it is a different case that the display size is larger than 640x480
but the device only supports a 480x480
size. The case also caused the same IllegalArgumentException and was also fixed by 1.0.0-beta04
release. Before 480x480
size would be filtered out and then caused the IllegalArgumentException. After it was merged, the 640x480
size threshold was removed and then the 480x480
size would be kept and selected to use.
It looks like 1.0.0-beta04
release had been used to collect the supported sizes information. But the issue should have been fixed by 1.0.0-beta04
release. Did you only check the device model name to collect the supported sizes information or collect the information when the IllegalArgumentException issue happens again?
CameraX's 1.0.0-beta04
version. Maybe you can also consider to upgrade to the latest 1.0.0-rc01
version for your application. Thanks.
sa...@google.com <sa...@google.com>
ap...@google.com <ap...@google.com> #13
Did you only check the device model name to collect the supported sizes information or collect the information when the IllegalArgumentException issue happens again?
We collect informations only from the device on which IllegalArgumentException happened.
Our latest app uses CameraX version 1.0.0-beta10
and this issue still occurres.
However we don't receive crash report from Fujitsu arrows Be F-05J
or Fujitsu arrows M04
so far. (This doesn't mean this issue is fixed on these devices because our app is heavily rely on camera so these device's user wouldn't use our app anymore.)
Instead, we receive crash report from
- Model : Fujitsu F-03K
- Android Version : 7.1.2
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0 : 480x480
CameraId 1 : 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
ap...@google.com <ap...@google.com> #14
I missed some settings when I simulated the issue by robolectric test so that I was not able to reproduce it. Now, I can reproduce the issue if the device only supports one 480x480 resolution. I'm working on the solution and target to make it included in next release.
ap...@google.com <ap...@google.com> #15
Branch: androidx-main
commit 69d15dff7bb857ee33a0f643ff42a0f8bc475ab2
Author: charcoalchen <charcoalchen@google.com>
Date: Fri Jan 08 18:30:03 2021
Fixed IllegalArgumentException issue happened when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480.
Do not filter out sizes smaller than 640x480 when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480.
Relnote:"Fixed IllegalArgumentException issue happened when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480."
Bug: 150506192
Test: SupportedSurfaceCombinationTest
Change-Id: I2a63ce8e2ad42a9cc060c8635ac3603bf440b1ec
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/SupportedSurfaceCombination.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/SupportedSurfaceCombinationTest.java
ap...@google.com <ap...@google.com> #16
ap...@google.com <ap...@google.com> #17
Branch: androidx-main
commit 1ded30b61266b01a13a8c2d5bd57b7bc07a8109a
Author: sanura <sanura@google.com>
Date: Fri Nov 11 00:35:44 2022
Make SafeIterableMap.SupportRemove public
SafeIterableMap.SupportRemove should be a
library restricted public class to match
the rest of SafeIterableMap
Bug: 240298691
Test: ./gradlew bOS
Change-Id: Ifd0fba2c89992d157043ba6f36e920818cfa7fe4
M arch/core/core-common/api/restricted_current.txt
M arch/core/core-common/src/main/java/androidx/arch/core/internal/SafeIterableMap.java
ap...@google.com <ap...@google.com> #18
Branch: androidx-main
commit 894dc6b36affc54ffeea3cabbd3b6b7e5a0f6760
Author: sanura <sanura@google.com>
Date: Fri Nov 11 00:26:48 2022
Have lifecycle-runtime depend on ToT arch.core
Lifecycle-runtime should depend on ToT
arch.core for future changes to apply
Bug: 240298691
Test: ./gradlew bOS
Change-Id: I8a7a678c6d26f8972e6949120d3cc0b8d2d2990d
M lifecycle/lifecycle-runtime/build.gradle
M settings.gradle
ap...@google.com <ap...@google.com> #19
Branch: androidx-main
commit 36833f9ab0c50bf449fc795e297a0e124df3356e
Author: sanura <sanura@google.com>
Date: Tue Nov 08 19:48:07 2022
Convert LifecycleRegistry to Kotlin
Part of the kotlinification process of Lifecycle library.
RelNote: "`LifecycleRegistry` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I9593df2393b1399302ade4acc011128fce3277b2
M lifecycle/lifecycle-runtime/api/current.txt
M lifecycle/lifecycle-runtime/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-runtime/api/restricted_current.txt
M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime/src/main/java/androidx/lifecycle/LifecycleRegistry.kt
ap...@google.com <ap...@google.com> #20
Branch: androidx-main
commit 19acbc4b7d73c6bcf1b023658ccece32d76f28cd
Author: sanura <sanura@google.com>
Date: Mon Nov 07 21:23:52 2022
Rename LifecycleRegistry.java to .kt
Part of the kotlinification process of Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: Ia627d9465236c25b3c1cbe44d10ef34473ff7466
M lifecycle/lifecycle-runtime/src/main/java/androidx/lifecycle/LifecycleRegistry.kt
ap...@google.com <ap...@google.com> #21
Branch: androidx-main
commit 98acf57aed0b14d252bafa7941d47bcf3a2ab4de
Author: sanura <sanura@google.com>
Date: Fri Nov 04 21:16:54 2022
Rename Lifecycle.java to .kt
Part of the kotlinification process of Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: I88e713ed0c3beafbfb9f75ade98ce447a98b3537
M lifecycle/lifecycle-common/src/main/java/androidx/lifecycle/Lifecycle.kt
ap...@google.com <ap...@google.com> #22
Branch: androidx-main
commit 1eb1fdc1016f40849e5a7b34d3928d8e4cca3e22
Author: sanura <sanura@google.com>
Date: Tue Nov 15 20:32:00 2022
Convert MethodCallsLogger to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`MethodCallsLogger` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: Ibb2b3c3c6bd4e2437851bf3ff0058ebf3d810867
M lifecycle/lifecycle-common/api/restricted_current.txt
M lifecycle/lifecycle-common/src/main/java/androidx/lifecycle/MethodCallsLogger.kt
ap...@google.com <ap...@google.com> #23
Branch: androidx-main
commit 3958a4b5e8f31682ec66977cd5a2285871098129
Author: sanura <sanura@google.com>
Date: Tue Nov 15 20:17:09 2022
Rename MethodCallsLogger.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: I4623b79a89016c996336a8d23ed9fa46b7dbe729
M lifecycle/lifecycle-common/src/main/java/androidx/lifecycle/MethodCallsLogger.kt
ap...@google.com <ap...@google.com> #24
Branch: androidx-main
commit 952038f759cd4abd8e1319c8bd023e33d6c800c5
Author: sanura <sanura@google.com>
Date: Tue Nov 15 19:12:16 2022
Convert Lifecycling to Kotlin
Part of the kotlinification process of Lifecycle library.
RelNote: "`Lifecycling` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I710df90fcb32b7c00229f336c0221e03157089eb
M lifecycle/lifecycle-common/api/restricted_current.txt
M lifecycle/lifecycle-common/src/main/java/androidx/lifecycle/Lifecycling.kt
M lifecycle/lifecycle-common/src/test/java/androidx/lifecycle/LifecyclingTest.java
M lifecycle/lifecycle-runtime/src/main/java/androidx/lifecycle/LifecycleRegistry.kt
ap...@google.com <ap...@google.com> #25
Branch: androidx-main
commit 6092074dcf81e45f6e0279a56998625e397b6cb6
Author: sanura <sanura@google.com>
Date: Tue Nov 15 18:53:25 2022
Rename Lifecycling.java to .kt
Part of the kotlinification process of Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: I59db3960254d767f695882fdd36fa652d662ffe3
M lifecycle/lifecycle-common/src/main/java/androidx/lifecycle/Lifecycling.kt
ap...@google.com <ap...@google.com> #26
Branch: androidx-main
commit 419af59e501f486eb23039a2c1746156cb159877
Author: sanura <sanura@google.com>
Date: Thu Nov 17 23:16:59 2022
Convert DefaultLifecycleObserverAdapter to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`DefaultLifecycleObserverAdapter` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: Ibf1ef5008863b43947384d63656d4c6fd8675bdb
M lifecycle/lifecycle-common/src/main/java/androidx/lifecycle/DefaultLifecycleObserverAdapter.kt
ap...@google.com <ap...@google.com> #27
Branch: androidx-main
commit a2224cc5e2dffa8d5f1c6e40527bb67789e11eab
Author: sanura <sanura@google.com>
Date: Thu Nov 17 23:13:07 2022
Rename DefaultLifecycleObserverAdapter.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: If9d2ed48c5811a92470a2c61583e79c532bf0c2c
M lifecycle/lifecycle-common/src/main/java/androidx/lifecycle/DefaultLifecycleObserverAdapter.kt
ap...@google.com <ap...@google.com> #28
Branch: androidx-main
commit ed2f8fcf9816984901e6b1fc315034e8815a6428
Author: sanura <sanura@google.com>
Date: Wed Nov 30 17:55:11 2022
Convert EmptyActivityLifecycleCallbacks to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`EmptyActivityLifecycleCallbacks` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: Ie1f91088fcda72b83b7fcca84b7789a04a838301
M lifecycle/lifecycle-process/build.gradle
M lifecycle/lifecycle-process/src/main/java/androidx/lifecycle/EmptyActivityLifecycleCallbacks.kt
ap...@google.com <ap...@google.com> #29
Branch: androidx-main
commit 7f1d68b4ab7f2612c4377f3ea62742d90471abe0
Author: sanura <sanura@google.com>
Date: Wed Nov 30 17:49:14 2022
Rename EmptyActivityLifecycleCallbacks.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: I8fe77d60b2c70272089bab3fad1cafaedbe973a7
M lifecycle/lifecycle-process/src/main/java/androidx/lifecycle/EmptyActivityLifecycleCallbacks.kt
ap...@google.com <ap...@google.com> #30
Branch: androidx-main
commit a5cf65a4b7c19ea34b13da33adf5ffee3a930693
Author: sanura <sanura@google.com>
Date: Wed Nov 30 18:09:55 2022
Convert LifecycleDispatcher to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`LifecycleDispatcher` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: Ia7a1eb8480ab13ba4eb3a6c71047bf3308a5ef3f
M lifecycle/lifecycle-process/build.gradle
M lifecycle/lifecycle-process/src/main/java/androidx/lifecycle/LifecycleDispatcher.kt
ap...@google.com <ap...@google.com> #31
Branch: androidx-main
commit b16d8b0e388b3d69eb17ec481d4a9eb95aa0789f
Author: sanura <sanura@google.com>
Date: Wed Nov 30 18:07:30 2022
Rename LifecycleDispatcher.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: Id784041f7ac015ea958a742882564bf77ddfbe0e
M lifecycle/lifecycle-process/src/main/java/androidx/lifecycle/LifecycleDispatcher.kt
ap...@google.com <ap...@google.com> #32
Branch: androidx-main
commit fb66ace12c5f1354363168d0a308b16d0937eebe
Author: sanura <sanura@google.com>
Date: Wed Nov 30 18:29:34 2022
Convert ProcessLifecycleInitializer to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`ProcessLifecycleInitializer` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: Ic9732fa0da60df1bc1510f7aea6bfc0e4ac1f0e3
A lifecycle/lifecycle-process/api/current.ignore
M lifecycle/lifecycle-process/api/current.txt
M lifecycle/lifecycle-process/api/public_plus_experimental_current.txt
A lifecycle/lifecycle-process/api/restricted_current.ignore
M lifecycle/lifecycle-process/api/restricted_current.txt
M lifecycle/lifecycle-process/build.gradle
M lifecycle/lifecycle-process/src/main/java/androidx/lifecycle/ProcessLifecycleInitializer.kt
ap...@google.com <ap...@google.com> #33
Branch: androidx-main
commit 3446edd47a882518ae7ed0df85aeada213c322bb
Author: sanura <sanura@google.com>
Date: Wed Nov 30 18:12:38 2022
Rename ProcessLifecycleInitializer.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: If9a4c269cd0d8e794569cd9d81ccdcef546a2c0a
M lifecycle/lifecycle-process/src/main/java/androidx/lifecycle/ProcessLifecycleInitializer.kt
ap...@google.com <ap...@google.com> #34
Branch: androidx-main
commit 1f901e138b4ea1322809508dfbd5fd59385a9d0b
Author: sanura <sanura@google.com>
Date: Tue Dec 13 22:00:27 2022
Ensure Compose test classes utilize TestLifecycleOwner
Rather than created their own LifecycleOwner,
all tests should utilize the public TestLifecycleOwner
which handles all necessary lifecycle elements for
the developer.
Bug: 240298691
Test: all tests pass
Change-Id: Ibec52e30aa93eb94ef28e9d0b149f2c030355084
M compose/runtime/runtime-livedata/build.gradle
M compose/runtime/runtime-livedata/src/androidTest/java/androidx/compose/runtime/livedata/LiveDataAdapterTest.kt
M compose/ui/ui/build.gradle
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/platform/WrapperTest.kt
ap...@google.com <ap...@google.com> #35
Branch: androidx-main
commit 24a7249023d9e96dda8fa3c0b631cce833255b1a
Author: sanura <sanura@google.com>
Date: Wed Dec 14 23:01:52 2022
Update work's PreferenceUtils to java 8 syntax
Updating the work module's PreferenceUtils class
to utilize java 8 lambda syntax.
Test: ./gradlew bOS
Bug: 240298691
Change-Id: I59f0159a44b54cb770437a150e73afe3932ab868
M work/work-runtime/src/main/java/androidx/work/impl/utils/PreferenceUtils.java
ap...@google.com <ap...@google.com> #36
Branch: androidx-main
commit e4c197341e930ad52756c3328d7e309c0e8519f6
Author: sanura <sanura@google.com>
Date: Wed Dec 14 22:58:40 2022
Update PhotoViewModel to java 8 syntax
Updating leanback's PhotoViewModel class to
utilize java 8 lamba syntax.
Test: ./gradlew bOS
Bug: 240298691
Change-Id: I5d9c7fb056291c2cbffdf936d1b87cc252aab97f
M samples/SupportLeanbackDemos/src/main/java/com/example/android/leanback/PhotoViewModel.java
ap...@google.com <ap...@google.com> #37
Branch: androidx-main
commit 31928069e4c7919b89836c06b3ad6d9dda568246
Author: sanura <sanura@google.com>
Date: Fri Dec 02 02:49:02 2022
Remove original LiveDataReactiveStreams kotlin extensions
Removing the original kotlin extension methods
created for LiveDataReactiveStreams within the
livedata-reactivestreams-ktx lifeycle module.
RelNote: "The `LiveDataReactiveSteams` kotlin
extensions have now been moved to the main
lifeycle module."
Bug: 240298691
Test: ./gradlew checkApi
Change-Id: I95d22efa7df46ff8444f207ec015bfc9935a4457
A lifecycle/lifecycle-reactivestreams-ktx/api/current.ignore
M lifecycle/lifecycle-reactivestreams-ktx/api/current.txt
M lifecycle/lifecycle-reactivestreams-ktx/api/public_plus_experimental_current.txt
A lifecycle/lifecycle-reactivestreams-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-reactivestreams-ktx/api/restricted_current.txt
D lifecycle/lifecycle-reactivestreams-ktx/src/main/java/androidx/lifecycle/LiveDataReactiveSteams.kt
M lifecycle/lifecycle-reactivestreams/api/current.txt
M lifecycle/lifecycle-reactivestreams/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-reactivestreams/api/restricted_current.txt
M lifecycle/lifecycle-reactivestreams/build.gradle
M lifecycle/lifecycle-reactivestreams/src/main/java/androidx/lifecycle/LiveDataReactiveStreams.kt
M lifecycle/lifecycle-reactivestreams/src/test/java/androidx/lifecycle/LiveDataReactiveStreamsExtensionTest.kt
ap...@google.com <ap...@google.com> #38
Branch: androidx-main
commit e7b76039675ddd7cb7f4d6c4b3d88e82de6e9150
Author: sanura <sanura@google.com>
Date: Wed Nov 30 18:55:42 2022
Convert LiveDataReactiveStreams to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`LiveDataReactiveStreams` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I2b1b9e5dadf2e108e7539ef398e4d252b0ca9043
M lifecycle/lifecycle-reactivestreams-ktx/src/test/java/androidx/lifecycle/LiveDataReactiveStreamsTest.kt
A lifecycle/lifecycle-reactivestreams/api/current.ignore
M lifecycle/lifecycle-reactivestreams/api/current.txt
M lifecycle/lifecycle-reactivestreams/api/public_plus_experimental_current.txt
A lifecycle/lifecycle-reactivestreams/api/restricted_current.ignore
M lifecycle/lifecycle-reactivestreams/api/restricted_current.txt
M lifecycle/lifecycle-reactivestreams/build.gradle
M lifecycle/lifecycle-reactivestreams/src/main/java/androidx/lifecycle/LiveDataReactiveStreams.kt
ap...@google.com <ap...@google.com> #39
Branch: androidx-main
commit a57c3dfd2688605155ba8c8e7546101dec80525e
Author: sanura <sanura@google.com>
Date: Wed Nov 30 18:35:11 2022
Rename LiveDataReactiveStreams.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: Ia12806bdf21ccd0f65a42cfd6ac9a75256ada60c
M lifecycle/lifecycle-reactivestreams/src/main/java/androidx/lifecycle/LiveDataReactiveStreams.kt
ap...@google.com <ap...@google.com> #40
Branch: androidx-main
commit 79f3e3eae6f34a10e3694e4fb15dc9ca683e0152
Author: sanura <sanura@google.com>
Date: Tue Dec 06 23:03:39 2022
Update paparazzi module to use ViewTreeLifecycleOwner extensions
The paparazzi module should now be using the kotlin
extensions in the main lifecycle module to find and
set a ViewTreeLifecycleOwner.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I90d3f74fdd661a59a88588bd72c32419077cf8ca
M external/paparazzi/paparazzi/build.gradle
M external/paparazzi/paparazzi/src/main/java/app/cash/paparazzi/Paparazzi.kt
ap...@google.com <ap...@google.com> #41
Branch: androidx-main
commit c43d7839ab77ee711b4b707114582b03a8209438
Author: sanura <sanura@google.com>
Date: Tue Dec 06 22:54:39 2022
Update fragment module to use ViewTreeLifecycleOwner extensions
The fragment module should now be using the kotlin
extensions in the main lifecycle module to find and
set a ViewTreeLifecycleOwner.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I9fa1fdbd73cca82684b604dd55cf07a20c746d25
M fragment/fragment/build.gradle
M fragment/fragment/src/androidTest/java/androidx/fragment/app/DialogFragmentViewTreeTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentViewLifecycleTest.kt
ap...@google.com <ap...@google.com> #42
Branch: androidx-main
commit b5b51f4277983649a81b735d68d8c2b72a7412e0
Author: sanura <sanura@google.com>
Date: Tue Dec 06 22:26:49 2022
Update appcompat module to use ViewTreeLifecycleOwner extensions
The appcompat module should now be using the kotlin
extensions in the main lifecycle module to find and
set a ViewTreeLifecycleOwner.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I3eb959f9bf476df9c7cd01ec5e7121714e744485
M appcompat/appcompat/build.gradle
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/AppCompatActivityViewTreeTest.kt
ap...@google.com <ap...@google.com> #43
Branch: androidx-main
commit 763af5867460b512a3b1dc7b1c1799a855d5f366
Author: sanura <sanura@google.com>
Date: Fri Dec 02 03:54:22 2022
Convert ViewTreeLifecycleOwner to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`ViewTreeLifecycleOwner` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I8a77a0b14345639a2bc7c96004017afb54a7f3e0
M lifecycle/lifecycle-runtime-ktx/src/androidTest/java/androidx/lifecycle/ViewTreeLifecycleOwnerTest.kt
M lifecycle/lifecycle-runtime-ktx/src/main/java/androidx/lifecycle/View.kt
M lifecycle/lifecycle-runtime/api/current.txt
M lifecycle/lifecycle-runtime/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-runtime/api/restricted_current.txt
M lifecycle/lifecycle-runtime/src/main/java/androidx/lifecycle/ViewTreeLifecycleOwner.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidTest/java/androidx/lifecycle/viewmodel/compose/ViewModelTest.kt
ap...@google.com <ap...@google.com> #44
Branch: androidx-main
commit 63437cb47c6766dea6645ed7a8a119c73ff3e866
Author: sanura <sanura@google.com>
Date: Wed Nov 30 19:05:45 2022
Rename ViewTreeLifecycleOwner.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: I71151788826af3de54bdc8237798f1c40322a94e
M lifecycle/lifecycle-runtime/src/main/java/androidx/lifecycle/ViewTreeLifecycleOwner.kt
ap...@google.com <ap...@google.com> #45
Branch: androidx-main
commit 21c2122042907dcc7e075f8ba874972821de9447
Author: sanura <sanura@google.com>
Date: Fri Dec 02 04:07:02 2022
Update compose module to use ViewTreeLifecycleOwner extensions
The compose module should now be using the kotlin
extensions in the main lifecycle module to find and
set a ViewTreeLifecycleOwner.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I6979ead7a5d205db10feb682c888d5f452d18b0a
M compose/material/material/src/androidMain/kotlin/androidx/compose/material/internal/ExposedDropdownMenuPopup.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/internal/ExposedDropdownMenuPopup.kt
M compose/runtime/runtime-livedata/build.gradle
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/junit4/ComposeRootRegistry.android.kt
M compose/ui/ui-tooling/src/androidMain/kotlin/androidx/compose/ui/tooling/ComposeViewAdapter.kt
M compose/ui/ui/build.gradle
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/platform/WrapperTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/viewinterop/AndroidViewTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/window/PopupTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/ComposeView.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/ViewCompositionStrategy.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/WindowRecomposer.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/viewinterop/AndroidViewHolder.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidDialog.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidPopup.android.kt
M hilt/hilt-navigation-compose/build.gradle
M wear/compose/compose-navigation/build.gradle
ap...@google.com <ap...@google.com> #46
Branch: androidx-main
commit ac2e62ab9afffd1a31d1c08d1984fd1a1340100f
Author: sanura <sanura@google.com>
Date: Fri Dec 02 04:04:35 2022
Update activity module to use ViewTreeLifecycleOwner extensions
The activity module should now be using the kotlin
extensions in the main lifecycle module to find and
set a ViewTreeLifecycleOwner.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I250591060ed84c0f31a9db8346bca43efccfa4fa
M activity/activity-compose/src/main/java/androidx/activity/compose/ComponentActivity.kt
M activity/activity/src/androidTest/java/androidx/activity/ContentViewTest.kt
M activity/activity/src/main/java/androidx/activity/ComponentDialog.kt
ap...@google.com <ap...@google.com> #47
Branch: androidx-main
commit 906549d4fd0b61c417bdf9c02c1d276f7054203f
Author: sanura <sanura@google.com>
Date: Fri Dec 02 04:01:36 2022
Deprecate original ViewTreeLifecycleOwner kotlin extensions
Deprecating the original kotlin extension methods
created for ViewTreeLifecycleOwner within the
lifecycle-runtime-ktx module.
RelNote: "Original ViewTreeLifecycleOwner kotlin
extensions have now been deprecated and should be
replaced with the extensions found in the main
lifeycle module."
Bug: 240298691
Test: ./gradlew checkApi
Change-Id: I5234e702d384ac8bdbb9b2f45ae98e146cca21cb
M lifecycle/lifecycle-runtime-ktx/api/current.txt
M lifecycle/lifecycle-runtime-ktx/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-runtime-ktx/api/restricted_current.txt
D lifecycle/lifecycle-runtime-ktx/src/androidTest/java/androidx/lifecycle/ViewTreeLifecycleOwnerTest.kt
M lifecycle/lifecycle-runtime-ktx/src/main/java/androidx/lifecycle/View.kt
ap...@google.com <ap...@google.com> #48
Branch: androidx-main
commit 543d47b125ebc6da4a66d9df4da1b1d333386a50
Author: sanura <sanura@google.com>
Date: Wed Nov 30 20:27:45 2022
Convert ComputableLiveData to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`ComputableLiveData` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: Ie013339e6119eb06d45c26bf857adc5b56c3b907
A lifecycle/lifecycle-livedata/api/restricted_current.ignore
M lifecycle/lifecycle-livedata/api/restricted_current.txt
M lifecycle/lifecycle-livedata/build.gradle
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/ComputableLiveData.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/ComputableLiveDataTest.java
ap...@google.com <ap...@google.com> #49
Branch: androidx-main
commit f533103eb8806ec94f966ae9553e8220633066ee
Author: sanura <sanura@google.com>
Date: Fri Nov 18 23:50:33 2022
Rename ComputableLiveData.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: I1c13222dc31ab8e0054f059d20d510c23457ee63
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/ComputableLiveData.kt
sa...@google.com <sa...@google.com> #50
Noting that we will not be able to convert LiveData
or its sub-classes to Kotlin due to the generics on those classes and the setValue/getValue nullability. Currently, kotlin does not allow for setters and getters to have differing nullability. Once this is changed, these classes can be converted. Filed a bug for this issue:
ap...@google.com <ap...@google.com> #51
Branch: androidx-main
commit bcfddcbe92bad2b8f9d53d5b3413e153e11d5c7f
Author: sanura <sanura@google.com>
Date: Wed Nov 30 21:11:30 2022
Convert Transformations to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`Transformations` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I88c1a0e58bbc82e5f7678e2a76413949f322e391
A lifecycle/lifecycle-livedata/api/current.ignore
M lifecycle/lifecycle-livedata/api/current.txt
M lifecycle/lifecycle-livedata/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-livedata/api/restricted_current.ignore
M lifecycle/lifecycle-livedata/api/restricted_current.txt
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/Transformations.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/TransformationsTest.java
ap...@google.com <ap...@google.com> #52
Branch: androidx-main
commit 6dedd2f4983b52216ae10aa421846789ccb614f0
Author: sanura <sanura@google.com>
Date: Tue Nov 29 19:23:27 2022
Rename Transformations.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: Iaf1b37d789c9e548889045b1975c6cc6b7e5a326
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/Transformations.kt
ap...@google.com <ap...@google.com> #53
Branch: androidx-main
commit 6d86ebbf72f203ffb905ab6f9d3ebb4812c24cfe
Author: sanura <sanura@google.com>
Date: Fri Dec 02 03:31:30 2022
Remove original LiveData Transformations kotlin extensions
Removing the original kotlin extension methods
created for LiveData Transformations within the
lifecycle-livedata-ktx module.
RelNote: "The `LiveData` Transformations kotlin
extensions have now been moved to the main
lifeycle module."
Bug: 240298691
Test: ./gradlew checkApi
Change-Id: I43e6abafc3989932cdeef7b6664789d5a314ff8b
A lifecycle/lifecycle-livedata-ktx/api/current.ignore
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_current.txt
A lifecycle/lifecycle-livedata-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
D lifecycle/lifecycle-livedata-ktx/src/main/java/androidx/lifecycle/Transformations.kt
D lifecycle/lifecycle-livedata-ktx/src/test/java/androidx/lifecycle/TransformationsTest.kt
ap...@google.com <ap...@google.com> #54
Branch: androidx-main
commit 8aa6ca1c924ab10d263b21b99b8790d5f0b50cc6
Author: sanura <sanura@google.com>
Date: Fri Dec 16 00:40:59 2022
Convert ViewModelStore to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`ViewModelStore` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I59a23a57833e4034474fb6890d4681d8ffb274ae
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelProvider.kt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelStore.kt
ap...@google.com <ap...@google.com> #55
Branch: androidx-main
commit 401acbbce9e14745594b8d3d7a5b3f25e5462dd4
Author: sanura <sanura@google.com>
Date: Thu Dec 15 19:44:27 2022
Rename ViewModelStore.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: Ifa43d84512aeea0fa247ecaffa167b59fe942da0
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelStore.kt
ap...@google.com <ap...@google.com> #56
Branch: androidx-main
commit 013ec849eb342d1658b3879c3c9cef59a09d44e3
Author: sanura <sanura@google.com>
Date: Thu Dec 15 03:14:29 2022
Convert LifecycleService to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`LifecycleService` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I160d7e0be9d70207038f35a19cb05e5fcf8d25b2
A lifecycle/lifecycle-service/api/current.ignore
M lifecycle/lifecycle-service/api/current.txt
M lifecycle/lifecycle-service/api/public_plus_experimental_current.txt
A lifecycle/lifecycle-service/api/restricted_current.ignore
M lifecycle/lifecycle-service/api/restricted_current.txt
M lifecycle/lifecycle-service/build.gradle
M lifecycle/lifecycle-service/src/androidTest/java/androidx/lifecycle/service/TestService.java
M lifecycle/lifecycle-service/src/main/java/androidx/lifecycle/LifecycleService.kt
ap...@google.com <ap...@google.com> #57
Branch: androidx-main
commit 94b972853ffc1d2240d1dd28ab864bc8c8539c4f
Author: sanura <sanura@google.com>
Date: Thu Dec 15 03:03:47 2022
Rename LifecycleService.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: I1ecbb567dc8609825109738a674a7ad50c3496e9
M lifecycle/lifecycle-service/src/main/java/androidx/lifecycle/LifecycleService.kt
ap...@google.com <ap...@google.com> #58
Branch: androidx-main
commit ded88c3136bb705d481249670366a2e692a140b0
Author: sanura <sanura@google.com>
Date: Thu Dec 15 03:36:22 2022
Convert ServiceLifecycleDispatcher to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`ServiceLifecycleDispatcher` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I088840f6961cdc5c6b8857cbd6f3bee0a7faa4e8
M lifecycle/lifecycle-service/api/current.txt
M lifecycle/lifecycle-service/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-service/api/restricted_current.txt
M lifecycle/lifecycle-service/build.gradle
M lifecycle/lifecycle-service/src/androidTest/java/androidx/lifecycle/service/TestService.java
M lifecycle/lifecycle-service/src/main/java/androidx/lifecycle/ServiceLifecycleDispatcher.kt
ap...@google.com <ap...@google.com> #59
Branch: androidx-main
commit 1492572c9a21c6ddaca175317ba7f031e63d2dd8
Author: sanura <sanura@google.com>
Date: Thu Dec 15 03:16:54 2022
Rename ServiceLifecycleDispatcher.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: I133e413f9bc7ff457d474c38d5cd2ed089549e47
M lifecycle/lifecycle-service/src/main/java/androidx/lifecycle/ServiceLifecycleDispatcher.kt
ap...@google.com <ap...@google.com> #60
Branch: androidx-main
commit e9f68820782c5c91e7a6973c8bbbc385b15cbe90
Author: sanura <sanura@google.com>
Date: Thu Dec 15 02:59:20 2022
Convert ProcessLifecycleOwner to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`ProcessLifecycleOwner` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I1cda7f18602f9d4831027d0199220285557d85ec
M lifecycle/lifecycle-process/api/current.ignore
M lifecycle/lifecycle-process/api/current.txt
M lifecycle/lifecycle-process/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-process/api/restricted_current.ignore
M lifecycle/lifecycle-process/api/restricted_current.txt
M lifecycle/lifecycle-process/src/main/java/androidx/lifecycle/ProcessLifecycleOwner.kt
ap...@google.com <ap...@google.com> #61
Branch: androidx-main
commit e21cec3aff0a735798d8173cd492ead4743a997e
Author: sanura <sanura@google.com>
Date: Thu Dec 15 02:35:14 2022
Rename ProcessLifecycleOwner.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: Iaed1c259c47a4dc0776ccd13ec809dba6f186a9a
M lifecycle/lifecycle-process/src/main/java/androidx/lifecycle/ProcessLifecycleOwner.kt
ap...@google.com <ap...@google.com> #62
Branch: androidx-main
commit aedda8652c7d083c0a70f5fea1db5a625a321742
Author: sanura <sanura@google.com>
Date: Thu Dec 15 19:27:27 2022
Convert AndroidViewModel to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`AndroidViewModel` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I2e771b51b5f7a3250d862b659a48c6f6b709b025
M lifecycle/lifecycle-viewmodel/api/current.txt
M lifecycle/lifecycle-viewmodel/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-viewmodel/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/AndroidViewModel.kt
ap...@google.com <ap...@google.com> #63
Branch: androidx-main
commit 6720213d01826dc18c68f0b9681fb6868e06425d
Author: sanura <sanura@google.com>
Date: Thu Dec 15 18:54:11 2022
Rename AndroidViewModel.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: If2a12f3c84dcf5e88fd1ba19b68489d4f0e4829f
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/AndroidViewModel.kt
ap...@google.com <ap...@google.com> #64
Branch: androidx-main
commit b5fab4ce33d96b287dc3250d703ca43e15b8e0f1
Author: sanura <sanura@google.com>
Date: Thu Jan 12 19:18:29 2023
Convert SavedStateHandleController to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`SavedStateHandleController` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: Iaf36e36aaefcd2ebbda00d1a5167709f98371d80
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateHandleController.kt
ap...@google.com <ap...@google.com> #65
Branch: androidx-main
commit f9a8df12a2b74c8b939fd3a116cceb849314e152
Author: sanura <sanura@google.com>
Date: Thu Jan 12 19:11:55 2023
Rename SavedStateHandleController.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: I553114aa4ea3d38ca0c6cf31f59e7dfb71e56719
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateHandleController.kt
ap...@google.com <ap...@google.com> #66
Branch: androidx-main
commit bf8ba6061fd5afe25ee2375541cfd3fd1e7bfc9e
Author: sanura <sanura@google.com>
Date: Thu Jan 12 04:22:38 2023
Convert AbstractSavedStateViewModelFactory to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`AbstractSavedStateViewModelFactory` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: Ibae407718237391b600decdf0700a90c5e23e5b5
A lifecycle/lifecycle-viewmodel-savedstate/api/current.ignore
M lifecycle/lifecycle-viewmodel-savedstate/api/current.txt
M lifecycle/lifecycle-viewmodel-savedstate/api/public_plus_experimental_current.txt
A lifecycle/lifecycle-viewmodel-savedstate/api/restricted_current.ignore
M lifecycle/lifecycle-viewmodel-savedstate/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/AbstractSavedStateViewModelFactory.kt
ap...@google.com <ap...@google.com> #67
Branch: androidx-main
commit 4232923d9e051c6bc8eb03cee716a8e139edce8f
Author: sanura <sanura@google.com>
Date: Thu Jan 12 03:35:42 2023
Rename AbstractSavedStateViewModelFactory.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: Ib2d54ee8357732b45b15d04b780d72a2192bb077
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/AbstractSavedStateViewModelFactory.kt
ap...@google.com <ap...@google.com> #68
Branch: androidx-main
commit 2580b278592013eee615f3b02985cd89d854c724
Author: sanura <sanura@google.com>
Date: Thu Dec 15 21:45:33 2022
Update fragment module with HasDefaultViewModelProviderFactory
The fragment module should now be using the
updated apis for HasDefaultViewModelProviderFactory
following the kotlin conversion.
RelNote: "Fragment module now utilizes updated
Lifecycle APIs as a result of
`HasDefaultViewModelProviderFactory` conversion to kotlin."
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I558b84e6d2b25ac469749c43abbc286337391672
M fragment/fragment-ktx/src/androidTest/java/androidx/fragment/app/FragmentViewModelLazyTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentViewLifecycleOwnerTest.kt
ap...@google.com <ap...@google.com> #69
Branch: androidx-main
commit 41d19827d281f86e29dc1bf6603653d912d9d816
Author: sanura <sanura@google.com>
Date: Thu Dec 15 20:40:38 2022
Update navigation module with HasDefaultViewModelProviderFactory
The navigation module should now be using the
updated apis for HasDefaultViewModelProviderFactory
following the kotlin conversion.
RelNote: "Navigation module now utilizes updated
Lifecycle APIs as a result of
`HasDefaultViewModelProviderFactory` conversion to kotlin."
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I3b194a6201f507fb1ee00f894f8da3b14e89da3f
M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/src/main/java/androidx/navigation/NavBackStackEntry.kt
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/NavGraphViewModelLazyTest.kt
ap...@google.com <ap...@google.com> #70
Branch: androidx-main
commit c2fc8017364248b8b8634427d240112bfebff6e3
Author: sanura <sanura@google.com>
Date: Thu Dec 15 21:42:55 2022
Convert HasDefaultViewModelProviderFactory to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`HasDefaultViewModelProviderFactory` is now in Kotlin.
This is a source incompatible change for classes written
in Kotlin - they must now override the `defaultViewModelProviderFactory` and `defaultViewModelCreationExtras` properties rather than implementing the previous corresponding functions."
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: Iaed9c26539611f73794de6a1349e7b31a415ee9d
M activity/activity-ktx/src/androidTest/java/androidx/activity/ActivityViewModelLazyTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidTest/java/androidx/lifecycle/viewmodel/compose/ViewModelTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidTest/java/androidx/lifecycle/viewmodel/savedstate/ViewModelsWithStateTest.kt
M lifecycle/lifecycle-viewmodel/api/current.txt
M lifecycle/lifecycle-viewmodel/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-viewmodel/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/HasDefaultViewModelProviderFactory.kt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelProvider.kt
M lifecycle/lifecycle-viewmodel/src/test/java/androidx/lifecycle/ViewModelProviderTest.kt
ap...@google.com <ap...@google.com> #71
Branch: androidx-main
commit bfc7e25f19ccfa02ce884fef2b19d7efab8de9ca
Author: sanura <sanura@google.com>
Date: Thu Dec 15 19:29:50 2022
Rename HasDefaultViewModelProviderFactory.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: Iafaca705b38d54c0e0efdd5d9f148038c18ace8e
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/HasDefaultViewModelProviderFactory.kt
ap...@google.com <ap...@google.com> #72
Branch: androidx-main
commit 32235141b1f918c620248ad957ee584b9bc7243b
Author: sanura <sanura@google.com>
Date: Thu Jan 12 19:09:23 2023
Convert LegacySavedStateHandleController to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`LegacySavedStateHandleController` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I0fe7d1963879ecbcee860552d4e4de85e96bdc1a
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/AbstractSavedStateViewModelFactory.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/LegacySavedStateHandleController.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateViewModelFactory.kt
ap...@google.com <ap...@google.com> #73
Branch: androidx-main
commit 57c78eb1e3e7f3d87785a314fd5e27ea6068362f
Author: sanura <sanura@google.com>
Date: Thu Jan 12 18:52:06 2023
Rename LegacySavedStateHandleController.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: I23f8e17c69138e51ba64fd8717272f579a281c5b
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/LegacySavedStateHandleController.kt
ap...@google.com <ap...@google.com> #74
Branch: androidx-main
commit 2ed522e70c29a9d836214fdd7f266840e11b61f8
Author: sanura <sanura@google.com>
Date: Wed Jan 11 21:12:18 2023
Correct all Observer nullability
Since Observer was previous written in java,
nullability inconsistencies were overlooked.
Now that it is in kotlin, we need to ensure
that the class extension definition matches
the nullability in its onChanged method.
RelNote: "All `Observer<T>` subclasses have
consistent nullability with their onChanged
parameter's nullability."
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I599ec0cc153672b8203d4d83eb6e7a896d131524
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/CameraStateMachineTest.kt
M lifecycle/lifecycle-reactivestreams/src/main/java/androidx/lifecycle/LiveDataReactiveStreams.kt
M navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/ui/AbstractProgressFragment.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/LiveDataTestUtil.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/TestObserver.kt
ap...@google.com <ap...@google.com> #75
Branch: androidx-main
commit 8ad3bdce4a06498660b2b2bd2973af1b3ec099f9
Author: sanura <sanura@google.com>
Date: Wed Jan 11 20:27:16 2023
Change Observer's onChanged parameter name to value
Give Observer's onChanged() method parameter `t`
a more descriptive name of `value`.
RelNote: "`Observer` class's `onChanged()` method
now uses the name `value` for its parameter."
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I4995e88bac1a5dba16a8359f9361886aff013bb0
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/CameraStateMachineTest.kt
M camera/camera-extensions/src/androidTest/java/androidx/camera/extensions/internal/sessionprocessor/BasicExtenderSessionProcessorTest.kt
M lifecycle/lifecycle-livedata-core/api/current.txt
M lifecycle/lifecycle-livedata-core/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-livedata-core/api/restricted_current.txt
M lifecycle/lifecycle-livedata-core/src/main/java/androidx/lifecycle/Observer.kt
M lifecycle/lifecycle-livedata-core/src/test/java/androidx/lifecycle/LiveDataTest.java
M lifecycle/lifecycle-livedata-ktx/src/test/java/androidx/lifecycle/ScopesRule.kt
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/Transformations.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/TransformationsTest.java
M lifecycle/lifecycle-reactivestreams/src/main/java/androidx/lifecycle/LiveDataReactiveStreams.kt
M navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/ui/DefaultProgressFragmentTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/LiveDataTestUtil.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/TestObserver.kt
M work/work-inspection/src/main/java/androidx/work/inspection/WorkManagerInspector.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/utils/LiveDataUtilsTest.java
ap...@google.com <ap...@google.com> #76
Branch: androidx-main
commit fee12f73703eb830671afca539014dfcd7e4f128
Author: sanura <sanura@google.com>
Date: Wed Jan 11 20:22:18 2023
Convert Observer to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`Observer` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: Iffef21b829fdb1ce2685747c27b4ff4841c01613
M lifecycle/lifecycle-livedata-core/api/current.txt
M lifecycle/lifecycle-livedata-core/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-livedata-core/api/restricted_current.txt
M lifecycle/lifecycle-livedata-core/build.gradle
M lifecycle/lifecycle-livedata-core/src/main/java/androidx/lifecycle/Observer.kt
ap...@google.com <ap...@google.com> #77
Branch: androidx-main
commit 9b84b98a02017ae89f09837133f0c9bf6aa9f213
Author: sanura <sanura@google.com>
Date: Thu Dec 15 03:57:11 2022
Rename Observer.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: I52c3dbc4854b1ab91241c8c3cf16bf3081a6a8c7
M lifecycle/lifecycle-livedata-core/src/main/java/androidx/lifecycle/Observer.kt
ap...@google.com <ap...@google.com> #78
Branch: androidx-main
commit bf2170323284345911de804d38ecebc286b7bb19
Author: sanura <sanura@google.com>
Date: Wed Jan 18 19:51:21 2023
Deprecate original ViewTreeViewModelKt method
Deprecating the original ViewTreeViewModelKt
findViewTreeViewModelStoreOwner() method, now
that it is no longer an extension method.
RelNote: "The original
`ViewTreeViewModel.findViewTreeViewModelStoreOwner()`
method has been deprecated. The kotlin extension
version of this method as been moved to the
`ViewTreeViewModelStoreOwner` class."
Bug: 240298691
Test: ./gradlew checkApi
Change-Id: Ib22d8b129e70972429920bf7dd63632d80e68730
M lifecycle/lifecycle-viewmodel/api/current.txt
M lifecycle/lifecycle-viewmodel/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-viewmodel/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewTreeViewModel.kt
ap...@google.com <ap...@google.com> #79
Branch: androidx-main
commit 82abb7ed0792545abb32c5a3ae7a12051aed1556
Author: sanura <sanura@google.com>
Date: Thu Jan 12 01:44:01 2023
Update compose module to use ViewTreeViewModelStoreOwner extensions
The compose module should now be using the kotlin
extensions in the main lifecycle module to find and
set a ViewTreeViewModelStoreOwner.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I06999f250962125b10d8a86e35ee938ade9e5f91
M compose/material/material/build.gradle
M compose/material/material/src/androidMain/kotlin/androidx/compose/material/internal/ExposedDropdownMenuPopup.kt
M compose/material3/material3/build.gradle
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/internal/ExposedDropdownMenuPopup.kt
M compose/ui/ui-tooling/build.gradle
M compose/ui/ui-tooling/src/androidMain/kotlin/androidx/compose/ui/tooling/ComposeViewAdapter.kt
M compose/ui/ui/build.gradle
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidDialog.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidPopup.android.kt
ap...@google.com <ap...@google.com> #80
Branch: androidx-main
commit 618bdeb9a72c42780b823e6b0985e7fc6ecfadd9
Author: sanura <sanura@google.com>
Date: Thu Jan 12 01:33:44 2023
Update fragment module to use ViewTreeViewModelStoreOwner extensions
The fragment module should now be using the kotlin
extensions in the main lifecycle module to find and
set a ViewTreeViewModelStoreOwner.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I2ca96986e0cb7eb9db446977506288e98cd9465a
M fragment/fragment/build.gradle
M fragment/fragment/src/androidTest/java/androidx/fragment/app/DialogFragmentViewTreeTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentViewLifecycleTest.kt
ap...@google.com <ap...@google.com> #81
Branch: androidx-main
commit d052e7ed4d1907f5f5c71100577c5005bfe0607d
Author: sanura <sanura@google.com>
Date: Thu Jan 12 01:26:24 2023
Update activity module to use ViewTreeViewModelStoreOwner extensions
The activity module should now be using the kotlin
extensions in the main lifecycle module to find and
set a ViewTreeViewModelStoreOwner.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I92b1f676f2fafb4dc2141c20ba9d65a44336000e
M activity/activity-compose/build.gradle
M activity/activity-compose/src/main/java/androidx/activity/compose/ComponentActivity.kt
M activity/activity/build.gradle
M activity/activity/src/androidTest/java/androidx/activity/ContentViewTest.kt
ap...@google.com <ap...@google.com> #82
Branch: androidx-main
commit 747b98ed0e412948f3d69f6a4c1afb727f79c6be
Author: sanura <sanura@google.com>
Date: Thu Jan 12 01:19:37 2023
Update appcompat module to use ViewTreeViewModelStoreOwner extensions
The appcompat module should now be using the kotlin
extensions in the main lifecycle module to find and
set a ViewTreeViewModelStoreOwner.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I753a306e44cfd1757443dd88927d81dc895c66e8
M appcompat/appcompat/build.gradle
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/AppCompatActivityViewTreeTest.kt
ap...@google.com <ap...@google.com> #83
Branch: androidx-main
commit 83aa7d5762649337ad9e10ef6608129fc0dae146
Author: sanura <sanura@google.com>
Date: Thu Jan 12 01:13:51 2023
Update rest of lifecycle module with ViewTreeViewModelStoreOwner
All of the lifecyle modules should now be using the
updated apis for ViewTreeViewModelStoreOwner following
the kotlin conversion.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I68e98e86a2381847d8683f15cd95a1054d20de7a
M lifecycle/lifecycle-viewmodel-compose/src/main/java/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.kt
M lifecycle/lifecycle-viewmodel/src/androidTest/java/androidx/lifecycle/ViewTreeViewModelStoreOwnerTest.kt
ap...@google.com <ap...@google.com> #84
Branch: androidx-main
commit 2da5c315f7f6de9683569b844d2378d5b95d7240
Author: sanura <sanura@google.com>
Date: Thu Jan 12 03:18:41 2023
Convert ViewTreeViewModelStoreOwner to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`ViewTreeViewModelStoreOwner` is now in Kotlin.
This is a source-incompatible change and usages written in
Kotlin for `ViewTreeViewModelStoreOwner.set()` and
`ViewTreeViewModelStoreOwner.get()` should be replaced
with `View.setViewTreeViewModelStoreOwner()` and
`View.findViewTreeViewModelStoreOwner()`, respectively."
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: Ia06d830b263c0f7f1193c5b3ead1587533ca1b0c
M lifecycle/lifecycle-viewmodel/api/current.txt
M lifecycle/lifecycle-viewmodel/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-viewmodel/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewTreeViewModel.kt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewTreeViewModelStoreOwner.kt
ap...@google.com <ap...@google.com> #85
Branch: androidx-main
commit ca1700dfec3abbae23576b84c4d7305e2674544e
Author: sanura <sanura@google.com>
Date: Thu Jan 12 00:35:31 2023
Rename ViewTreeViewModelStoreOwner.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: Ic5868cd4f32d9be76a3e37112d9e471262317318
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewTreeViewModelStoreOwner.kt
ap...@google.com <ap...@google.com> #86
Branch: androidx-main
commit 8261fc0900a49346cda9b988da2905cec5f657d7
Author: sanura <sanura@google.com>
Date: Tue Jan 10 21:57:01 2023
Convert ReportFragment to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`ReportFragment` is now in Kotlin"
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I7443e0c886946abbd8072ddde0617dc4bc2dda5e
M lifecycle/lifecycle-process/src/main/java/androidx/lifecycle/ProcessLifecycleOwner.kt
M lifecycle/lifecycle-runtime/api/restricted_current.txt
M lifecycle/lifecycle-runtime/src/main/java/androidx/lifecycle/ReportFragment.kt
ap...@google.com <ap...@google.com> #87
Branch: androidx-main
commit d8a3d6e7ec8f3a51e91a3beded9edecfcdebfe50
Author: sanura <sanura@google.com>
Date: Tue Jan 10 21:35:09 2023
Rename ReportFragment.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: Ia1697c5d3a7142e13e5e45293445aeeb9959e4c1
M lifecycle/lifecycle-runtime/src/main/java/androidx/lifecycle/ReportFragment.kt
ap...@google.com <ap...@google.com> #88
Branch: androidx-main
commit 4d37923e2013cbbe4d810ddf6c1240a42a453959
Author: sanura <sanura@google.com>
Date: Wed Jan 18 22:40:06 2023
Remove constraint between lifecycle-viewmodel-savedstate and -compose
Since this constraint crosses subsets, we cannot guarantee
that lifecycle-viewmodel-savedstate will have access to
lifecycle-viewmodel-compose's tip-of-tree. If we do not
have this access, this constraint causes a build failure.
See
for more information about why this change was originally made
when converting LifecycleOwner to kotlin.
Ideally we will no longer need this constraint once this cl lands:
Bug: 240298691
Test: ./gradlew bOS
Change-Id: I677b205800e2268d2566931664565329ae8a736e
M lifecycle/lifecycle-viewmodel-savedstate/build.gradle
ap...@google.com <ap...@google.com> #89
Branch: androidx-main
commit 784f2c0154560048611f5f53f641c630d748c9c3
Author: sanura <sanura@google.com>
Date: Thu Jan 12 03:00:04 2023
Update camera module with ViewModelStoreOwner
The camera module should now be using the
updated apis for ViewModelStoreOwner following
the kotlin conversion.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I2fb409b09bca1740b5fbaa0b830dc82c716d6370
M camera/integration-tests/avsynctestapp/build.gradle
M camera/integration-tests/avsynctestapp/src/androidTest/java/androidx/camera/integration/avsync/SignalGeneratorViewModelTest.kt
M settings.gradle
ap...@google.com <ap...@google.com> #90
Branch: androidx-main
commit 7923fc80891896454b7d4fa9d134b37c295b3ddc
Author: sanura <sanura@google.com>
Date: Thu Jan 12 00:28:39 2023
Update fragment module with ViewModelStoreOwner
The fragment module should now be using the
updated apis for ViewModelStoreOwner following
the kotlin conversion.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I79a7ccbfad823a36a35bed857ed9d20709205790
M fragment/fragment/build.gradle
M fragment/fragment/src/androidTest/java/androidx/fragment/app/ControllerHostCallbacks.kt
ap...@google.com <ap...@google.com> #91
Branch: androidx-main
commit 6c2729b792b501bdcd755dc242ce781f4b9bc38a
Author: sanura <sanura@google.com>
Date: Thu Jan 12 00:18:04 2023
Update navigation module with ViewModelStoreOwner
The navigation module should now be using the
updated apis for ViewModelStoreOwner following
the kotlin conversion.
RelNote: "Navigation module now utilizes updated
Lifecycle APIs as a result of `ViewModelStoreOwner`
conversion to kotlin."
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I2420a63b2a8389f080883ed25b206869f9234f5f
M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/src/main/java/androidx/navigation/NavBackStackEntry.kt
ap...@google.com <ap...@google.com> #92
Branch: androidx-main
commit d8cb8912f58334a5ff703b194b905081e236686e
Author: sanura <sanura@google.com>
Date: Thu Jan 12 00:13:09 2023
Update compose module with ViewModelStoreOwner
The compose module should now be using the
updated apis for ViewModelStoreOwner following
the kotlin conversion.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: Iab752b2b2ad2c971a0006fec2c6987371c4015d6
M compose/ui/ui-tooling/src/androidMain/kotlin/androidx/compose/ui/tooling/ComposeViewAdapter.kt
ap...@google.com <ap...@google.com> #93
Branch: androidx-main
commit 1962c016de8f7efc71749f2e64083734b3ad2181
Author: sanura <sanura@google.com>
Date: Thu Jan 12 00:10:05 2023
Update other lifecycle modules with ViewModelStoreOwner
The all lifecyle modules should now be using the
updated apis for ViewModelStoreOwner following
the kotlin conversion.
RelNote: "All of lifecycle module now utilizes updated
Lifecycle APIs as a result of `ViewModelStoreOwner`
conversion to kotlin."
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I51c8c77a47aaa422bbeec94cb2d6227991007fe7
M lifecycle/lifecycle-viewmodel-compose/src/androidTest/java/androidx/lifecycle/viewmodel/compose/ViewModelTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidTest/java/androidx/lifecycle/viewmodel/savedstate/TestComponent.kt
M lifecycle/lifecycle-viewmodel/src/androidTest/java/androidx/lifecycle/ViewTreeViewModelStoreOwnerTest.kt
M lifecycle/lifecycle-viewmodel/src/test/java/androidx/lifecycle/ViewModelProviderTest.kt
ap...@google.com <ap...@google.com> #94
Branch: androidx-main
commit 2612165da942cea1537c0796be026ce3833991d1
Author: sanura <sanura@google.com>
Date: Wed Jan 11 23:59:20 2023
Convert ViewModelStoreOwner to Kotlin
Part of the kotlin conversion process for the Lifecycle library.
RelNote: "`ViewModelStoreOwner` is now in Kotlin.
This is a source incompatible change for classes written
in Kotlin - they must now override the `viewModelStore` property
rather than implementing the previous `getViewModelStore()` function."
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I864099e6aa61bc9cbc041181dafd6a7bce7d93b1
M lifecycle/lifecycle-viewmodel/api/current.txt
M lifecycle/lifecycle-viewmodel/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-viewmodel/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelStoreOwner.kt
ap...@google.com <ap...@google.com> #95
Branch: androidx-main
commit 7f19d7395a387ae6e56d65677f608b7cc38eaad8
Author: sanura <sanura@google.com>
Date: Wed Jan 11 23:58:37 2023
Rename ViewModelStoreOwner.java to .kt
Part of the kotlin conversion process for the Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: If2fdbd1bb1191878e5f0838109524462436bb8d9
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelStoreOwner.kt
ap...@google.com <ap...@google.com> #96
Branch: androidx-main
commit 7762db76e776caa11e75529b2e4197312acf3e70
Author: sanura <sanura@google.com>
Date: Tue Jan 10 19:48:15 2023
Update other lifecycle modules with LifecycleOwner
The all lifecyle modules should now be using the
updated apis for LifecycleOwner following
the kotlin conversion.
RelNote: "All of lifecycle module now utilizes updated
Lifecycle APIs as a result of `LifecycleOwner`
conversion to kotlin."
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: Icb16172782f87c1bfdb92f2b28b1cff0d51b2fef
M lifecycle/lifecycle-process/api/current.txt
M lifecycle/lifecycle-process/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-process/api/restricted_current.txt
M lifecycle/lifecycle-process/src/main/java/androidx/lifecycle/ProcessLifecycleOwner.kt
M lifecycle/lifecycle-service/api/current.txt
M lifecycle/lifecycle-service/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-service/api/restricted_current.txt
M lifecycle/lifecycle-service/src/main/java/androidx/lifecycle/LifecycleService.kt
ap...@google.com <ap...@google.com> #97
Branch: androidx-main
commit 20dce35e086cb9f529aa676b063b81f454a708b9
Author: sanura <sanura@google.com>
Date: Fri Dec 02 04:39:27 2022
Update navigation module with LifecycleRegistry
The navigation module should now be using the
updated apis for LifecycleRegistry following
the kotlin conversion.
RelNote: "Navigation module now utilizes updated
Lifecycle APIs as a result of `LifecycleRegistry`
conversion to kotlin."
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: Ibcc926c0d8f2e227412ea36c2a7c8948cc304925
M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/build.gradle
M navigation/navigation-common/src/main/java/androidx/navigation/NavBackStackEntry.kt
M navigation/navigation-compose/build.gradle
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
ap...@google.com <ap...@google.com> #98
Branch: androidx-main
commit 602bac6c67b589d11f8f4d1441a4aec4dca0ee49
Author: sanura <sanura@google.com>
Date: Fri Dec 02 04:39:02 2022
Update activity module with LifecycleRegistry
The activity module should now be using the
updated apis for LifecycleRegistry following
the kotlin conversion.
RelNote: "Activity module now utilizes updated
Lifecycle APIs as a result of `LifecycleRegistry`
conversion to kotlin."
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I2d9e6961a5fa1aa9a8548c3ffbcd74bae28de084
M activity/activity-compose/src/androidTest/java/androidx/activity/compose/BackHandlerTest.kt
M activity/activity-compose/src/androidTest/java/androidx/activity/compose/BackPressedDispatcherOwnerTest.kt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/ComponentActivityOverrideLifecycleTest.kt
M activity/activity/src/androidTest/java/androidx/activity/ViewTreeOnBackPressedDispatcherTest.kt
M activity/activity/src/main/java/androidx/activity/ComponentDialog.kt
M compose/ui/ui/build.gradle
ap...@google.com <ap...@google.com> #99
Branch: androidx-main
commit 47051b7f32a7832c69079d5ff41269151232e35d
Author: sanura <sanura@google.com>
Date: Wed Dec 07 00:52:50 2022
Update work module with LifecycleRegistry
The work module should now be using the
updated apis for LifecycleRegistry following
the kotlin conversion.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I321ecaf42f19f49f0631534ad35788ebd3f2f611
M work/work-inspection/build.gradle
M work/work-inspection/src/main/java/androidx/work/inspection/WorkManagerInspector.kt
ap...@google.com <ap...@google.com> #100
Branch: androidx-main
commit 0644fe6b2307c5c5a73948e1648d6eea0ed97521
Author: sanura <sanura@google.com>
Date: Fri Dec 02 04:42:22 2022
Update wear module with LifecycleRegistry
The wear module should now be using the
updated apis for LifecycleRegistry following
the kotlin conversion.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I50b3d815e73e651328c93a81a25bc26d52081a10
M wear/compose/compose-navigation/build.gradle
M wear/compose/compose-navigation/src/androidTest/kotlin/androidx/wear/compose/navigation/SwipeDismissableNavHostTest.kt
ap...@google.com <ap...@google.com> #101
Branch: androidx-main
commit bb7401dabf6bb2e005cd44f592c8c418cf92139d
Author: sanura <sanura@google.com>
Date: Fri Dec 02 04:41:51 2022
Update glance module with LifecycleRegistry
The glance module should now be using the
updated apis for LifecycleRegistry following
the kotlin conversion.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: If9265bd8eb2ac697040adf16a0dc0817da1660d4
M glance/glance-wear-tiles/build.gradle
M glance/glance-wear-tiles/src/androidMain/kotlin/androidx/glance/wear/tiles/GlanceTileService.kt
M settings.gradle
ap...@google.com <ap...@google.com> #102
Branch: androidx-main
commit 6a0d87695ec71d83b127a172bf83bbc7c211cbbc
Author: sanura <sanura@google.com>
Date: Fri Dec 02 04:41:05 2022
Update paparazzi module with LifecycleRegistry
The paparazzi module should now be using the
updated apis for LifecycleRegistry following
the kotlin conversion.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I82ef778ee4e203fa128ac37b4536fff7169df2d8
M external/paparazzi/paparazzi/build.gradle
M external/paparazzi/paparazzi/src/main/java/app/cash/paparazzi/Paparazzi.kt
ap...@google.com <ap...@google.com> #103
Branch: androidx-main
commit 9d58e7bf291474b0b4c44ecd6fb7f5674c74d185
Author: sanura <sanura@google.com>
Date: Fri Dec 02 04:40:37 2022
Update fragment module with LifecycleRegistry
The fragment module should now be using the
updated apis for LifecycleRegistry following
the kotlin conversion.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: Ie8b589a2eeb86dfcd124f64da51b75853841ae6a
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentArchLifecycleTest.kt
ap...@google.com <ap...@google.com> #104
Branch: androidx-main
commit 7aad4b57d765ef1fe84557fca6f0dc6fff912a84
Author: sanura <sanura@google.com>
Date: Fri Dec 02 04:40:05 2022
Update savedstate module with LifecycleRegistry
The savedstate module should now be using the
updated apis for LifecycleRegistry following
the kotlin conversion.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: Ic95497a27dd2d0f1d31ef91cef86c6e8b070c1c1
M savedstate/savedstate/build.gradle
M savedstate/savedstate/src/androidTest/java/androidx/savedstate/SavedStateRegistryTest.kt
M savedstate/savedstate/src/androidTest/java/androidx/savedstate/ViewTreeSavedStateRegistryOwnerTest.kt
ap...@google.com <ap...@google.com> #105
Branch: androidx-main
commit e81525bbcf88d73ce88e324ab9fb93e5bc4653be
Author: sanura <sanura@google.com>
Date: Fri Dec 02 04:34:54 2022
Update compose module with LifecycleRegistry
The compose module should now be using the
updated apis for LifecycleRegistry following
the kotlin conversion.
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: Ia488c96e00888c9a36603722208436f270389a72
M compose/runtime/runtime-livedata/build.gradle
M compose/ui/ui-tooling/build.gradle
M compose/ui/ui-tooling/src/androidMain/kotlin/androidx/compose/ui/tooling/ComposeViewAdapter.kt
M compose/ui/ui/build.gradle
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/platform/DisposableSaveableStateRegistryTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/platform/WindowRecomposerTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/viewinterop/AndroidViewTest.kt
ap...@google.com <ap...@google.com> #106
Branch: androidx-main
commit 221fa037f92c186a658a34c2493f5f0a071fd61e
Author: sanura <sanura@google.com>
Date: Wed Dec 07 00:11:25 2022
Convert LifecycleOwner to Kotlin
Part of the kotlinification process of Lifecycle library.
RelNote: "`LifecycleOwner` is now written in Kotlin.
This is a source incompatible change for classes written
in Kotlin - they must now override the `lifecycle` property
rather than implementing the previous `getLifecycle()` function."
Test: ./gradlew checkApi
Bug: 240298691
Change-Id: I75b4b3ffc999f3f00c6ca57e027dff5e18f54146
M lifecycle/lifecycle-common/api/current.txt
M lifecycle/lifecycle-common/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-common/api/restricted_current.txt
M lifecycle/lifecycle-common/src/main/java/androidx/lifecycle/LifecycleOwner.kt
M lifecycle/lifecycle-runtime-ktx/src/androidTest/java/androidx/lifecycle/FakeLifecycleOwner.kt
A lifecycle/lifecycle-runtime-ktx/src/androidTest/java/androidx/lifecycle/ViewTreeLifecycleOwnerTest.kt
M lifecycle/lifecycle-runtime-testing/api/current.txt
M lifecycle/lifecycle-runtime-testing/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-runtime-testing/api/restricted_current.txt
M lifecycle/lifecycle-runtime-testing/src/main/java/androidx/lifecycle/testing/TestLifecycleOwner.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidTest/java/androidx/lifecycle/viewmodel/savedstate/TestComponent.kt
ap...@google.com <ap...@google.com> #107
Branch: androidx-main
commit 60baa5e0f4378a9ce00669d39f9102c32fb8d3a4
Author: sanura <sanura@google.com>
Date: Fri Nov 04 22:30:56 2022
Rename LifecycleOwner.java to .kt
Part of the kotlinification process of Lifecycle library
Test: ./gradlew bOS
Bug: 240298691
Change-Id: Ibefd9341ada4db4f530032736563b795044aacc9
M lifecycle/lifecycle-common/src/main/java/androidx/lifecycle/LifecycleOwner.kt
ap...@google.com <ap...@google.com> #108
Branch: androidx-main
commit dc62e629fcc32e18ce943a67778681126c6c17f9
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Jan 31 13:55:37 2023
Move Lifecycle kotlin extensions back to lifecycle-common
Since the Lifecycle class is now in Kotlin, we have conflicts between
Lifecycle.kt files.
This change moves the Lifecycle.kt in lifecycle-runtime-ktx along with
all of its dependencies, back into lifecycle-common.
RelNote: "The lifecycle coroutineScope field has been moved to the
lifecycle-common artifact."
Test: all existing lifecycle-runtime-ktx tests pass
Bug: 240298691
Change-Id: Iabb911950a0646052eed89f5ce2751b156268aae
M lifecycle/lifecycle-common/api/current.txt
M lifecycle/lifecycle-common/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-common/api/restricted_current.txt
M lifecycle/lifecycle-common/build.gradle
M lifecycle/lifecycle-common/src/main/java/androidx/lifecycle/DispatchQueue.kt
M lifecycle/lifecycle-common/src/main/java/androidx/lifecycle/Lifecycle.kt
M lifecycle/lifecycle-common/src/main/java/androidx/lifecycle/LifecycleController.kt
M lifecycle/lifecycle-common/src/main/java/androidx/lifecycle/PausingDispatcher.kt
A lifecycle/lifecycle-runtime-ktx/api/current.ignore
M lifecycle/lifecycle-runtime-ktx/api/current.txt
M lifecycle/lifecycle-runtime-ktx/api/public_plus_experimental_current.txt
A lifecycle/lifecycle-runtime-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-runtime-ktx/api/restricted_current.txt
D lifecycle/lifecycle-runtime-ktx/src/main/java/androidx/lifecycle/Lifecycle.kt
ap...@google.com <ap...@google.com> #109
Branch: androidx-main
commit 96e6ac11b3906a7bfe1a5e68ee38751dd2c0fc2f
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Jan 31 14:24:42 2023
Move LifecycleOwner ktx extensions back to common
Since the LifecycleOwner class is now in Kotlin, we have docs conflicts
between LifecycleOwner.kt files.
This change moves the LifecycleOwner extensions into the LifecycleOwner
class in lifecycle-common.
RelNote: "The lifecycleScope field has been moved to the
lifecycle-common artifact."
Test: all existing lifecycle-runtime-ktx tests pass
Bug: 240298691
Change-Id: I41d786b9db40eae569b1eb9cedd559bb87178fdc
M lifecycle/lifecycle-common/api/current.txt
M lifecycle/lifecycle-common/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-common/api/restricted_current.txt
M lifecycle/lifecycle-common/src/main/java/androidx/lifecycle/LifecycleOwner.kt
M lifecycle/lifecycle-runtime-ktx/api/current.ignore
M lifecycle/lifecycle-runtime-ktx/api/current.txt
M lifecycle/lifecycle-runtime-ktx/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-runtime-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-runtime-ktx/api/restricted_current.txt
D lifecycle/lifecycle-runtime-ktx/src/main/java/androidx/lifecycle/LifecycleOwner.kt
sa...@google.com <sa...@google.com> #110
This bug has been fixed and will be available in androidx-lifecycle-2.6.0-beta01.
ViewModel
's conversion to kotlin has been moved to a future release because we need to make some imperative API changes before doing that conversion.
me...@choco.com <me...@choco.com> #111
il...@google.com <il...@google.com> #112
Re onChanged
absolutely supports nullable values for values of T
that are nullable types.
na...@google.com <na...@google.com> #113
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.camera:camera-camera2:1.3.0-alpha04
androidx.camera:camera-extensions:1.3.0-alpha04
pr...@google.com <pr...@google.com> #114
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.savedstate:savedstate:1.2.1
lm...@gmail.com <lm...@gmail.com> #115
lm...@gmail.com <lm...@gmail.com> #116
pr...@google.com <pr...@google.com> #117
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.work:work-runtime:2.9.0-alpha01
Description
With the 2.4 release, the Lifecycle library took on the Kotlin dependency allowing for modules to be written directly in Kotlin and eliminating the need for the -ktx libraries. Now that we have that dependency we should start converting the rest of the library over to Kotlin as well.
Most of the Lifecycle library is straightforward and will be easily converted with the exception of the lifecycle-livedata-* modules as they have some nullability complexities that need some help on the kotlin side. (might be addressed oncehttps://youtrack.jetbrains.com/issue/KT-14663 is resolved)