Menu navigation to dialog changes bottom nav selection [240308330]

Fixed

Bug

Status Update

No update yet.

Description

ba...@gmail.com

created issue #1

Jul 27, 2022 03:40PM

Component used: Navigation Version used: 2.5.0 Devices/Android versions reproduced on: emulator api 30

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue. https://github.com/RSBat/menu-navigation-dialog
A screenrecord or screenshots showing the issue (if UI related).

Navigating with menu item tied to a dialog destination causes bottom navigation selection to change.

Navigating with a global action keeps selection unchanged - see branch globalAction in the same repo. Same when opening dialog with .show().

nav_bug.webm

4.7 MB

Download

Comments

jb...@google.com <jb...@google.com> #2Jul 27, 2022 08:15PM

Hmm

I can repro on API 33 but not on API 34

jb...@google.com <jb...@google.com> Aug 30, 2022 05:02PM

Assigned to cl...@google.com.

ap...@google.com <ap...@google.com> #3Sep 1, 2022 11:26PM

Can't repro with API 24 as well.

jb...@google.com <jb...@google.com> #4Sep 6, 2022 06:41PM

Can't repro with 21 or 32. Looks like issue is specific to API 33.

cl...@google.com <cl...@google.com> Sep 6, 2022 06:52PM

Marked as fixed.

na...@google.com <na...@google.com> #5Oct 5, 2022 05:14PM

And seems to have nothing to do with ByteBuffer.

fun testCpu() {
    val random = Random(Date().time)
    val nanoTime = measureNanoTime {
        repeat(100_000) {
            sin(random.nextDouble())
        }
    }
    Log.d("SinTest", "100_000 * sin() loop took ${TimeUnit.NANOSECONDS.toMillis(nanoTime)}ms")
}

Results in:

2023-08-02 11:32:07.506  9391-9391  SinTest                 com.alonalbert.myapplication         D  100_000 * sin() loop took 9ms
2023-08-02 11:32:08.417  9391-9391  SinTest                 com.alonalbert.myapplication         D  100_000 * sin() loop took 2ms
2023-08-02 11:32:09.296  9391-9391  SinTest                 com.alonalbert.myapplication         D  100_000 * sin() loop took 1ms
2023-08-02 11:32:09.992  9391-9391  SinTest                 com.alonalbert.myapplication         D  100_000 * sin() loop took 1ms
2023-08-02 11:32:10.720  9391-9391  SinTest                 com.alonalbert.myapplication         D  100_000 * sin() loop took 1ms
---------------------------- PROCESS ENDED (9391) for package com.alonalbert.myapplication ----------------------------
---------------------------- PROCESS STARTED (9463) for package com.alonalbert.myapplication ----------------------------
2023-08-02 11:32:27.663  9463-9463  SinTest                 com.alonalbert.myapplication         D  100_000 * sin() loop took 78ms
2023-08-02 11:32:28.537  9463-9463  SinTest                 com.alonalbert.myapplication         D  100_000 * sin() loop took 105ms
2023-08-02 11:32:29.262  9463-9463  SinTest                 com.alonalbert.myapplication         D  100_000 * sin() loop took 103ms
2023-08-02 11:32:29.887  9463-9463  SinTest                 com.alonalbert.myapplication         D  100_000 * sin() loop took 104ms
2023-08-02 11:32:30.663  9463-9463  SinTest                 com.alonalbert.myapplication         D  100_000 * sin() loop took 104ms

Issue 240308330