Fixed
Status Update
No update yet.
Comments
jb...@google.com
Yigit, do you have time to fix it?
reemission of the same liveData is racy
reemission of the same liveData is racy
jb...@google.com
ap...@google.com
yea i'll take it.
jb...@google.com
Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.
cl...@google.com
na...@google.com
just emitting same live data reproduces the issue.
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
Description
Component used: Navigation Version used: 2.5.0 Devices/Android versions reproduced on: emulator api 30
If this is a bug in the library, we would appreciate if you could attach:
Navigating with menu item tied to a dialog destination causes bottom navigation selection to change.
Navigating with a global action keeps selection unchanged - see branch globalAction in the same repo. Same when opening dialog with
.show().