Menu navigation to dialog changes bottom nav selection [240308330]

Fixed

Bug

Status Update

No update yet.

Description

ba...@gmail.com

created issue #1

Jul 27, 2022 03:40PM

Component used: Navigation Version used: 2.5.0 Devices/Android versions reproduced on: emulator api 30

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue. https://github.com/RSBat/menu-navigation-dialog
A screenrecord or screenshots showing the issue (if UI related).

Navigating with menu item tied to a dialog destination causes bottom navigation selection to change.

Navigating with a global action keeps selection unchanged - see branch globalAction in the same repo. Same when opening dialog with .show().

nav_bug.webm

4.7 MB

Download

Comments

jb...@google.com <jb...@google.com> #2Jul 27, 2022 08:15PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

jb...@google.com <jb...@google.com> Aug 30, 2022 05:02PM

Assigned to cl...@google.com.

ap...@google.com <ap...@google.com> #3Sep 1, 2022 11:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

jb...@google.com <jb...@google.com> #4Sep 6, 2022 06:41PM

deleted

cl...@google.com <cl...@google.com> Sep 6, 2022 06:52PM

Marked as fixed.

na...@google.com <na...@google.com> #5Oct 5, 2022 05:14PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

Issue 240308330