Type $class is defined multiple times [240438146]

WAI

Bug

Status Update

No update yet.

Description

mg...@snapchat.com

created issue #1

Jul 27, 2022 06:16PM

Im getting the following error when running D8 through D8Command for merging several dex files. Im using a release version of R8 version 3.3.28. However if I build lR8 ocally at the same commit and use that instead of the release version I'm able to build successfully. Is there any option in the development build that different from the release build that would explain this behavior?

Error in bazel-out/android-arm64-v8a-fastbuild/bin/kotlin/platform/annotations/_dx/api/api.jar.dex.zip:com/snap/tracing/annotation/TraceMethod.class.dex:
Type com.snap.tracing.annotation.TraceMethod is defined multiple times: bazel-out/android-arm64-v8a-fastbuild/bin/kotlin/platform/annotations/_dx/api/api.jar.dex.zip:com/snap/tracing/annotation/TraceMethod.class.dex, bazel-out/android-arm64-v8a-fastbuild/bin/kotlin/platform/annotations/_dx/tracing/tracing.jar.dex.zip:com/snap/tracing/annotation/TraceMethod.class.dex
Merge failed: Compilation failed to complete, origin: bazel-out/android-arm64-v8a-fastbuild/bin/kotlin/platform/annotations/_dx/api/api.jar.dex.zip:com/snap/tracing/annotation/TraceMethod.class.dex
Exception in thread "main" com.android.tools.r8.CompilationFailedException: Merge failed: Compilation failed to complete, origin: bazel-out/android-arm64-v8a-fastbuild/bin/kotlin/platform/annotations/_dx/api/api.jar.dex.zip:com/snap/tracing/annotation/TraceMethod.class.dex

Note that this class does appear in multiple dex files.

Comments

ri...@google.com <ri...@google.com> #2Jul 28, 2022 05:26AM

Automated by Blunderbuss job edu-devrel-blunderbuss-autoassigner for component 191645.

cl...@google.com <cl...@google.com> Jul 28, 2022 06:43AM

Reassigned to ri...@google.com.

mg...@snapchat.com <mg...@snapchat.com> #3Jul 29, 2022 05:48PM

Upon some more investigation, I've noticed that Excusing a submission via the UI simply removes it from calculation of overall grade within the UI. However, the actual score of the submission does not change -- in my original case reported above, the original score I gave to the submission was 0, and then I marked it as Excused.

In my opinion, at least one of the two should change with regards to the behavior of Excusing an assignment:

1. Any original score returned to the student should be erased from the submission entirely. This should make the returned grade empty/null, so the API response does not need any special indicator for an excused grade.
2. If a returned grade should still be associated with a submission (but not count towards the overall grade like the Google Classroom UI calculates), then this same flag/indicator should be exposed via the API so that a similar overall grade calculation can be performed from the API response.

r8-3.3.28-mau.jar

36 MB

Download

ri...@google.com <ri...@google.com> #4Aug 1, 2022 11:02AM

Reassigned to ze...@google.com.

Thanks for providing feedback around supporting excused assignments in the Classroom API! I've made a note of your comments and transferred them internally. Any updates about this will be communicated here.

ze...@google.com <ze...@google.com> #5Aug 1, 2022 12:25PM

We are an SIS that consumes Classroom data via the API.

What we are observing:

we don't get StudentSubmissions where student was never scored and was excused, so parents are confused thinking that work is not done when it should be excused when looking in our platform.
When a student is scored, grades are synced, then excused, we don't get the update that the assignment was excused. So now the student has a score (0 or otherwise) that doesn't reflect what's in Google Classroom, creating discrepancies between Classroom assignment grades and SIS assignment grades.

mg...@snapchat.com <mg...@snapchat.com> #6Aug 1, 2022 07:24PM

Thanks for providing supporting feedback. I'd love to learn a bit more about your comment:

"we don't get StudentSubmissions where student was never scored and was excused, so parents are confused thinking that work is not done when it should be excused when looking in our platform."

Can you provide more information on the API call you are making here so I can try to figure out the issue? I'm not able to reproduce this at the moment; when reading student submissions by calling ListStudentSubmissions, I'm able to retrieve submissions that are marked as excused in the UI.

"When a student is scored, grades are synced, then excused, we don't get the update that the assignment was excused. So now the student has a score (0 or otherwise) that doesn't reflect what's in Google Classroom, creating discrepancies between Classroom assignment grades and SIS assignment grades."

Trying to understand this issue a bit further - if I understand correctly, there may be grade discrepancies between Classroom and SIS in the event that a teacher modifies a grade after the grades have been synced with the SIS. Do you have a mechanism today by which you monitor these types of grade changes? If not, is being alerted about excused assignments more important than other types of submission changes?

Message last modified on Aug 1, 2022 10:02PM

ze...@google.com <ze...@google.com> #7Aug 2, 2022 07:52AM

Status: Won't Fix (Intended Behavior)

Thank you for adding the option to mark an assignment excused. What I have noticed, however, is that the Classroom API does not support a means of detecting Excused assignments.

We use a platform (Schoolytics) that mines the data from Classroom via the API to give parents and students updates and reports about their students' progress. Unfortunately, excused assignments (e.g. because the student was not yet enrolled at our school) are being misidentified as missing.

We use Aeries as our SIS and gradebooks.

mg...@snapchat.com <mg...@snapchat.com> #8Aug 2, 2022 06:17PM

If anyone is looking for a way of detecting if the assignment was excused for a student, I noticed that {} gets added to `submissionHistory` array of the respective `StudentSubmission` object when the assignment is excused. Same when it is "unexcused". So my current workaround is to count number of {} in the `submissionHistory` array, and if such number is odd, assignment is excused, if even, it is not.

However, I am not sure if there is some other situation when {} gets added to the `submissionHistory` as well and thus breaking this workaround. I did not encounter any other situation when this happens.

UPDATE: As noticed by 34...@gmail.com, marking solution as complete by the teacher also adds empty object which breaks this solution unfortunately.

sg...@google.com <sg...@google.com> #9Aug 4, 2022 09:32AM

^ I tried this but it seems the "Mark as complete" action also adds an empty object to submissionHistory, which may break your logic.