Fixed
Status Update
No update yet.
Comments
jn...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 7c59b61572a43f8abadc6f978469f8aba3476a23
Author: John Nichol <jnichol@google.com>
Date: Thu Jul 28 14:51:54 2022
Correct the size of the toggle control area in the ToggleChip
Correct the size of the toggle control area of the ToggleChip to match the UX spec. UX Spec calls for a 4.dp spacer and a 24x24.dp toggle control icon area giving 28.dp width. However the implementation is incorrectly giving 36x24.dp toggle control area. This results in taking away 8.dp of usable text label area.
Bug: 240548670
Test: ./gradlew :wear:compose:compose-material:connectedCheck --info --daemon
RelNote: "We have corrected the size of the toggle control area of the ToggleChip as it was not matching its UX spec. The UX Spec calls for a 4.dp spacer between the label and a 24x24.dp toggle control icon area giving a total 28.dp width. However the implementation is incorrectly giving 36x24.dp toggle control area. This results in taking away 8.dp of usable text label area. NOTE: This bug fix gives additional space for the text label and as result can (positively) impact the text layout for overflowing text. It is possible that if you have screenshot tests they may need to be regenerated."
Change-Id: I514c858bd97dfedf860ac818dc27530a4a9e1a81
M wear/compose/compose-material/src/commonMain/kotlin/androidx/wear/compose/material/ToggleChip.kt
https://android-review.googlesource.com/2168442
Branch: androidx-main
commit 7c59b61572a43f8abadc6f978469f8aba3476a23
Author: John Nichol <jnichol@google.com>
Date: Thu Jul 28 14:51:54 2022
Correct the size of the toggle control area in the ToggleChip
Correct the size of the toggle control area of the ToggleChip to match the UX spec. UX Spec calls for a 4.dp spacer and a 24x24.dp toggle control icon area giving 28.dp width. However the implementation is incorrectly giving 36x24.dp toggle control area. This results in taking away 8.dp of usable text label area.
Bug: 240548670
Test: ./gradlew :wear:compose:compose-material:connectedCheck --info --daemon
RelNote: "We have corrected the size of the toggle control area of the ToggleChip as it was not matching its UX spec. The UX Spec calls for a 4.dp spacer between the label and a 24x24.dp toggle control icon area giving a total 28.dp width. However the implementation is incorrectly giving 36x24.dp toggle control area. This results in taking away 8.dp of usable text label area. NOTE: This bug fix gives additional space for the text label and as result can (positively) impact the text layout for overflowing text. It is possible that if you have screenshot tests they may need to be regenerated."
Change-Id: I514c858bd97dfedf860ac818dc27530a4a9e1a81
M wear/compose/compose-material/src/commonMain/kotlin/androidx/wear/compose/material/ToggleChip.kt
Description
Component used: ToggleChip Version used: 1.0.0
There is a bug in the layout of ToggleChip - the toggle control is supposed to be 24x24,dp with a 4.dp spacer between the toggle control and the text - but currently the toggle control box is 36.dp wide with no spacer.
As a result the size of the space left for the label is 8.dp narrower than it is designed to be