IssueTracker

Are there any updates on this issue?

Our app relies on a lot of interop with ComposeView, and this leak has been causing issues and slowing down our integration with Compose.

Any help is much appreciated!

Do we know if this is fixed in Compose 1.3.0 or 1.3.1 ? Has anyone (or OP) tried repro-ing with those versions yet?

Thanks

FWIW, just tried to repro the leaks with Compose + Compose Compiler 1.3.1 and the leaks seem to have stopped.

Would love confirmation about this being fixed in 1.3.1 just to be sure.

I'm use the latest BOM and the leak still happen. I believe the BOM uses Compose Compiler 1.3.1.

I'm not sure lambda functions are the cause here.
At least lambdas we have control over as library users.

The first post has a code example that reproduces the memory leak but there are zero lambdas in use:

class MainActivity : AppCompatActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContentView(ComposeView(this))
    }
}

So this essentially means that every app out there, which is in any of its activities using ComposeView(s) will leak those activities. Seems like a P1 to me.

Could be related to https://issuetracker.google.com/issues/264389670

There is a small demo project simulating any number of leaks (using fragment and further activities). This is a major issue, which blocking us from releasing many features using compose. They have reproducibility 100%, and have potentially huge impact on memory and performance. Could you please bump this issues to P1?

From issue 264389670 on 14/02/2023:

Please note that ComposeView is not the prerequisite for this leak, but the changing of the mutable state during hiding of composition in first activity. Although, the root cause could be the same, but this issue doesn't assume any root cause, but provides the setup for replication. Fragment is also not required. I will attach new setup, which does use only just 3 activities. And that's enough for memory leak.

Replication

• From MainActivity go to IntermediateActivity
• From IntermediateActivity go to ComposeActivity
• From ComposeActivity go back
• Checking profiler. Have memory leak

The memory leak is caused by an edge case, when the activity is stopped while Recomposer is holding some pending state for composition. By default, MonotonicClock used in Recomposer is paused on activity stop, causing it to suspend frame iteration. It works well in most cases, as state objects in other activities are not relevant for the composition in the stopped one. In this edge case, however, the same state is used in some activities or Recomposer has already queued an update before activity was stopped, and it continues to accumulate states from other activities until the first activity is restarted or destroyed. The issue is quite deeply rooted, as the fix is likely to change how compositions record states in background, so we are targeting next release for the fix.

If you are affected by this issue in the meantime, consider specifying a custom WindowRecomposerFactory in your app that doesn't pause MonotonicClock (or unpauses it periodically). The side effect of such custom Recomposer is that compositions will continue running animations when activity is in background.

This is in android-main which is now the 1.5 branch. It should be out with the next alpha of 1.5 but not stable until 1.5 is stable.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.compose.runtime:runtime:1.5.0-alpha03
• androidx.compose.ui:ui:1.5.0-alpha03

How does version 1.4.x handle this bug?

Lambdas like ComposableSingletons$Maintiner1Activitykt$lambda-1$1, as the name implies, are lazy allocated singleton instances that are stored globally. They will only be allocated once. This is not addressed by the above fix because it is not a leak but a singlton.