New "unknown enum constant" from javac on AGP 7.4.0-alpha09 [241287611]

Fixed

Bug

Status Update

No update yet.

Description

pi...@gmail.com

created issue #1

Aug 4, 2022 03:18AM

DESCRIBE THE ISSUE IN DETAIL:

I maintain a Gradle plugin that, among other things, depends on:

com.android.tools.build:android-gradle-plugin
com.android.tools:r8
com.android.tools:repository

On AGP 7.4.0-alpha08, my project builds without warnings or errors. When I update it to alpha09, I see the following build failure (due to enabling warnings-as-errors):

> Task :compileJava FAILED
warning: unknown enum constant TaskCategoryLabel.AAR_PACKAGING
  reason: class file for com.android.ide.common.attribution.TaskCategoryLabel not found
error: warnings found and -Werror specified
1 error
1 warning

This enum comes from sdk-commons. I don't explicitly depend on this, and interestingly, none of my code seems to reference it, either. Adding a compileOnly dependency on sdk-commons resolves the error; it appears to me as if AGP transitively depends on sdk-commons, and between alpha08 and alpha09 something in that transitive chain changed from an api dependency to an implementation dependency.

STEPS TO REPRODUCE:

git clone https://github.com/keepsafe/dexcount-gradle-plugin
git checkout agp-7.4.0-alpha09
Comment out line 90 of build.gradle
./gradlew compileJava

ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: N/A Version of Gradle Plugin: 7.4.0-alpha09 Version of Gradle: 7.5 Version of Java: 11.0.15 (Azul Systems, Inc. 11.0.15+10-LTS) OS: Mac OS X 12.4 aarch64

Comments

pi...@gmail.com <pi...@gmail.com> #2Aug 4, 2022 03:22AM

Thank you for the report and the supplied dump with the reproduction. I can confirm that the NPE is also present on HEAD, and I will look into it.

Quite a few of the class files in the dump has malformed inner-class attribute, where R8 reports e.g.:

Info in /tmp/tmpo67ucguh/program.jar:ofifmwrrhhmodsc/ψξψξψξξ.class:
Malformed inner-class attribute:
	outerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ
	innerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ$ψξξψξξξ
	innerName: ψξψξψξξ$ψξξψξξξ

These are ignored, so they should not be the reason for the NPE, but something to also look into.

xa...@google.com <xa...@google.com> #3Aug 4, 2022 03:46PM

Assigned to cm...@google.com.

Project: r8
Branch: main

commit e59500ca4445f5fb5d2ccc1114acbf66df11d196
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:55 2023

Insert patched frame instructions in the right place

Fixes:

b/274337639

Change-Id: Iae204ed529f9af5bf5fa3eaacba45128dfa6fd9e

M src/main/java/com/android/tools/r8/graph/LazyCfCode.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77390

cm...@google.com <cm...@google.com> #4Aug 4, 2022 04:14PM

Project: r8
Branch: main

commit 780c2e83c8c033e7594d61894fa1b3dbcad6630b
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:13 2023

Add reproduction of

b/274337639

Bug:

b/274337639

Change-Id: I7573883d6a649eed47b10d7bf0cdea2e11710268

M build.gradle
M src/main/java/com/android/tools/r8/cf/code/frame/UninitializedNew.java
A src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77389

cm...@google.com <cm...@google.com> #5Aug 4, 2022 04:15PM

I will backport this to the 8.0 and 4.0 branches.

am...@google.com <am...@google.com> #6Aug 4, 2022 04:39PM

Reassigned to an...@google.com.

Thank you very much for taking a look at this!

Is this fix related to the nullpointer or the malformed inner-class attributes ?

Do you have a separated ticket for it? Could you share it?

uc...@google.com <uc...@google.com> Aug 8, 2022 07:55AM

Reassigned to an...@google.com.

ga...@google.com <ga...@google.com> Aug 8, 2022 08:06AM

Reassigned to an...@google.com.

an...@google.com <an...@google.com> Aug 23, 2022 11:05AM

Accepted by an...@google.com.

an...@google.com <an...@google.com> Aug 24, 2022 12:54PM

Marked as fixed.

pi...@gmail.com <pi...@gmail.com> #7Aug 26, 2022 04:32PM

Project: r8
Branch: 4.0

commit 6edb00fb23e41b28d4794cfa69d706d5c5aa3fba
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:55:01 2023

Version 4.0.56

Bug:

b/274337639

Change-Id: I88a20fc922ce892d38fa3a34f9a3f1f4714354ae

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77447

sa...@google.com <sa...@google.com> #8Nov 3, 2022 01:42PM

Project: r8
Branch: 4.0

commit d9215af3b02f64d1207b9ebd63a6925229307b9d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:50 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

https://r8-review.googlesource.com/77446

Issue 241287611

Description

Issue summary

Comments

pi...@gmail.com <pi...@gmail.com> #2Aug 4, 2022 03:22AM

xa...@google.com <xa...@google.com> #3Aug 4, 2022 03:46PM

cm...@google.com <cm...@google.com> #4Aug 4, 2022 04:14PM

cm...@google.com <cm...@google.com> #5Aug 4, 2022 04:15PM

am...@google.com <am...@google.com> #6Aug 4, 2022 04:39PM

uc...@google.com <uc...@google.com> Aug 8, 2022 07:55AM

ga...@google.com <ga...@google.com> Aug 8, 2022 08:06AM

an...@google.com <an...@google.com> Aug 23, 2022 11:05AM

an...@google.com <an...@google.com> Aug 24, 2022 12:54PM

pi...@gmail.com <pi...@gmail.com> #7Aug 26, 2022 04:32PM

sa...@google.com <sa...@google.com> #8Nov 3, 2022 01:42PM

Add comment

Issue metadata