Status Update
No update yet.
Comments
se...@google.com
Hello,
If the request is failed it should return an error.
Is it not returning this error to you? Also, is this your full script? If not, please share it without personal information in order to reproduce it as you have it.
Regards.
do...@temp.goformative.com
Hi,
Correct it doesn't return any error, it just logs to the console and exits.
It is clear from inspecting the code of the gis script that will always just log a message in case of popup closed / blocked and do nothing further.
Do you have a baseline project I could use to create a reproduction? It's quite complicated to set up a new project that uses the gis login script, and simple code inspection will show that at no point does it attempt to return an error.
There isn't even a documented way to receive an error from this library.
se...@google.com
Hi,
Can you share the guide you used to set it up in order to do it as you did? Please provide as much information as possible.
Thank you!
se...@google.com
Hello,
It is stated on the documentation provided
Google then returns a TokenResponse containing an access token and list of scopes the user has granted access to, or an error, to your callback handler.
Users may close the account chooser or sign-in windows, in which case your callback function will not be invoked.
If there is a failure you will receive an error but if the user closes the window the callback will not receive anything.
This is intended behavior but, a Feature Request can be filed.
In order to do so, what benefit would this feature provide for you or your organization in terms of costs, employee productivity, if any?
Regards.
do...@temp.goformative.com
This is intended behavior but, a Feature Request can be filed.
Yes, I would like to request the feature.
When a user tries to log in using google and the operation is blocked because third-party cookies or popups are blocked, and they do not get any error message on the screen, they will think that our application does not work. This harms our business because it makes our application look bad in the eyes of those users.
Also, if a user has initiated a Google login it improves our user experience if we hide the login elements while they complete the google login. This avoids confusion as the user will not have a google login open and then proceed to do some other login operation. However, the way the API is designed currently we do not know if the Google popup is still open or not, so if the user changes their mind about Google login they cannot proceed with another login method.
do...@temp.goformative.com
Google then returns a TokenResponse containing an access token and list of scopes the user has granted access to, or an error, to your callback handler.
Also, the callback is not invoked if the popup fails to open due to popups being blocked, so in that sense this is a bug as that is an error but it is not reported.
se...@google.com
Hello,
Thank you for your comments.
I have forwarded this feature request internally.
Regards.
Description
A short description of the issue:
When using Google Identity Services in the browser to request a user login, it opens a popup.
If the login is successful, it invokes a callback with the access token.
However, if the login fails, there is no callback. This could be because the popup is blocked or the user simply did not complete the login and closed the window. The only solution to detect failure is a timeout, which is pretty lame.
For example:
What steps will reproduce the problem?
What is the expected output? What do you see instead? If you see error messages, please provide them.
There should be an additional callback that is called if the login popup flow fails due to the popup being blocked or the user closes the popup without completing the login.