Verified
Status Update
Comments
zs...@salesforce.com <zs...@salesforce.com> #2
Other context - we're seeing this when trying to update from Coil 1.x to 2.1. Coil is this image loading library:
ch...@google.com <ch...@google.com>
ch...@google.com <ch...@google.com> #3
Thanks for reporting this. As mentioned on Slack this looks like a bug in some optimization. It would be great if you could share a dump of the compiler inputs with
ap...@google.com <ap...@google.com> #4
Project: r8
Branch: main
commit 2b06bf7333125e8cd96e64bfcf40dc389e7d61ad
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Mon Aug 08 14:40:47 2022
Reproduce incorrect method rewriting from argument removal
Bug: b/241426917
Change-Id: Id78bbd4186f5df1465ef8eb5abf738f9f985fbe4
A src/test/java/com/android/tools/r8/optimize/argumentpropagation/ConsistentMethodRenamingWithArgumentRemovalAndStaticizingTest.java
https://r8-review.googlesource.com/70100
Branch: main
commit 2b06bf7333125e8cd96e64bfcf40dc389e7d61ad
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Mon Aug 08 14:40:47 2022
Reproduce incorrect method rewriting from argument removal
Bug:
Change-Id: Id78bbd4186f5df1465ef8eb5abf738f9f985fbe4
A src/test/java/com/android/tools/r8/optimize/argumentpropagation/ConsistentMethodRenamingWithArgumentRemovalAndStaticizingTest.java
ap...@google.com <ap...@google.com> #5
Project: r8
Branch: main
commit 711484cee55422825113c69b8dde17b462e41a46
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Tue Aug 09 18:32:09 2022
Fix incorrect cache key for new method signature cache
Bug: b/241426917
Change-Id: I96a3e206f4fba54922a7546879b1ddc6147ce64c
M src/main/java/com/android/tools/r8/graph/DexEncodedMethod.java
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
M src/test/java/com/android/tools/r8/optimize/argumentpropagation/ConsistentMethodRenamingWithArgumentRemovalAndStaticizingTest.java
M src/main/java/com/android/tools/r8/graph/DexTypeList.java
https://r8-review.googlesource.com/70101
Branch: main
commit 711484cee55422825113c69b8dde17b462e41a46
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Tue Aug 09 18:32:09 2022
Fix incorrect cache key for new method signature cache
Bug:
Change-Id: I96a3e206f4fba54922a7546879b1ddc6147ce64c
M src/main/java/com/android/tools/r8/graph/DexEncodedMethod.java
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
M src/test/java/com/android/tools/r8/optimize/argumentpropagation/ConsistentMethodRenamingWithArgumentRemovalAndStaticizingTest.java
M src/main/java/com/android/tools/r8/graph/DexTypeList.java
ap...@google.com <ap...@google.com> #6
Project: r8
Branch: 3.3
commit d6dfa2fced8ff0569e01e3943863680e77558293
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:37:30 2022
Version 3.3.75
Bug: b/242014056
Bug: b/241426917
Bug: b/241469650
Bug: b/241636314
Change-Id: Iaf8046e9cf38a70d6edfbff3a3e106fa4f61136c
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/70235
Branch: 3.3
commit d6dfa2fced8ff0569e01e3943863680e77558293
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:37:30 2022
Version 3.3.75
Bug:
Bug:
Bug:
Bug:
Change-Id: Iaf8046e9cf38a70d6edfbff3a3e106fa4f61136c
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #7
Project: r8
Branch: 3.3
commit 6e88ee78542293052b33c2a9ce0d8381f04c6399
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:18:35 2022
Fix incorrect cache key for new method signature cache
Bug: b/241426917
Change-Id: I96a3e206f4fba54922a7546879b1ddc6147ce64c
M src/main/java/com/android/tools/r8/graph/DexEncodedMethod.java
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
M src/test/java/com/android/tools/r8/optimize/argumentpropagation/ConsistentMethodRenamingWithArgumentRemovalAndStaticizingTest.java
M src/main/java/com/android/tools/r8/graph/DexTypeList.java
https://r8-review.googlesource.com/70228
Branch: 3.3
commit 6e88ee78542293052b33c2a9ce0d8381f04c6399
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:18:35 2022
Fix incorrect cache key for new method signature cache
Bug:
Change-Id: I96a3e206f4fba54922a7546879b1ddc6147ce64c
M src/main/java/com/android/tools/r8/graph/DexEncodedMethod.java
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
M src/test/java/com/android/tools/r8/optimize/argumentpropagation/ConsistentMethodRenamingWithArgumentRemovalAndStaticizingTest.java
M src/main/java/com/android/tools/r8/graph/DexTypeList.java
ap...@google.com <ap...@google.com> #8
Project: r8
Branch: 3.3
commit 93259aef23518cb8266b551f9bf9e1f35f1b63cd
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:14:53 2022
Reproduce incorrect method rewriting from argument removal
Bug: b/241426917
Change-Id: Id78bbd4186f5df1465ef8eb5abf738f9f985fbe4
A src/test/java/com/android/tools/r8/optimize/argumentpropagation/ConsistentMethodRenamingWithArgumentRemovalAndStaticizingTest.java
https://r8-review.googlesource.com/70226
Branch: 3.3
commit 93259aef23518cb8266b551f9bf9e1f35f1b63cd
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:14:53 2022
Reproduce incorrect method rewriting from argument removal
Bug:
Change-Id: Id78bbd4186f5df1465ef8eb5abf738f9f985fbe4
A src/test/java/com/android/tools/r8/optimize/argumentpropagation/ConsistentMethodRenamingWithArgumentRemovalAndStaticizingTest.java
ap...@google.com <ap...@google.com> #9
Project: r8
Branch: 3.2
commit 2fc1900f0274d6c8e5451d452c35b0e476b5892f
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:37:34 2022
Version 3.2.78
Bug: b/242014056
Bug: b/241426917
Bug: b/241469650
Bug: b/241636314
Change-Id: Iedbc13d21a676603a117980e01a98e117bb4bb60
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/70236
Branch: 3.2
commit 2fc1900f0274d6c8e5451d452c35b0e476b5892f
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:37:34 2022
Version 3.2.78
Bug:
Bug:
Bug:
Bug:
Change-Id: Iedbc13d21a676603a117980e01a98e117bb4bb60
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #10
Project: r8
Branch: 3.2
commit bed2a947fd1edb085d53c83df5b0128886381e7b
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:17:49 2022
Reproduce incorrect method rewriting from argument removal
Bug: b/241426917
Change-Id: Id78bbd4186f5df1465ef8eb5abf738f9f985fbe4
A src/test/java/com/android/tools/r8/optimize/argumentpropagation/ConsistentMethodRenamingWithArgumentRemovalAndStaticizingTest.java
https://r8-review.googlesource.com/70227
Branch: 3.2
commit bed2a947fd1edb085d53c83df5b0128886381e7b
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:17:49 2022
Reproduce incorrect method rewriting from argument removal
Bug:
Change-Id: Id78bbd4186f5df1465ef8eb5abf738f9f985fbe4
A src/test/java/com/android/tools/r8/optimize/argumentpropagation/ConsistentMethodRenamingWithArgumentRemovalAndStaticizingTest.java
ap...@google.com <ap...@google.com> #11
Project: r8
Branch: 3.3
commit 93259aef23518cb8266b551f9bf9e1f35f1b63cd
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:14:53 2022
Reproduce incorrect method rewriting from argument removal
Bug: b/241426917
Change-Id: Id78bbd4186f5df1465ef8eb5abf738f9f985fbe4
A src/test/java/com/android/tools/r8/optimize/argumentpropagation/ConsistentMethodRenamingWithArgumentRemovalAndStaticizingTest.java
https://r8-review.googlesource.com/70226
Branch: 3.3
commit 93259aef23518cb8266b551f9bf9e1f35f1b63cd
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:14:53 2022
Reproduce incorrect method rewriting from argument removal
Bug:
Change-Id: Id78bbd4186f5df1465ef8eb5abf738f9f985fbe4
A src/test/java/com/android/tools/r8/optimize/argumentpropagation/ConsistentMethodRenamingWithArgumentRemovalAndStaticizingTest.java
ch...@google.com <ch...@google.com> #12
Thanks for reporting this. This should now be fixed in R8 version 3.3.75.
Description
We see this strange failure when running R8 in certain conditions. I'm not entirely sure what the trigger is and happy to share more configuration files privately if it helps.
This is using R8https://github.com/slackhq/keeper ) and include its generated rules. okio.Path doesn't appear in any of the generated rules though, so I'm not sure what the issue is.
3.3.28
with AGP7.2.2
. What's strange is that it only happens when we enable Keeper (