Verified
Status Update
Comments
ch...@google.com <ch...@google.com> #2
Fixed in r1313.
ch...@google.com <ch...@google.com> #3
[Empty comment from Monorail migration]
sg...@google.com <sg...@google.com> #4
[Empty comment from Monorail migration]
[Deleted User] <[Deleted User]> #5
sg...@google.com <sg...@google.com> #6
Thanks. The dump reproduce the issue, also on our main branch. For the R8 team I have placed the dump in the team folder.
ap...@google.com <ap...@google.com> #7
Project: r8
Branch: main
commit 929fcc2200a5b3f3e695f03d77b198ea8cb7bb25
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Mon Aug 08 09:43:54 2022
Ensure out-value of Enum.valueOf is analyzed by enum unboxer
Bug: b/241469650
Change-Id: Iacb3a41b00cc2afb4b2d4e5f26e763a9bc5202b4
M src/main/java/com/android/tools/r8/ir/optimize/enums/EnumUnboxerImpl.java
M src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
https://r8-review.googlesource.com/70083
Branch: main
commit 929fcc2200a5b3f3e695f03d77b198ea8cb7bb25
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Mon Aug 08 09:43:54 2022
Ensure out-value of Enum.valueOf is analyzed by enum unboxer
Bug:
Change-Id: Iacb3a41b00cc2afb4b2d4e5f26e763a9bc5202b4
M src/main/java/com/android/tools/r8/ir/optimize/enums/EnumUnboxerImpl.java
M src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
ap...@google.com <ap...@google.com> #8
Project: r8
Branch: main
commit be9524b1881e0d2dcbcaad1b5b5f3d72ef7a9910
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 05 16:02:57 2022
Reproduce inadequate enum unboxing analysis for Enum.valueOf
Bug: b/241469650
Change-Id: I9b04c9081de39fca941c6ee0570b0cfbdc024b30
A src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
M src/test/java/com/android/tools/r8/enumunboxing/EnumUnboxingTestBase.java
https://r8-review.googlesource.com/70082
Branch: main
commit be9524b1881e0d2dcbcaad1b5b5f3d72ef7a9910
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 05 16:02:57 2022
Reproduce inadequate enum unboxing analysis for Enum.valueOf
Bug:
Change-Id: I9b04c9081de39fca941c6ee0570b0cfbdc024b30
A src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
M src/test/java/com/android/tools/r8/enumunboxing/EnumUnboxingTestBase.java
ap...@google.com <ap...@google.com> #9
Project: r8
Branch: 3.3
commit d6dfa2fced8ff0569e01e3943863680e77558293
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:37:30 2022
Version 3.3.75
Bug: b/242014056
Bug: b/241426917
Bug: b/241469650
Bug: b/241636314
Change-Id: Iaf8046e9cf38a70d6edfbff3a3e106fa4f61136c
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/70235
Branch: 3.3
commit d6dfa2fced8ff0569e01e3943863680e77558293
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:37:30 2022
Version 3.3.75
Bug:
Bug:
Bug:
Bug:
Change-Id: Iaf8046e9cf38a70d6edfbff3a3e106fa4f61136c
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #10
Project: r8
Branch: 3.3
commit 01f7123c79b5c40ffba0537f4cf6f7a89be727a7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:23:15 2022
Ensure out-value of Enum.valueOf is analyzed by enum unboxer
Bug: b/241469650
Change-Id: Iacb3a41b00cc2afb4b2d4e5f26e763a9bc5202b4
M src/main/java/com/android/tools/r8/ir/optimize/enums/EnumUnboxerImpl.java
M src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
https://r8-review.googlesource.com/70231
Branch: 3.3
commit 01f7123c79b5c40ffba0537f4cf6f7a89be727a7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:23:15 2022
Ensure out-value of Enum.valueOf is analyzed by enum unboxer
Bug:
Change-Id: Iacb3a41b00cc2afb4b2d4e5f26e763a9bc5202b4
M src/main/java/com/android/tools/r8/ir/optimize/enums/EnumUnboxerImpl.java
M src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
ap...@google.com <ap...@google.com> #11
Project: r8
Branch: 3.3
commit 84d394798bbf3f011a06637bfc22ca477e863e19
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:20:31 2022
Reproduce inadequate enum unboxing analysis for Enum.valueOf
Bug: b/241469650
Change-Id: I9b04c9081de39fca941c6ee0570b0cfbdc024b30
A src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
M src/test/java/com/android/tools/r8/enumunboxing/EnumUnboxingTestBase.java
https://r8-review.googlesource.com/70230
Branch: 3.3
commit 84d394798bbf3f011a06637bfc22ca477e863e19
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:20:31 2022
Reproduce inadequate enum unboxing analysis for Enum.valueOf
Bug:
Change-Id: I9b04c9081de39fca941c6ee0570b0cfbdc024b30
A src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
M src/test/java/com/android/tools/r8/enumunboxing/EnumUnboxingTestBase.java
ap...@google.com <ap...@google.com> #12
Project: r8
Branch: 3.2
commit 2fc1900f0274d6c8e5451d452c35b0e476b5892f
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:37:34 2022
Version 3.2.78
Bug: b/242014056
Bug: b/241426917
Bug: b/241469650
Bug: b/241636314
Change-Id: Iedbc13d21a676603a117980e01a98e117bb4bb60
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/70236
Branch: 3.2
commit 2fc1900f0274d6c8e5451d452c35b0e476b5892f
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:37:34 2022
Version 3.2.78
Bug:
Bug:
Bug:
Bug:
Change-Id: Iedbc13d21a676603a117980e01a98e117bb4bb60
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #13
Project: r8
Branch: 3.2
commit f6467492562cafdfdc851bc16acf1c52d9f50576
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:23:29 2022
Ensure out-value of Enum.valueOf is analyzed by enum unboxer
Bug: b/241469650
Change-Id: Iacb3a41b00cc2afb4b2d4e5f26e763a9bc5202b4
M src/main/java/com/android/tools/r8/ir/optimize/enums/EnumUnboxerImpl.java
M src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
https://r8-review.googlesource.com/70232
Branch: 3.2
commit f6467492562cafdfdc851bc16acf1c52d9f50576
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:23:29 2022
Ensure out-value of Enum.valueOf is analyzed by enum unboxer
Bug:
Change-Id: Iacb3a41b00cc2afb4b2d4e5f26e763a9bc5202b4
M src/main/java/com/android/tools/r8/ir/optimize/enums/EnumUnboxerImpl.java
M src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
ap...@google.com <ap...@google.com> #14
Project: r8
Branch: 3.2
commit 843a0e56fa6bd72a8b7e8932164fe82dcaaab85d
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:20:23 2022
Reproduce inadequate enum unboxing analysis for Enum.valueOf
Bug: b/241469650
Change-Id: I9b04c9081de39fca941c6ee0570b0cfbdc024b30
A src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
M src/test/java/com/android/tools/r8/enumunboxing/EnumUnboxingTestBase.java
https://r8-review.googlesource.com/70229
Branch: 3.2
commit 843a0e56fa6bd72a8b7e8932164fe82dcaaab85d
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:20:23 2022
Reproduce inadequate enum unboxing analysis for Enum.valueOf
Bug:
Change-Id: I9b04c9081de39fca941c6ee0570b0cfbdc024b30
A src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
M src/test/java/com/android/tools/r8/enumunboxing/EnumUnboxingTestBase.java
ap...@google.com <ap...@google.com> #15
Project: r8
Branch: 3.3
commit 01f7123c79b5c40ffba0537f4cf6f7a89be727a7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:23:15 2022
Ensure out-value of Enum.valueOf is analyzed by enum unboxer
Bug: b/241469650
Change-Id: Iacb3a41b00cc2afb4b2d4e5f26e763a9bc5202b4
M src/main/java/com/android/tools/r8/ir/optimize/enums/EnumUnboxerImpl.java
M src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
https://r8-review.googlesource.com/70231
Branch: 3.3
commit 01f7123c79b5c40ffba0537f4cf6f7a89be727a7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:23:15 2022
Ensure out-value of Enum.valueOf is analyzed by enum unboxer
Bug:
Change-Id: Iacb3a41b00cc2afb4b2d4e5f26e763a9bc5202b4
M src/main/java/com/android/tools/r8/ir/optimize/enums/EnumUnboxerImpl.java
M src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
ap...@google.com <ap...@google.com> #16
Project: r8
Branch: 3.3
commit 84d394798bbf3f011a06637bfc22ca477e863e19
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:20:31 2022
Reproduce inadequate enum unboxing analysis for Enum.valueOf
Bug: b/241469650
Change-Id: I9b04c9081de39fca941c6ee0570b0cfbdc024b30
A src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
M src/test/java/com/android/tools/r8/enumunboxing/EnumUnboxingTestBase.java
https://r8-review.googlesource.com/70230
Branch: 3.3
commit 84d394798bbf3f011a06637bfc22ca477e863e19
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:20:31 2022
Reproduce inadequate enum unboxing analysis for Enum.valueOf
Bug:
Change-Id: I9b04c9081de39fca941c6ee0570b0cfbdc024b30
A src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
M src/test/java/com/android/tools/r8/enumunboxing/EnumUnboxingTestBase.java
ch...@google.com <ch...@google.com> #17
Thanks for reporting this. This should now be fixed in R8 versions 3.2.78 and 3.3.75. I will also cherry-pick this to R8 version 3.1.82.
ap...@google.com <ap...@google.com> #18
Project: r8
Branch: 3.1
commit 73f3a4859696c7ca4e1817064ab2dad4e394d0b8
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Aug 11 09:18:21 2022
Version 3.1.82
Bug: b/241469650
Change-Id: Ifdda4179c8ecb85ede4e629987d0106e96670974
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/70242
Branch: 3.1
commit 73f3a4859696c7ca4e1817064ab2dad4e394d0b8
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Aug 11 09:18:21 2022
Version 3.1.82
Bug:
Change-Id: Ifdda4179c8ecb85ede4e629987d0106e96670974
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #19
Project: r8
Branch: 3.1
commit acc43e89e26a4b947bdcadc6ee7b587e335b2ef0
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Aug 11 09:17:10 2022
Ensure out-value of Enum.valueOf is analyzed by enum unboxer
Bug: b/241469650
Change-Id: Iacb3a41b00cc2afb4b2d4e5f26e763a9bc5202b4
M src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
M src/main/java/com/android/tools/r8/ir/optimize/enums/EnumUnboxer.java
https://r8-review.googlesource.com/70241
Branch: 3.1
commit acc43e89e26a4b947bdcadc6ee7b587e335b2ef0
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Aug 11 09:17:10 2022
Ensure out-value of Enum.valueOf is analyzed by enum unboxer
Bug:
Change-Id: Iacb3a41b00cc2afb4b2d4e5f26e763a9bc5202b4
M src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
M src/main/java/com/android/tools/r8/ir/optimize/enums/EnumUnboxer.java
ap...@google.com <ap...@google.com> #20
Project: r8
Branch: 3.1
commit d2dc31e5c429fe50f5709305f99c2429b582a3f3
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Aug 11 09:13:36 2022
Reproduce inadequate enum unboxing analysis for Enum.valueOf
Bug: b/241469650
Change-Id: I9b04c9081de39fca941c6ee0570b0cfbdc024b30
A src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
M src/test/java/com/android/tools/r8/enumunboxing/EnumUnboxingTestBase.java
https://r8-review.googlesource.com/70240
Branch: 3.1
commit d2dc31e5c429fe50f5709305f99c2429b582a3f3
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Aug 11 09:13:36 2022
Reproduce inadequate enum unboxing analysis for Enum.valueOf
Bug:
Change-Id: I9b04c9081de39fca941c6ee0570b0cfbdc024b30
A src/test/java/com/android/tools/r8/enumunboxing/ValueOfWithoutCastEnumUnboxingTest.java
M src/test/java/com/android/tools/r8/enumunboxing/EnumUnboxingTestBase.java
Description
I started getting this error:
Tried to build using the following versions of R8:
Fails on all on them with
Unexpected conversion of imprecise type: TOP (everything)
I can provide more info if needed.