AGP 7.4.0-alpha09 generates builds that won't upload into Firebase App Distribution [241469653]

Fixed

Bug

Status Update

No update yet.

Description

co...@protonmail.com

created issue #1

Aug 5, 2022 01:59PM

You can see some of my investigation in this thread https://github.com/firebase/firebase-android-sdk/issues/3966

My hypothesis is either AGP 7.4.0-alpha09 has something broken that prevents builds to firebase app distribution OR app distribution needs something changed so that it can handle these builds.

I do not have a minimal repro project. Everytime I try to prune down my companys project, the uploads to firebase work again.

What I can say for certain is that if I switch from AGP 7.4.0-alpha09 to AGP 7.3.0-beta05, then everything works. If I move back to AGP 7.4.0-alpha09 then I can't upload into firebase app dist BUT I can upload to play store. I'm generating apks (not bundles) in all cases as I have not switched to aabs yet.

To continue my research I'm going to try to go from alpha01 to alpha09 and see which one breaks.

Comments

co...@protonmail.com <co...@protonmail.com> #2Aug 5, 2022 02:59PM

Thanks for reporting this and for taking the time to create a reproduction. The given app seems to compile to dex in a few seconds, but compiling to class files takes several minutes due to hitting unintentional quadratic behavior in dead code elimination. I will look into fixing this and report back once you should be able to test a new version.

uc...@google.com <uc...@google.com> Aug 8, 2022 05:39AM

Assigned to an...@google.com.

je...@google.com <je...@google.com> #3Aug 8, 2022 09:46PM

Reassigned to sp...@google.com.

Project: r8
Branch: main

commit 85ad0d69f99553ce6dd0b99d383e1c55dc70f3df
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Feb 08 08:26:54 2023

Refactor value-is-dead analysis to separate analysis class

Bug:

b/267990059

Change-Id: I8b881203ebe21395f48c8eeb6434faa03f7f9d46

M src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
M src/main/java/com/android/tools/r8/ir/code/Value.java
A src/main/java/com/android/tools/r8/ir/code/ValueIsDeadAnalysis.java
M src/main/java/com/android/tools/r8/ir/optimize/DeadCodeRemover.java

https://r8-review.googlesource.com/75681

sp...@google.com <sp...@google.com> #4Aug 8, 2022 11:20PM

Project: r8
Branch: main

commit 6edc639a92de908f89ba86445a9d6b21351c58fd
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Feb 08 12:31:15 2023

Rewrite value-is-dead analysis to a worklist algorithm

Bug:

b/267990059

Change-Id: I699f43eba8774083a4b5f2aa2edf7c5d80df4c8e

M src/main/java/com/android/tools/r8/ir/code/ValueIsDeadAnalysis.java

https://r8-review.googlesource.com/75684

co...@protonmail.com <co...@protonmail.com> #5Aug 8, 2022 11:22PM

Project: r8
Branch: main

commit 70bbb88b80b31de9a5ccbe30d27a962b0fb0c45a
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Feb 08 16:13:24 2023

Fix repeated analysis of values in dead code removal

Bug:

b/267990059

Change-Id: I9deebf700e936ad81a8fb25d067acc04637d980d

M src/main/java/com/android/tools/r8/ir/code/ArrayPut.java
M src/main/java/com/android/tools/r8/ir/code/ValueIsDeadAnalysis.java
M src/main/java/com/android/tools/r8/ir/optimize/DeadCodeRemover.java
M src/main/java/com/android/tools/r8/utils/MapUtils.java

https://r8-review.googlesource.com/75682

co...@protonmail.com <co...@protonmail.com> #6Aug 8, 2022 11:46PM

Project: r8
Branch: main

commit 54ed0312d2e5ade4b8092a86989d0e6827e646dd
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Feb 09 08:49:58 2023

Refinements to value-is-dead analysis

Bug:

b/267990059

Fixes:

b/268335684

Change-Id: I8007b13e2a4e0c32dffc181a827867ff4ab0373e

M src/main/java/com/android/tools/r8/ir/code/ValueIsDeadAnalysis.java
M src/main/java/com/android/tools/r8/ir/optimize/DeadCodeRemover.java

https://r8-review.googlesource.com/75761

Message last modified on Aug 8, 2022 11:46PM

co...@protonmail.com <co...@protonmail.com> #7Aug 8, 2022 11:51PM

Project: r8
Branch: 4.0

commit 2fc27f8cef33c22525c585e5c65bf3d67a18755a
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Feb 09 11:19:09 2023

Version 4.0.53

Bug:

b/267990059

Bug:

b/267463817

Change-Id: I62f98b9723358310ade7f2bd5f8e589fa91c8ab6

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/75769

sp...@google.com <sp...@google.com> #8Aug 9, 2022 04:43PM

Project: r8
Branch: 4.0

commit b86fdf2b2427605e6a238a0232932fa1268245f8
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Feb 09 11:16:04 2023

Refinements to value-is-dead analysis

Bug:

b/267990059

Fixes:

b/268335684

Change-Id: I8007b13e2a4e0c32dffc181a827867ff4ab0373e

M src/main/java/com/android/tools/r8/ir/code/ValueIsDeadAnalysis.java
M src/main/java/com/android/tools/r8/ir/optimize/DeadCodeRemover.java

https://r8-review.googlesource.com/75767

co...@protonmail.com <co...@protonmail.com> #9Aug 9, 2022 04:58PM

Project: r8
Branch: 4.0

commit 472c7fab11e7da906d07eb04d8600f6aea8d3c1e
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Feb 09 11:15:38 2023

Fix repeated analysis of values in dead code removal

Bug:

b/267990059

https://r8-review.googlesource.com/75766

sp...@google.com <sp...@google.com> #10Aug 9, 2022 05:03PM

Project: r8
Branch: 4.0

commit b14e5bc4c5f41fc593cc6176de220ce43d9c899f
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Feb 09 11:15:14 2023

Rewrite value-is-dead analysis to a worklist algorithm

Bug:

b/267990059

Change-Id: I699f43eba8774083a4b5f2aa2edf7c5d80df4c8e

M src/main/java/com/android/tools/r8/ir/code/ValueIsDeadAnalysis.java

https://r8-review.googlesource.com/75765

co...@protonmail.com <co...@protonmail.com> #11Aug 9, 2022 05:06PM

Project: r8
Branch: 4.0

commit 4621177fe24819fe5459b065a9d6d138cb79b5b2
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Feb 09 11:14:33 2023

Refactor value-is-dead analysis to separate analysis class

Bug:

b/267990059

https://r8-review.googlesource.com/75764

sp...@google.com <sp...@google.com> #12Aug 9, 2022 05:20PM

Project: r8
Branch: 8.0

commit 376af144cf327f0f2b0a2de0a38939a59216a08d
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Feb 09 11:25:18 2023

Version 8.0.29

Bug:

b/267990059

Bug:

b/267463817

Change-Id: I994d406bae7514482ffdf2ef10f092b5a96cc328

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/75776

co...@protonmail.com <co...@protonmail.com> #13Aug 11, 2022 06:52PM

Project: r8
Branch: 8.0

commit 77704f63db4161833b7072c42cbf9869a2f20e80
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Feb 09 11:23:20 2023

Refinements to value-is-dead analysis

Bug:

b/267990059

Fixes:

b/268335684

Change-Id: I8007b13e2a4e0c32dffc181a827867ff4ab0373e

M src/main/java/com/android/tools/r8/ir/code/ValueIsDeadAnalysis.java
M src/main/java/com/android/tools/r8/ir/optimize/DeadCodeRemover.java

https://r8-review.googlesource.com/75773

sp...@google.com <sp...@google.com> #14Aug 11, 2022 06:58PM

Status: Won't Fix (Not Reproducible)

Project: r8
Branch: 8.0

commit 33930d7b7ff37a746a304bb0230b34123b1e0e6f
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Feb 09 11:22:50 2023

Fix repeated analysis of values in dead code removal

Bug:

b/267990059

https://r8-review.googlesource.com/75772

sp...@google.com <sp...@google.com> Oct 28, 2022 06:19PM

Status: Assigned (reopened)

sp...@google.com <sp...@google.com> #15Nov 1, 2022 04:48PM

Marked as fixed.

Project: r8
Branch: 8.0

commit 923cf259db1b2f35578a486960afcd28369c520f
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Feb 09 11:22:16 2023

Rewrite value-is-dead analysis to a worklist algorithm

Bug:

b/267990059

Change-Id: I699f43eba8774083a4b5f2aa2edf7c5d80df4c8e

M src/main/java/com/android/tools/r8/ir/code/ValueIsDeadAnalysis.java

https://r8-review.googlesource.com/75771

sp...@google.com <sp...@google.com> #16Nov 1, 2022 04:50PM

Project: r8
Branch: 8.0

commit 736dd75501862e23764d265887a99ef8d8af0c9d
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Feb 09 11:21:02 2023

Refactor value-is-dead analysis to separate analysis class

Bug:

b/267990059

https://r8-review.googlesource.com/75770

co...@protonmail.com <co...@protonmail.com> #17Nov 2, 2022 08:30AM

This should now be fixed in R8 versions 4.0.53 and 8.0.29 - and next week in 8.1.19-dev.

On my machine the build time for compiling the reproduction with R8 is down from ~190s to ~3s.

Issue 241469653

Description

Issue summary

Comments

co...@protonmail.com <co...@protonmail.com> #2Aug 5, 2022 02:59PM

uc...@google.com <uc...@google.com> Aug 8, 2022 05:39AM

je...@google.com <je...@google.com> #3Aug 8, 2022 09:46PM

sp...@google.com <sp...@google.com> #4Aug 8, 2022 11:20PM

co...@protonmail.com <co...@protonmail.com> #5Aug 8, 2022 11:22PM

co...@protonmail.com <co...@protonmail.com> #6Aug 8, 2022 11:46PM

co...@protonmail.com <co...@protonmail.com> #7Aug 8, 2022 11:51PM

sp...@google.com <sp...@google.com> #8Aug 9, 2022 04:43PM

co...@protonmail.com <co...@protonmail.com> #9Aug 9, 2022 04:58PM

sp...@google.com <sp...@google.com> #10Aug 9, 2022 05:03PM

co...@protonmail.com <co...@protonmail.com> #11Aug 9, 2022 05:06PM

sp...@google.com <sp...@google.com> #12Aug 9, 2022 05:20PM

co...@protonmail.com <co...@protonmail.com> #13Aug 11, 2022 06:52PM

sp...@google.com <sp...@google.com> #14Aug 11, 2022 06:58PM

sp...@google.com <sp...@google.com> Oct 28, 2022 06:19PM

sp...@google.com <sp...@google.com> #15Nov 1, 2022 04:48PM

sp...@google.com <sp...@google.com> #16Nov 1, 2022 04:50PM

co...@protonmail.com <co...@protonmail.com> #17Nov 2, 2022 08:30AM

Add comment

Issue metadata