IssueTracker

Project: platform/frameworks/support
Branch: androidx-main

commit 906b235af229dec2f2e163ee309d5a82426be08d
Author: Zach Klippenstein <klippenstein@google.com>
Date:   Thu Sep 22 09:18:37 2022

    Merge some almost-redundant scrollable + focusable tests.
   
    Also makes both sets of tests parameterized on both orientation and
    scrolling direction.
   
    Bug: b/241591211
    Test: ScrollableFocusableInteractionTest
    Change-Id: I487344ff1705c5875bd60c25c5b7f456e0b7e65d

M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableFocusableInteractionTest.kt
D       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusInScrollableRowTest.kt

https://android-review.googlesource.com/2227761

Project: platform/frameworks/support
Branch: androidx-main

commit 7e77bb541331ce0d62cabad732e43eca41ac978a
Author: Zach Klippenstein <klippenstein@google.com>
Date:   Wed Jul 06 11:42:21 2022

    Move BringIntoView queueing into the scrollable implementation.
   
    This change removes the over-complicated coroutine-based queuing of
    bringIntoView requests in the BringIntoViewResponder, which now is only
    responsible for dispatching the request to the actual responder
    interface and propagating it up the modifier local chain.
   
    This gives the actual responder implementation (i.e. in
    Modifier.scrollable) all the information about conflicting
    requests and manage the queue of ongoing requests with an actual,
    explicit queue that is much more straightforward than the previous
    coroutine job chaining mess. Each request is stored in an actual list
    along with the continuation from the request, and requests are
    explicitly resumed or cancelled when needed. This also makes debugging
    easier, because there's an actual queue data structure we can inspect,
    which contains all the actual information about each request.
   
    It also completely changes how the scroll animation is performed.
    On every frame, the scroll target is recomputed to account for
    changes in the viewport size, the request size, or the set of active
    requests since the last frame, while still keeping the animation
    smooth. The animation logic is in its own class, which allows a single
    suspend animation call to animate to a target value that can be updated
    while the animation is running.
   
    While this change is a valuable cleanup on its own, it also fixes
    b/241591211, and paves the way for replacing scrollable's implicit
    focused child tracking with an explicit API for keeping a thing in view.
   
    Fixes: b/241591211
    Bug: b/192043120
    Bug: b/237190748
    Bug: b/230756508
    Bug: b/239451114
    Test: ScrollableFocusableInteractionTest
    Test: androidx.compose.foundation.relocation.*
    Test: RebasableAnimationStateTest
    Test: BringIntoViewRequestPriorityQueueTest
    Relnote: "Rewrote the way scrollables respond to
        `bringIntoViewRequesters` and focusables to better model the
        complexity of those operations and handle more edge cases."
    Change-Id: I2e5fec8c8582a8fe1f191e37fd0f4f9165678664

M       compose/foundation/foundation/api/current.txt
M       compose/foundation/foundation/api/public_plus_experimental_current.txt
M       compose/foundation/foundation/api/restricted_current.txt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/ScrollableFocusedChildDemo.kt
A       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/relocation/BringIntoViewResponderDemo.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/relocation/BringRectangleIntoViewDemo.kt
M       compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/BringIntoViewSamples.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableFocusableInteractionTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/list/LazyListFocusMoveTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/relocation/BringIntoViewResponderTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/relocation/BringIntoViewScrollableInteractionTest.kt
A       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/BringIntoViewRequestPriorityQueue.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/ContentInViewModifier.kt
A       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/UpdatableAnimationState.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/relocation/BringIntoViewResponder.kt
A       compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/gestures/BringIntoViewRequestPriorityQueueTest.kt
A       compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/gestures/UpdatableAnimationStateTest.kt

https://android-review.googlesource.com/2178020