Compilation failure from class inlining object with indirect instance-of users [242014056]

Verified

Bug

Status Update

No update yet.

Description

ch...@google.com

created issue #1

Aug 10, 2022 07:37AM

Stack trace:

Caused by: com.android.tools.r8.errors.Unreachable: Unexpected usage left in method `void com.android.tools.r8.shaking.ForwardingConstructorShakingOnDexTest$Main.main(java.lang.String[])` after inlining: InstanceOf           v5 <- v1; com.android.tools.r8.shaking.ForwardingConstructorShakingOnDexTest$B
	at com.android.tools.r8.ir.optimize.classinliner.InlineCandidateProcessor.removeMiscUsages(InlineCandidateProcessor.java:661)
	at com.android.tools.r8.ir.optimize.classinliner.InlineCandidateProcessor.processInlining(InlineCandidateProcessor.java:390)
	at com.android.tools.r8.ir.optimize.classinliner.ClassInliner.processMethodCode(ClassInliner.java:215)
	at com.android.tools.r8.ir.conversion.IRConverter.optimize(IRConverter.java:1389)
	at com.android.tools.r8.ir.conversion.IRConverter.rewriteDesugaredCodeInternal(IRConverter.java:1062)
	at com.android.tools.r8.ir.conversion.IRConverter.lambda$rewriteDesugaredCode$15(IRConverter.java:1011)
	at com.android.tools.r8.utils.ExceptionUtils.withOriginAndPositionAttachmentHandler(ExceptionUtils.java:246)
	at com.android.tools.r8.ir.conversion.IRConverter.rewriteDesugaredCode(IRConverter.java:1007)
	at com.android.tools.r8.ir.conversion.IRConverter.processDesugaredMethod(IRConverter.java:968)
	at com.android.tools.r8.ir.conversion.IRConverter.lambda$optimize$9(IRConverter.java:680)
	at com.android.tools.r8.ir.conversion.PrimaryMethodProcessor.lambda$forEachMethod$0(PrimaryMethodProcessor.java:138)
	at com.android.tools.r8.utils.ThreadUtils.lambda$processItemsWithResults$1(ThreadUtils.java:42)
	at com.android.tools.r8.utils.ThreadUtils.lambda$processItemsWithResults$3(ThreadUtils.java:69)
	at java.base/java.util.concurrent.ForkJoinTask$AdaptedCallable.exec(ForkJoinTask.java:1448)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)

Comments

ap...@google.com <ap...@google.com> #2Aug 10, 2022 11:00AM

Fixed in r1313.

ap...@google.com <ap...@google.com> #3Aug 10, 2022 11:00AM

[Empty comment from Monorail migration]

ap...@google.com <ap...@google.com> #4Aug 11, 2022 06:53AM

[Empty comment from Monorail migration]

ap...@google.com <ap...@google.com> #5Aug 11, 2022 06:53AM

This issue was migrated from

crbug.com/nativeclient/245?no_tracker_redirect=1

[Monorail components: TrustedRT]

ap...@google.com <ap...@google.com> #6Aug 11, 2022 06:53AM

Project: r8
Branch: 3.3

commit 656c28be992a42dda14a622a918a8e5b0f97000f
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:10:01 2022

Reproduce unhandled instance-of user in class inliner

Bug:

b/242014056

Change-Id: Ia56517efe97ff769359ba96f6adb0d4ce6a42c3b

A src/test/java/com/android/tools/r8/ir/optimize/classinliner/IndirectInstanceOfUserInParentConstructorClassInliningTest.java

https://r8-review.googlesource.com/70222

ap...@google.com <ap...@google.com> #7Aug 11, 2022 06:53AM

Project: r8
Branch: 3.2

commit 2fc1900f0274d6c8e5451d452c35b0e476b5892f
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:37:34 2022

Version 3.2.78

Bug:

Bug:

Bug:

Bug:

Change-Id: Iedbc13d21a676603a117980e01a98e117bb4bb60

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/70236

ap...@google.com <ap...@google.com> #8Aug 11, 2022 06:53AM

Project: r8
Branch: 3.2

commit 57ad889512b74705d68198491b6d3a900a9a20e8
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:14:08 2022

Handle indirect instance-of users in class inliner

Bug:

b/242014056

Change-Id: I442088cf8b10ec777fbe9bf55cc037f2a97a54d2

M src/test/java/com/android/tools/r8/ir/optimize/classinliner/IndirectInstanceOfUserInParentConstructorClassInliningTest.java
M src/main/java/com/android/tools/r8/ir/optimize/classinliner/InlineCandidateProcessor.java
M src/main/java/com/android/tools/r8/ir/code/InstructionListIterator.java

https://r8-review.googlesource.com/70225

ap...@google.com <ap...@google.com> #9Aug 11, 2022 06:53AM

Project: r8
Branch: 3.2

commit fc0aa098832a2419045b32d247c8f63471621256
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:10:31 2022

Reproduce unhandled instance-of user in class inliner

Bug:

b/242014056

Change-Id: Ia56517efe97ff769359ba96f6adb0d4ce6a42c3b

A src/test/java/com/android/tools/r8/ir/optimize/classinliner/IndirectInstanceOfUserInParentConstructorClassInliningTest.java

https://r8-review.googlesource.com/70223

ap...@google.com <ap...@google.com> #10Aug 11, 2022 06:54AM

Project: r8
Branch: 3.3

commit a686d4704036dc62c20d263baac7bb4ac47a6056
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 10 18:12:58 2022

Handle indirect instance-of users in class inliner

Bug:

b/242014056

https://r8-review.googlesource.com/70224

ap...@google.com <ap...@google.com> #11Aug 11, 2022 06:54AM

b/242014056

Change-Id: Ia56517efe97ff769359ba96f6adb0d4ce6a42c3b

A src/test/java/com/android/tools/r8/ir/optimize/classinliner/IndirectInstanceOfUserInParentConstructorClassInliningTest.java

https://r8-review.googlesource.com/70222

ch...@google.com <ch...@google.com> Aug 11, 2022 07:02AM

Verified by ch...@google.com.

Issue 242014056

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Aug 10, 2022 11:00AM

ap...@google.com <ap...@google.com> #3Aug 10, 2022 11:00AM

ap...@google.com <ap...@google.com> #4Aug 11, 2022 06:53AM

ap...@google.com <ap...@google.com> #5Aug 11, 2022 06:53AM

ap...@google.com <ap...@google.com> #6Aug 11, 2022 06:53AM

ap...@google.com <ap...@google.com> #7Aug 11, 2022 06:53AM

ap...@google.com <ap...@google.com> #8Aug 11, 2022 06:53AM

ap...@google.com <ap...@google.com> #9Aug 11, 2022 06:53AM

ap...@google.com <ap...@google.com> #10Aug 11, 2022 06:54AM

ap...@google.com <ap...@google.com> #11Aug 11, 2022 06:54AM

ch...@google.com <ch...@google.com> Aug 11, 2022 07:02AM

Add comment

Issue metadata