Status Update
Comments
vi...@google.com <vi...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Remove android specific NavControllerViewModel
Expand for full commit details
Remove android specific NavControllerViewModel
Everything in NavControllerViewModel is common API so we don't need an
Android version. Moving that code to common.
Test: all tests pass
Bug: 403616316
Change-Id: Ibe154b2d04adc0a536f9a5e170cc8fbb44ed1bcf
Files:
- D
navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavControllerViewModel.android.kt
- M
navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/NavControllerViewModel.kt
Hash: 3bb40a6be709d8c7e13f56f248a6433154aec72e
Date: Fri Mar 14 21:37:30 2025
lu...@gmail.com <lu...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Implement nonAndroid NavType
Expand for full commit details
Implement nonAndroid NavType
Moving call common implementation of NavType to commonMain and then
allow both the nonAndroid and Android implementation to use them.
Test: all tests pass
Bug: 403616316
Change-Id: I297d8846859aaa719b179c7e69e993d0d6e28fd6
Files:
- M
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavType.android.kt
- M
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavType.kt
- M
navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavType.nonAndroid.kt
Hash: 8f968ddbb3b8296af2033db4cf2658255fa43853
Date: Fri Mar 14 22:41:34 2025
ra...@google.com <ra...@google.com>
pa...@google.com <pa...@google.com>
pa...@google.com <pa...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Change NavBackStackEntryState to SavedState
Expand for full commit details
Change NavBackStackEntryState to SavedState
Instead of NavBackStackEntryState being a Parcelable, we can change it
to use SavedState. This allows for compat with other platforms.
Test: all tests pass
Bug: 403616316
Change-Id: I1da40e98fbc70413e0818a95cb00aa1e5aa7a3dd
Files:
- M
navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavBackStackEntryState.android.kt
- M
navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavController.android.kt
- A
navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/NavBackStackEntryState.kt
- A
navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/internal/NavBackStackEntryStateImpl.kt
- A
navigation/navigation-runtime/src/nonAndroidMain/kotlin/androidx/navigation/NavBackStackEntryState.nonAndroid.kt
Hash: 52447f8ffb1f3e1f9890f8bb9d1ac1690aad508d
Date: Thu Mar 20 19:48:37 2025
lu...@gmail.com <lu...@gmail.com> #5
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Introduce NavContext
Expand for full commit details
Introduce NavContext
Providing a multiplatform compatible version of Context that can be
used across navigation.
RelNote: "Added multi-platform NavContext that helps to wrap Android's context."
Test: all tests pass
Bug: 403616316
Change-Id: Ic4b1249ea6dc1a363855a4162ef136bf74809256
Files:
- M
navigation/navigation-common/bcv/native/current.txt
- M
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavBackStackEntry.android.kt
- M
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavDestination.android.kt
- M
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavGraph.android.kt
- A
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/internal/NavContext.android.kt
- M
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavBackStackEntry.kt
- A
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/internal/NavContext.kt
- M
navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavBackStackEntry.nonAndroid.kt
- A
navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/internal/NavContext.nonAndroid.kt
- M
navigation/navigation-runtime/src/androidInstrumentedTest/kotlin/androidx/navigation/NavBackStackEntryTest.kt
- M
navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavBackStackEntryState.android.kt
- M
navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavController.android.kt
- M
navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavDeepLinkBuilder.android.kt
- M
navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/NavController.kt
- M
navigation/navigation-runtime/src/nonAndroidMain/kotlin/androidx/navigation/NavController.nonAndroid.kt
- M
navigation/navigation-testing/src/androidMain/kotlin/androidx/navigation/testing/TestNavigatorState.android.kt
- M
navigation/navigation-ui/src/main/java/androidx/navigation/ui/NavigationUI.kt
Hash: 11b876fc10dec008f1f3b979795470f92ed4bb19
Date: Fri Mar 21 15:15:05 2025
98...@gmail.com <98...@gmail.com> #6
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Introduce AtomicInt
Expand for full commit details
Introduce AtomicInt
Adding a multi-platform AtomicInteger implementation and using it in
NavController.
Test: all tests pass
Bug: 403616316
Change-Id: I4126b3b9f946bd651afe06a242194e6f2d40302c
Files:
- M
navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavController.android.kt
- A
navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/internal/AtomicInt.android.kt
- A
navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/internal/AtomicInt.kt
- A
navigation/navigation-runtime/src/nonAndroidMain/kotlin/androidx/navigation/internal/AtomicInt.nonAndroid.kt
Hash: f6fe240b918e01ca382e741b728f43c068e3d9db
Date: Tue Mar 25 19:34:06 2025
al...@gmail.com <al...@gmail.com> #7
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Provide NavController implementation in common
Expand for full commit details
Provide NavController implementation in common
Adding a new internal NavControllerImpl to clean up NavController
implementation.
RelNote: N/A
Test: all tests pass
Bug: 403616316
Change-Id: I7aee97b1c3a497803534480cb10205fdf0455310
Files:
- M
navigation/navigation-common/bcv/native/current.txt
- M
navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavDestination.nonAndroid.kt
- M
navigation/navigation-runtime/bcv/native/current.txt
- M
navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavController.android.kt
- M
navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/NavController.kt
- A
navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/internal/NavControllerImpl.kt
- M
navigation/navigation-runtime/src/nonAndroidMain/kotlin/androidx/navigation/NavController.nonAndroid.kt
Hash: 08d41ac1a7d63948d9747e5572e9bc47e2c539d6
Date: Wed Mar 26 07:51:37 2025
pr...@gmail.com <pr...@gmail.com> #8
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Provide additional NavGraph and NavDestination APIs
Expand for full commit details
Provide additional NavGraph and NavDestination APIs
Adding a public int id and an internal getDisplayName to
NavDestination.
Adding startdestinationId and findNodeComprehensive to NavGraph.
RelNote: N/A
Test: all tests pass
Bug: 403616316
Change-Id: Idf3293890e4cd69f88aa4d72634c9be821663449
Files:
- M
navigation/navigation-common/bcv/native/current.txt
- M
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavDestination.android.kt
- M
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavGraph.android.kt
- M
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavDestination.kt
- M
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavGraph.kt
- M
navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavDestination.nonAndroid.kt
- M
navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavGraph.nonAndroid.kt
Hash: 5f335b3312dfb96723faa7b7c57e3981d13f40f3
Date: Wed Mar 26 07:45:00 2025
j....@gmail.com <j....@gmail.com> #9
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Provide internal multi-platform Log
Expand for full commit details
Provide internal multi-platform Log
Ensuring that we have the ability to log from common code. This only
takes over for info logs, other types of logs remain on the android
platform only.
Test: all tests pass
Bug: 403616316
Change-Id: I14b8b1e16cc7565b0789fd11bf85143fe0ed38d3
Files:
- M
navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavController.android.kt
- A
navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/internal/Log.android.kt
- A
navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/internal/Log.kt
- A
navigation/navigation-runtime/src/nonAndroidMain/kotlin/androidx/navigation/internal/Log.nonAndroid.kt
Hash: 55f9ec50929827a5becc445c22805be6f3d28950
Date: Tue Mar 25 20:22:11 2025
na...@gmail.com <na...@gmail.com> #10
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Provide popUpToId for NavOptions
Expand for full commit details
Provide popUpToId for NavOptions
Adding an expect for popUpToId and implementing it in nonAndroid
targets.
RelNote: N/A
Test: all tests pass
Bug: 403616316
Change-Id: I9a354359828786be54268096859bf8b3b35b51ac
Files:
- M
navigation/navigation-common/bcv/native/current.txt
- M
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavOptions.android.kt
- M
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavOptions.kt
- M
navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavOptions.nonAndroid.kt
Hash: b8a7d84a3201329cd33b11c12b2154b4a4215cf1
Date: Wed Mar 26 07:30:20 2025
vo...@hotmail.com <vo...@hotmail.com> #11
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Move all of NavBackStackEntryProvider to common
Expand for full commit details
Move all of NavBackStackEntryProvider to common
Adding expect/actual for WeakReference and UUID to move the entire
NavBackStackEntryProvider class to common.
Test: all tests pass
Bug: 403616316
Change-Id: I7e3b82e1788edd40e7a7cf92f3ec16c07f7e6bda
Files:
- M
navigation/navigation-compose/build.gradle
- D
navigation/navigation-compose/src/androidMain/kotlin/androidx/navigation/compose/NavBackStackEntryProvider.android.kt
- M
navigation/navigation-compose/src/androidMain/kotlin/androidx/navigation/compose/internal/NavComposeUtils.android.kt
- M
navigation/navigation-compose/src/commonMain/kotlin/androidx/navigation/compose/NavBackStackEntryProvider.kt
- M
navigation/navigation-compose/src/commonMain/kotlin/androidx/navigation/compose/NavHost.kt
- M
navigation/navigation-compose/src/commonMain/kotlin/androidx/navigation/compose/internal/NavComposeUtils.kt
- D
navigation/navigation-compose/src/nonAndroidMain/kotlin/androidx/navigation/compose/NavBackStackEntryProvider.nonAndroid.kt
- A
navigation/navigation-compose/src/nonAndroidMain/kotlin/androidx/navigation/compose/internal/NavComposeUtils.nonAndroid.kt
- D
navigation/navigation-compose/src/nonAndroidMain/kotlin/androidx/navigation/compose/internal/NavHostInternals.nonAndroid.kt
Hash: e59c45ab84ef047b9a5f455851f99a394cd30cbd
Date: Wed Mar 26 19:03:12 2025
ko...@gmail.com <ko...@gmail.com> #12
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Change the NavUri parse function
Expand for full commit details
Change the NavUri parse function
Changing the parseStringAsNavUri into more of a factory function.
Ideally this would be a function on a Compantion objects of NavUri, but
if we want to alias NavUri to android's Uri, this is not possible.
RelNote: "parseStringAsNavUri function has been changed to `NavUri`
function that takes a String."
Test: ./gradlew checkApi
Bug: 403616316
Change-Id: I4db6eeb13f86b3dbd987f9b55a49e9a45a8d0b38
Files:
- M
navigation/navigation-common/api/current.txt
- M
navigation/navigation-common/api/restricted_current.txt
- M
navigation/navigation-common/bcv/native/current.txt
- M
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavUri.kt
Hash: f353bd4db8d3ef6ea1d9fab22f8423e2217b69c0
Date: Mon Mar 24 04:02:30 2025
pi...@gmail.com <pi...@gmail.com> #13
Android API Change
This bug was referenced by a recent CL that changed the Android API surface area.
The
We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out if you'd like us to review it sooner.
Changes to navigation/navigation-common/api/current.txt
- androidx.navigation
- androidx.navigation.NavUriKt
[Gerrit:https://android-review.googlesource.com/3555747]
[API-Approvers:
[Branch:androidx-main]
[LIBRARY_API_REVIEW_TAG:navigation/navigation-common/api/current.txt]
th...@gmail.com <th...@gmail.com> #14
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Fix NavUri call
Expand for full commit details
Fix NavUri call
This function was parseStringAsNavUri and now is just NavUri.
Test: all tests pass
Bug: 403616316
Change-Id: I16d4fe29a85ee825935480674ec3f1edd4a49a29
Files:
- M
navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/internal/NavControllerImpl.kt
Hash: 941f6ed079da0acc34ff5053206d221eb6b660ec
Date: Fri Mar 28 00:55:28 2025
ma...@gmail.com <ma...@gmail.com> #15
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Provide NavBackStackEntryImpl class for common
Expand for full commit details
Provide NavBackStackEntryImpl class for common
Moving all eligible code to the common source set and exposing it to the
android and nonAndroid specific implementations via an
NavBackStackEntryImpl class.
RelNote: "The AndroidX Navigation library now provides a nonAndroid
implementation for NavBackStackEntry"
Test: all tests pass
Bug: 403616316
Change-Id: I57547cfc013b0ded47e9719afa433c1d8244c6b5
Files:
- M
navigation/navigation-common/bcv/native/current.txt
- M
navigation/navigation-common/build.gradle
- M
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavBackStackEntry.android.kt
- M
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavBackStackEntry.kt
- A
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/internal/NavBackStackEntryImpl.kt
- M
navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavBackStackEntry.nonAndroid.kt
Hash: 5a80707e8348ea92b8b71d66f78b145a0f94ae02
Date: Fri Mar 28 02:12:56 2025
ed...@gmail.com <ed...@gmail.com> #16
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Implement NavDeepLinkRequest in common
Expand for full commit details
Implement NavDeepLinkRequest in common
Moving all of the NavDeepLinkRequest to common.
RelNote: N/A
Test: all tests pass
Bug: 403616316
Change-Id: I791195c7e73f745f9212ffee37cb3616c602c5ac
Files:
- M
navigation/navigation-common/bcv/native/current.txt
- D
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavDeepLinkRequest.android.kt
- M
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavDeepLinkRequest.kt
- D
navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavDeepLinkRequest.nonAndroid.kt
- M
navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavController.android.kt
Hash: 610e71c06b4b10c8e6543fbb3dbcae4d65ca61ea
Date: Wed Apr 02 02:14:30 2025
gu...@gmail.com <gu...@gmail.com> #17
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Provide NavGraphImpl
Expand for full commit details
Provide NavGraphImpl
Moving all common code to the common source set and allowing the
specific platforms to use that source.
RelNote: N/A
Test: all tests pass
Bug: 403616316
Change-Id: If77617d32d274ea2f5f76107336293b562fda300
Files:
- M
navigation/navigation-common/bcv/native/current.txt
- M
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavGraph.android.kt
- A
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/internal/NavGraphImpl.kt
- M
navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavGraph.nonAndroid.kt
Hash: 162602b9a59566b2f341aea043de202b72fccbed
Date: Wed Apr 02 01:40:22 2025
sh...@gmail.com <sh...@gmail.com> #18
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Provide NavDestinationImpl
Expand for full commit details
Provide NavDestinationImpl
Moving all common code to the common source set and allowing the
specific platforms to use that source.
RelNote: N/A
Test: all tests pass
Bug: 403616316
Change-Id: Ia7ea5ba90d98353147c710bc43780e120f608c84
Files:
- M
navigation/navigation-common/bcv/native/current.txt
- M
navigation/navigation-common/build.gradle
- M
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavDestination.android.kt
- M
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavDestination.kt
- A
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/internal/NavDestinationImpl.kt
- M
navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavDestination.nonAndroid.kt
- M
navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/internal/NavContext.nonAndroid.kt
Hash: 3c59943b0caac826903b5cbc5d033b69ab0c3b5c
Date: Fri Mar 28 03:56:37 2025
em...@gmail.com <em...@gmail.com> #19
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Move Navigator to common
Expand for full commit details
Move Navigator to common
There is no platform specific code in Navigator.
RelNote: N/A
Test: all tests pass
Bug: 403616316
Change-Id: I28c3cec15401a458124ee8e209d88fb807435fa6
Files:
- M
navigation/navigation-common/bcv/native/current.txt
- D
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/Navigator.android.kt
- M
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/Navigator.kt
- D
navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/Navigator.nonAndroid.kt
Hash: 0ed3a0167619b3af5eabd1e167936ad6acd8dc46
Date: Wed Mar 26 19:59:07 2025
mo...@gmail.com <mo...@gmail.com> #20
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Move noOpNavigator to common
Expand for full commit details
Move noOpNavigator to common
Moving the implementation of the NoOpNavigator to the common source set
and deleting the platform specific versions.
RelNote: n/a
Test: all tests pass
Bug: 403616316
Change-Id: I6cae3b46879633059eb50d768819cafb7de95cb6
Files:
- D
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NoOpNavigator.android.kt
- M
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NoOpNavigator.kt
- D
navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NoOpNavigator.nonAndroid.kt
Hash: fa6cc966c5fa9773f8c1a5610b0f9252f5fb18f4
Date: Thu Mar 27 00:16:35 2025
lu...@gmail.com <lu...@gmail.com> #21
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Move ComposeNavGraphNavigator to common
Expand for full commit details
Move ComposeNavGraphNavigator to common
Moving the implementation of the ComposeNavGraphNavigator to the common source set
and deleting the platform specific versions.
RelNote: n/a
Test: all tests pass
Bug: 403616316
Change-Id: Id01ca3d5db0399c61cba4588f67668213cc5af4b
Files:
- D
navigation/navigation-compose/src/androidMain/kotlin/androidx/navigation/compose/ComposeNavGraphNavigator.android.kt
- M
navigation/navigation-compose/src/commonMain/kotlin/androidx/navigation/compose/ComposeNavGraphNavigator.kt
- D
navigation/navigation-compose/src/nonAndroidMain/kotlin/androidx/navigation/compose/ComposeNavGraphNavigator.nonAndroid.kt
Hash: d41eac2e40be89122d8204321e48e49cd1791f81
Date: Wed Apr 02 05:36:30 2025
mo...@gmail.com <mo...@gmail.com> #22
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Move ClassType to common
Expand for full commit details
Move ClassType to common
Even though ClassType is only used by tools, we should still provide an
equal level of support on the Android side. Moving this to common allow
us to keep this around for other Navigation implementations that are in
Common.
RelNote: N/A
Test: ./gradlew checkApi
Bug: 403616316
Change-Id: I81efc0571178051fe9ef7ee00fab37378b271876
Files:
- M
navigation/navigation-common/bcv/native/current.txt
- M
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavDestination.android.kt
- M
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavDestination.kt
- M
navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavDestination.nonAndroid.kt
Hash: 58806860cf5cd0eb2ffd4a0886b56b2e48587aa8
Date: Wed Apr 02 21:42:19 2025
bj...@gmail.com <bj...@gmail.com> #23
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Move NavGraphNavigator to common
Expand for full commit details
Move NavGraphNavigator to common
Moving the implementation of the NavGraphNavigator to the common source set
and deleting the platform specific versions.
RelNote: n/a
Test: all tests pass
Bug: 403616316
Change-Id: Id28c449a52d14e2df101db25ded4d8e428c37c80
Files:
- M
navigation/navigation-common/bcv/native/current.txt
- D
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavGraphNavigator.android.kt
- M
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavGraphNavigator.kt
- D
navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavGraphNavigator.nonAndroid.kt
Hash: a011b3bc23a80d510086701719d9a1ed88d7a15d
Date: Wed Apr 02 05:22:24 2025
st...@gmail.com <st...@gmail.com> #24
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Move DialogNavigator to common
Expand for full commit details
Move DialogNavigator to common
Moving the implementation of the DialogNavigator to the common source set
and deleting the platform specific versions.
RelNote: n/a
Test: all tests pass
Bug: 403616316
Change-Id: Iaa801c14d263d7f372dabdc6e08c80d15926ed5b
Files:
- D
navigation/navigation-compose/src/androidMain/kotlin/androidx/navigation/compose/DialogNavigator.android.kt
- M
navigation/navigation-compose/src/commonMain/kotlin/androidx/navigation/compose/DialogNavigator.kt
- D
navigation/navigation-compose/src/nonAndroidMain/kotlin/androidx/navigation/compose/DialogNavigator.nonAndroid.kt
Hash: cc99a247b36eeacb363a87d379bea7da32a86d31
Date: Wed Apr 02 05:51:40 2025
na...@gmail.com <na...@gmail.com> #25
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Move ComposeNavigator to common
Expand for full commit details
Move ComposeNavigator to common
Moving the implementation of the ComposeNavigator to the common source set
and deleting the platform specific versions.
RelNote: n/a
Test: all tests pass
Bug: 403616316
Change-Id: I76f5ed06735867797b42cc22ef1efcf072200f5f
Files:
- D
navigation/navigation-compose/src/androidMain/kotlin/androidx/navigation/compose/ComposeNavigator.android.kt
- M
navigation/navigation-compose/src/commonMain/kotlin/androidx/navigation/compose/ComposeNavigator.kt
- D
navigation/navigation-compose/src/nonAndroidMain/kotlin/androidx/navigation/compose/ComposeNavigator.nonAndroid.kt
Hash: 27fca1659aa6ae2f085c758cb939e5990e3d8fc2
Date: Wed Apr 02 05:43:44 2025
ma...@gmail.com <ma...@gmail.com> #26
This has been completed and will be available in Navigation 2.9.0-beta01.
vi...@google.com <vi...@google.com> #27
Our engineering team is still working on this issue. We will provide more updates as they become available.
fc...@gmail.com <fc...@gmail.com> #28
sa...@google.com <sa...@google.com>
pi...@hotmail.com <pi...@hotmail.com> #29
honestly android drivers should be taking control of the DAC volume on hardware level like it happens when you plug them to windows devices instead of software volume control
es...@gmail.com <es...@gmail.com> #30
mt...@gmail.com <mt...@gmail.com> #31
still same issue
samsung s21 fe (android 13)
ra...@gmail.com <ra...@gmail.com> #33
Works fine on my:
a) Apple iPad Air 5 running iPadOS 17
b) Dell XPS 9550 running Windows 11
Craps out on my:
Google Pixel 7a running Android 14
Please don't tell me that Apple and even Microsoft write better drivers... and get this bug finally fixed!
go...@gmail.com <go...@gmail.com> #34
al...@gmail.com <al...@gmail.com> #35
dj...@grailbio.com <dj...@grailbio.com> #36
be...@gmail.com <be...@gmail.com> #37
ra...@gmail.com <ra...@gmail.com> #38
lo...@gmail.com <lo...@gmail.com> #39
ya...@gmail.com <ya...@gmail.com> #40
rs...@gmail.com <rs...@gmail.com> #41
The bug has been open for 1.5 years and likely requires a just few lines of code at max. Fix it.
pe...@gmail.com <pe...@gmail.com> #42
ze...@gmail.com <ze...@gmail.com> #43
lu...@gmail.com <lu...@gmail.com> #44
Until now i have just compiled and flashed a custom kernel to fix the issue.
But when doing that, the device fails play integrity checks of course.
So now you also need to root etc. it to atleast pass basic attestation.
I have reported this bug over a year ago, it is ridiculous that there is still no proper fix and no developer option to atleast be able to set the volume manually.
Maybe consider that not all people can or want to use wireless headphones for a variety of reasons.
I'm at a point where i probably will just get a phone with headphone jack (with the only higher end option being the Asus Zenfone) or switch to team Apple.
se...@gmail.com <se...@gmail.com> #45
handling in Pixels is really a joke.
But for the record, USB Audio Player seems to solve most issues, including
this one, as you can directly control the hardware volume via the app:
being forced to use a specific app is not great either, but if you're
already a Pixel owner, it's cheaper than buying a new phone.
On Sat, 11 Nov 2023, 14:46 , <buganizer-system@google.com> wrote:
lu...@gmail.com <lu...@gmail.com> #46
al...@gmail.com <al...@gmail.com> #47
lu...@gmail.com <lu...@gmail.com> #48
ra...@gmail.com <ra...@gmail.com> #49
lu...@gmail.com <lu...@gmail.com> #50
mi...@gmail.com <mi...@gmail.com> #51
gr...@gmail.com <gr...@gmail.com> #52
gr...@gmail.com <gr...@gmail.com> #53
je...@gmail.com <je...@gmail.com> #54
ra...@gmail.com <ra...@gmail.com> #55
I guess all we can do is to refer to this issue here on every social media, forum, YouTube channel… and ask people to upvote….
an...@gmail.com <an...@gmail.com> #56
an...@gmail.com <an...@gmail.com> #57
fi...@gmail.com <fi...@gmail.com> #58
30...@gmail.com <30...@gmail.com> #59
co...@gmail.com <co...@gmail.com> #60
pixel 6a
da...@gmail.com <da...@gmail.com> #61
da...@gmail.com <da...@gmail.com> #62
I had the same issue on my S21 and solved it by using the free Neutron app for Android. The problem is probably that Android outputs only 0.5V instead of 1.0V because of some miscommunication. Neutron can use the full power but does not work with streaming platforms. I think it initializes the dongle with 1.0V, then stays at 1.0V even if the Neutron is not running anymore.
Plug in the Apple dongle
Neutron asks if I want to use the Neutron app for audio, I press 2 times yes
I close the Neutron app
I go to, for example, Spotify
Then Neutron asks me again, but now I decline both (It does not work with Spotify...)
voila, full volume everywhere
jb...@gmail.com <jb...@gmail.com> #63
Also testing 3.5mm jack vs. USB-C with dongle (same apple wired earbuds) on my old Pixel 3a XL, and the volume is waaay lower using USB-C. Tried the Neutron fix, and I can eventually get it to work (though clunky), but the free app dies after 5 days and this just feels like something that should just work.
These devices are all crippled now with the loss of the headphone jack, and the USB-C implementation is buggy, so these phones are not usable as phones, which is ridiculous.
This is my third Pixel and while it's a great phone, it should more usable as a phone.
Google, Fix This!!
we...@gmail.com <we...@gmail.com> #64
Would love to see the Android hardware volume issue fixed.
It will surely increase the range of hardware that can be used with Android devices.
mi...@gmail.com <mi...@gmail.com> #65
I managed to turn up a little but the volume of the microphone with "tinymix" but it is not perfect and I have to do it each time I plug the dongle... plus I need root access.. It would be possible to modify the android image to do this operation each a dongle is plugged...
lu...@gmail.com <lu...@gmail.com> #66
For automate + rinymix, you need root, for custom kernel you don't.
ta...@gmail.com <ta...@gmail.com> #67
ta...@gmail.com <ta...@gmail.com> #68
ra...@gmail.com <ra...@gmail.com> #69
… not even a single response from Google …
Not even a we’re working on it or we’re currently testing a fix, hoping to include it in next release or even a simple “won’t fix it, buy an iPhone you audiophiles”
ni...@gmail.com <ni...@gmail.com> #70
kk...@gmail.com <kk...@gmail.com> #71
al...@gmail.com <al...@gmail.com> #72
re...@gmail.com <re...@gmail.com> #73
br...@gmail.com <br...@gmail.com> #74
jg...@gmail.com <jg...@gmail.com> #75
dn...@gmail.com <dn...@gmail.com> #76
an...@gmail.com <an...@gmail.com> #77
ga...@gmail.com <ga...@gmail.com> #78
cl...@gmail.com <cl...@gmail.com> #79
da...@gmail.com <da...@gmail.com> #80
its outrageous that compatiblity is not assured with DAC adapters
ki...@gmail.com <ki...@gmail.com> #81
tb...@gmail.com <tb...@gmail.com> #82
ba...@gmail.com <ba...@gmail.com> #83
ps...@gmail.com <ps...@gmail.com> #84
sw...@gmail.com <sw...@gmail.com> #85
Only thing people see this as their phones no longer working correctly with adapters, not an apple issue. How is this still a problem?
From my personal experience issue is with every samsug galaxy phone from the past 3 years, every pixel phone from the last 3 years, a few sony phones, and literally any android tablet.
Frequency is 100% of the time.
br...@gmail.com <br...@gmail.com> #86
jj...@gmail.com <jj...@gmail.com> #87
pr...@gmail.com <pr...@gmail.com> #88
ra...@gmail.com <ra...@gmail.com> #89
na...@gmail.com <na...@gmail.com> #90
Please fix this
cz...@gmail.com <cz...@gmail.com> #91
ni...@gmail.com <ni...@gmail.com> #92
How long do y'all intend to ignore this issue? If there's no fix coming, please say so. I figured Google wouldn't be so content with Android being unable to handle wired headphones of all things.
an...@gmail.com <an...@gmail.com> #93
em...@gmail.com <em...@gmail.com> #94
jo...@gmail.com <jo...@gmail.com> #95
ra...@gmail.com <ra...@gmail.com> #96
A company that cares about audiophiles…
sh...@gmail.com <sh...@gmail.com> #97
Kernel Fix :-
Fix for Rooted Devices :-
[You Can Also use Alsamixer(root) which I used to use earlier, Link :-
Fix for Non-rooted Devices :- UAPP, Neutron Music Player, Hiby Music Player. (This is the only fix I have found yet for non-rooted devices, It was getting annoying so I had to root my device.)
For root I am using KernelSU. My Device is Nothing Phone (2a).
in...@gmail.com <in...@gmail.com> #98
co...@gmail.com <co...@gmail.com> #99
le...@60228.dev <le...@60228.dev> #100
With Android 14 adding support for hardware volume control to the USB audio HAL, I think a simple fix could be to change
if ((flags & AUDIO_OUTPUT_FLAG_BIT_PERFECT) != AUDIO_OUTPUT_FLAG_NONE) {
out_stream_find_mixer_volume_control(out, device_info->profile.card);
}
to
out_stream_find_mixer_volume_control(out, device_info->profile.card);
out_set_volume(&out->stream, 1.0, 1.0);
if ((flags & AUDIO_OUTPUT_FLAG_BIT_PERFECT) == AUDIO_OUTPUT_FLAG_NONE) {
out->volume_ctl = NULL; // FIXME: is this necessary?
}
I don't understand the codebase well enough to know if this is the best approach, though, and I don't have an Android build environment set up to easily test this.
ma...@gmail.com <ma...@gmail.com> #101
mt...@gmail.com <mt...@gmail.com> #102
do...@gmail.com <do...@gmail.com> #103
ar...@gmail.com <ar...@gmail.com> #104
j9...@gmail.com <j9...@gmail.com> #105
ma...@gmail.com <ma...@gmail.com> #106
nu...@gmail.com <nu...@gmail.com> #107
cr...@gmail.com <cr...@gmail.com> #108
uf...@gmail.com <uf...@gmail.com> #109
There are solutions, plenty of workarounds and it's been more than two years now.
Be a *Hero* and sort up the code, eh?
🦄
ma...@gmail.com <ma...@gmail.com> #110
Was surprised I HAD to buy an active adapter with a DAC for my pixel in the first place, as my old normal adapter didn't work anymore, was even more disappointed when the new adapter's maxed volume was like 30% of what the max volume used to be with my old phone+simple adapter.
Then tried the workarounds here and they worked, how the hell has such a simple bug not been fixed in YEARS?!
an...@gmail.com <an...@gmail.com> #111
sa...@gmail.com <sa...@gmail.com> #112
de...@gmail.com <de...@gmail.com> #113
an...@gmail.com <an...@gmail.com> #114
When I install Neutron Player from the Play Store the maximum playback volume on the headphones is the same as vie Bluetooth when I set Neutron Player to have direct access to the USB device and to bypass the OS.
I do not have this issue when using a Google USB-C to 3.5mm audio jack converter and a pair of OneOdio Bluetooth headphones with a 3.5mm audio jack socket.
fr...@googlemail.com <fr...@googlemail.com> #115
LineageOS 21 / Android 14 on Pixel 6a
Please, I love my Porta Pros :)
mt...@gmail.com <mt...@gmail.com> #116
it is been 2 years
ra...@gmail.com <ra...@gmail.com> #117
je...@gmail.com <je...@gmail.com> #118
ka...@baastrup.org <ka...@baastrup.org> #119
da...@gmail.com <da...@gmail.com> #120
OR EVEN BETTER.
GIVE US THE JACK CONNECTOR BACK!
uf...@gmail.com <uf...@gmail.com> #121
For everyone experiencing his utter train crash of priorities, there is (kind of) a *WORKAROUND*
Works on Samsung Galaxy S20 Fe (SM-G780G/DS) and the standard cheap Apple USB C Audio Dac.
1. Download and install "HiBy Music"
Avaliable on playstore:
<
2. With your Dac plugged in, go to "Settings" and toggle "Exclusive HQ USB audio access". Agree to the warning prompt and then toggle the setting off again.
This workaround enables full volume from my cheap Apple USB Dac.
Hope it works for y'all too!
Sidenot this sets the Usb Dac hardware volume to what it should be. Why the devs have made an active decision to not fix this is beyond me. Seriously considering going Apple after this...
mt...@gmail.com <mt...@gmail.com> #122
Only way I found out
I purchased usb audio pro
When I connect dongle I get pop up of this app and when It gets opened i increase the volume (there is hardware volume option in it) and close the app.
Then volume is increased system wide
ro...@gmail.com <ro...@gmail.com> #123
Kindly update us.
uk...@gmail.com <uk...@gmail.com> #124
Kindly asking to take this into fixing
an...@gmail.com <an...@gmail.com> #125
Thanks!
vi...@gmail.com <vi...@gmail.com> #126
UAPP has "captured a market" that never needed to exist in the first place, and profited off of Google's incompetence.
The Apple dongle still has lower volume than it is capable of, due to a few lines of code. It is shameful.
For anyone considering buying the Apple dongle; don't. There is now a huge market of USB DAC/Amps. I particularly recommend looking for the keyword "CX31993" and buying whichever dongle you find. It will always be louder than the Apple dongle.
I wasted my money buying UAPP and Google won't even refund me for it.
lu...@gmail.com <lu...@gmail.com> #127
kd...@gmail.com <kd...@gmail.com> #128
og...@gmail.com <og...@gmail.com> #129
de...@gmail.com <de...@gmail.com> #130
kr...@googlemail.com <kr...@googlemail.com> #131
Works also with Spotify, so it finally became enjoyable in an overloaded public bus again.
lu...@gmail.com <lu...@gmail.com> #132
ch...@gmail.com <ch...@gmail.com> #133
Around 20dB to low, with max Volume, on a -10dB LineInput. Even there are distorted Peaks at max Volume.
ur...@gmail.com <ur...@gmail.com> #134
And I already regret that I bought that Pixel 9 Pro without 3.5mm Jack.
1. Volume issues with USB-DACs
2. In-line Controls no working
3. Apps that fixed 2.) aren't on Play Store anymore and APK not compatible with Android 15
All that together makes the Pixel 9 Pro unuseable for listening Music for me.
I can't understand that Google don't fix those years old bugs.
And I also don't understand why you still need third party apps for in-line controls.
But perhaps it's on purpose so that I buy a iPhone next time... xD
ra...@gmail.com <ra...@gmail.com> #135
Patch is not yet available in my region but does anyone know if they bothered fixing this bug while updated the USB-Audio code?
Shame on Google...
Description
Since android uses software volume control and never touches the hardware volume of USB DACs, the expected behaviour should be to set the hardware volume of USB DACs to the maximum possible value (e.g. in kernel/sound/usb/mixer.c, at some point do snd_usb_set_cur_mix_value(cval, [channel no.], [index no.], cval->max) ) to use the entire supported volume range of the DAC.