Fixed
Status Update
Comments
na...@google.com <na...@google.com> #2
This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.
gh...@google.com <gh...@google.com> #3
Almost 2 months later and this is still broken
gh...@google.com <gh...@google.com> #4
Since there is no progression, I wanted to share our quick-fix for the issue.
#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages
#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages
Description
The comment on the
reformat
method ofLintFix.ReplaceStringBuilder
says it determines "whether the replaced range should be reformatted". However, settingreformat
totrue
causes the entire file to be reformatted when a fix is applied, not just the replaced range. Is it possible to limit the scope of the reformatting to just the replaced range?For context, we have an AndroidX lint check,
ClassVerificationFailureDetector
, that inserts an inner class. It would be nice to have the inserted code reformatted, as it generally has indentation issues that need to be manually fixed. However, reformatting the entire file can cause many changes, which can make it difficult for the person applying the fix and code reviewer to check all the diffs, and sometimes they aren't wanted for a particular file.