Migrate from destination property to outputLocation property to address deprecation warning and prepare for Gradle 9.0 [242831042]

Fixed

Bug

Status Update

No update yet.

Description

tt...@gradle.com

created issue #1

Aug 17, 2022 02:13PM

Gradle is removing some @Deprecated methods from the org.gradle.api.reporting.ConfigurableReport class in Gradle 8.0. One method that is remaining is setDestination(File), which is still used by tasks created by AGP. All of Gradle's internal implementation classes for this interface (anything which ultimately extends org.gradle.api.reporting.internal.SimpleReport) will begin producing nagging deprecation warnings when this method is called.

Per the javadoc on that method, please switch to using the outputLocation property to avoid these warnings and prepare for it's removal in Gradle 9.0.

Comments

ag...@google.com <ag...@google.com> Aug 17, 2022 04:05PM

Assigned to an...@google.com.

ga...@google.com <ga...@google.com> #2Aug 18, 2022 11:53AM

Reassigned to bi...@google.com.

Gradle issue asking for it to be made easier to avoid making an unused modification to this list: https://github.com/gradle/gradle/issues/22671

bi...@google.com <bi...@google.com> Aug 18, 2022 10:24PM

Accepted by bi...@google.com.

bi...@google.com <bi...@google.com> #3Sep 28, 2022 12:10AM

I think the issue here is that jvmArgs is null, which causes addAll() to not run.

IMO we should be adding to jvmArgs and not replacing it entirely, in case something else has previously set jvmArgs. WYT @Ivan?

I could change it to something like

forkOptions.jvmArgs?.addAll(executionOptions.get().jvmArgs) ?: forkOptions.jvmArgs(executionOptions.get().jvmArgs)

tt...@gradle.com <tt...@gradle.com> #4Sep 28, 2022 06:53PM

Yeah, the nullness of jvmArgs was the first possibility I checked too, although even with "!!" it still had no effect, see https://github.com/gradle/gradle/issues/22671

I uploaded a change that I observed to fix it for me and added you as a reviewer

bi...@google.com <bi...@google.com> #5Sep 28, 2022 06:58PM

Ah, ok, that makes sense.

bi...@google.com <bi...@google.com> #6Sep 28, 2022 08:56PM

Marked as fixed.

Thanks for the change, Jeff!

Should we cherry-pick it into 7.4? I think AGP 7.4 has that but the settings plugin is not officially supported yet.