[Feature Request] SwipeToDismiss for Material 3 [242889540]

Fixed

Bug

Status Update

No update yet.

Description

de...@gmail.com

created issue #1

Aug 17, 2022 07:18PM

Feature Request to add SwipeToDismiss to Compose for Material 3, as it is not recommended to use material components in a Material 3 project according to this ticket.

Comments

ra...@gmail.com <ra...@gmail.com> #2Aug 26, 2022 09:56AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

de...@gmail.com <de...@gmail.com> #3Oct 8, 2022 06:29PM

Hello, is there any roadmap for this, or any info on when it is likely to be implemented?

jo...@google.com <jo...@google.com> #4Oct 10, 2022 06:54AM

Hi, similarly to (modal) bottom sheets, we are working on the underlying APIs. Jose, do you have a rough timeline to share?

jo...@google.com <jo...@google.com> Oct 10, 2022 08:11AM

Reassigned to se...@google.com.

de...@gmail.com <de...@gmail.com> #5Oct 10, 2022 09:50AM

So the animation APIs are currently the blocking point?
Is the mentioned issue correct?

Ok, I thought you were much further ahead because the first release candidate was published. :D

sy...@gmail.com <sy...@gmail.com> #6Oct 13, 2022 06:43AM

Hi, how does it look with SwipeToDismiss for M3? Only this force me to use complete M3 lib. Please can somebody point me how to use SwipeToDismiss in M3? Thanks

se...@google.com <se...@google.com> Oct 18, 2022 06:35PM

Assigned to se...@google.com.

se...@google.com <se...@google.com> Oct 21, 2022 05:13PM

Accepted by se...@google.com.

gl...@gmail.com <gl...@gmail.com> #7Nov 3, 2022 10:19PM

⌛ Waiting...

se...@google.com <se...@google.com> #8Nov 8, 2022 03:27PM

In progress : )

ma...@quantox.com <ma...@quantox.com> #9Dec 2, 2022 09:28AM

Question for Google devs: I see Pull-To-Refresh component has been added to Material2 but NOT Material3, so I'm wondering what is an actual priority and future development plan for these 2 libraries? As someone who started a project on Material3, and already missing both BottomSheet and now a Pull-To-Refresh component, I'm really second guessing my choices and wondering if even future projects should be started on Material3, since even NEW stuff is being implemented on Material2..

So the question is, should we actually be starting new projects on Material3 or not? It's even "final" now. And is it really more future proof from the project maintenance perspective?

ap...@google.com <ap...@google.com> #10Dec 5, 2022 01:44PM

Project: platform/frameworks/support
Branch: androidx-main

commit e6892a2153fca43e348b0de7c2614e7bf6cbc708
Author: José Figueroa <serniebanders@google.com>
Date: Tue Nov 01 10:38:11 2022

[Material3][SwipeToDismiss] Update Swipe To Dismiss to M3 library

Updates:
* Threshold calculation simplified and moved to DismissState.
* SwipeableState inheritance moved internally, with relevant parameters exposed to DismissState API.
* Splits more complex demo and simple sample code logic.

Test: Forked M2 Unit Tests
Bug: 242889540
RelNote: Implement SwipeToDismiss in Material 3 library.
Change-Id: I458a8e1359896712a2a8aede43e0283977be4601

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/integration-tests/material3-demos/src/main/java/androidx/compose/material3/demos/Material3Demos.kt
A compose/material3/material3/integration-tests/material3-demos/src/main/java/androidx/compose/material3/demos/SwipeToDismissDemo.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/SwipeToDismissSamples.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/SwipeToDismissTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SwipeToDismiss.kt

https://android-review.googlesource.com/2282010

se...@google.com <se...@google.com> #11Dec 5, 2022 01:58PM

Marked as fixed.

@marko I can't speak to the PullToRefresh feature as I've not worked on it, but to generally answer your question: I would say that is ultimately your call to make. Personally I would recommend using Material3, as it has a longer window of active development (feature requests, bug fixes, other dev time resources) while the goal is to sunset M2 support over time. However M2 is of course more feature complete at this time.

PullToRefresh is not currently on the M3 radar however you are welcome to file a feature request.

Message last modified on Dec 5, 2022 02:28PM

de...@gmail.com <de...@gmail.com> #12Dec 5, 2022 02:15PM

@se...@google.com maybe not so good to post the full mail here?

na...@google.com <na...@google.com> #13Jan 11, 2023 08:12PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.1.0-alpha04