IssueTracker

Steps to reproduce

To reproduce the bug, you need a SwipeRefreshLayout which contains a RecyclerView, and some of the RecyclerView items have nested RecyclerView.

1. Enable SwipeRefreshLayout by setting setEnabled(true)
2. Scroll the nested RecyclerView
3. Disable SwipeRefreshLayout by setting setEnabled(false)
4. Perform a pull-to-refresh gesture

Expected behavior

SwipeRefreshLayout become disabled, pull-to-refresh gesture is ignored, circle spinner view does not appear

Actual behavior

SwipeRefreshLayout become disabled (as isEnabled() returns false), but it still handles pull-to-refresh gesture, circle spinner view appear (moreover, it will not disappear unless explicitly called setRefreshing(false)).

Only the first pull-to-refresh gesture is handled, the following are ignored as expected.

Additional information

Artifact used:

• androidx.swiperefreshlayout:swiperefreshlayout:1.1.0 with androidx.recyclerview:recyclerview:1.2.1 (sample project)
• androidx.swiperefreshlayout:swiperefreshlayout:1.1.0 with androidx.recyclerview:recyclerview:1.2.0 (production project where the bug was noticed)

Devices/Android versions reproduced on:

• realme 8 Pro 6/128 GB (RMX3081), Android 12
• x86 Android emulators within Android Studio (Android 12, Android 8.1)

References

• MRE, a project that reproduces the bug (GitHub)
• Screenrecord (Google Drive)

Some research

Looks like there are some problems with nested scroll, as SwipeRefreshLayout#onTouchEvent is not called, and SwipeRefreshLayout#onNestedScroll is called when the first pull-to-refresh gesture is performed. The following gestures does not trigger SwipeRefreshLayout#onNestedScroll.