Status Update
No update yet.
Comments
ya...@google.com
bo...@google.com
r....@gmail.com
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
wd...@google.com
wd...@google.com
wd...@google.com
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
wd...@google.com
Ranjit is also able to repro the issue on Windows with Intel CPU. The problem is essentially in the first network connection. I asked Ranjit to help me with bisection mentioned in #3.
ra...@google.com
Time taken to show the Gmail Sign In page when AVD launched in embedded mode (Used Pixel_4a_API_31)
- Emulator Version : 31.3.9-8716652 about 17 seconds
- Emulator Version : 31.3.10-8779787 about 18 seconds
- Emulator Version : 31.3.10-8803787 about 20 seconds
wd...@google.com
RE#6 Thanks Ranjit for helping out with bisecting. I think the issue probably existed before I checked in the network related CLs. We will keep bisecting.
wd...@google.com
According to ranjitkumar@, "It took about 28 seconds with Emulator version 31.3.6-8376731 and It took about 35 seconds for me with Emulator version 31.2.10-8420304" So we are probably chasing down a problem that might just be lingering for very long time.
And our observation is somewhat contradictory to what the user had reported because they believe it's a regression from 31.2.10.
wd...@google.com
wd...@google.com
@ranjitkumar
Here is the verification steps for this bug.
Host Operating System: Windows 10
Set up: Disable ipv6 manually in Windows by referring to the
Repro step: 1, Create AVD with API 31 and wipe data before each run.
2, Run AVD and make sure it is cold boot.
3, Immediately after the device boot completes, go to Gmail or Google and try to load the Google Sign In page.
4, Google Sign In page should take more than 1 minute to load for the buggy version (32.3.10).
Google Sign in page should take less than 20 seconds for the new version (with fix in
ra...@google.com
Thanks for the steps Weilun.
When I tried to load the sign in page after disabling the ipV6 manually it takes more than 2 minutes for the sign in page to show up with stable Emulator 31.3.10.
I will verify the fix in the upcoming Emulator build.
ra...@google.com
It takes about 20 seconds for the Gmail sign in page to show up on AVD(Pixel_4a_API_31) with Emulator 31.3.11-9032202 using ipv4 in stand alone mode.
OS : Windows 10
jb...@gmail.com
128RM 8
Description
Android Studio Version: Unknown
Emulator Version (Emulator--> Extended Controls--> Emulator Version): 31.3.10-8807927
HAXM / KVM Version: gvm 65544.0.0
Android SDK Tools: 26.1.1
Host Operating System: Windows 10 Enterprise LTSC 2021
CPU Manufacturer: AMD CPU
Virtualization is supported
64-bit CPU
RAM: 32692 MB
GPU: GPU #1
Make: 1002
Model: Radeon (TM) RX 480 Graphics
Device ID: 67df
Build Fingerprint:
AVD Details: Name: Pixel_5_API_30
CPU/ABI: x86
Path: C:\Users\Tom\.android\avd\Pixel_5_API_30.avd
Target: google_apis [Google APIs] (API level 30)
Skin: pixel_4
SD Card: 512M
AvdId: Pixel_5_API_30
PlayStore.enabled: false
avd.ini.displayname: Pixel 5 API 30
avd.ini.encoding: UTF-8
disk.dataPartition.size: 6442450944
fastboot.chosenSnapshotFile:
fastboot.forceChosenSnapshotBoot: no
fastboot.forceColdBoot: no
fastboot.forceFastBoot: yes
hw.accelerometer: yes
hw.arc: false
hw.audioInput: yes
hw.battery: yes
hw.camera.back: virtualscene
hw.camera.front: emulated
hw.cpu.ncore: 4
hw.dPad: no
hw.device.hash2: MD5:3274126e0242a0d86339850416b0ce34
hw.device.manufacturer: Google
hw.gps: yes
hw.gpu.enabled: yes
hw.gpu.mode: auto
hw.initialOrientation: Portrait
hw.keyboard: yes
hw.lcd.density: 440
hw.lcd.height: 2340
hw.lcd.width: 1080
hw.mainKeys: no
hw.ramSize: 1536
hw.sdCard: yes
hw.sensors.orientation: yes
hw.sensors.proximity: yes
hw.trackBall: no
image.sysdir.1: system-images\android-30\google_apis\x86\
runtime.network.latency: none
runtime.network.speed: full
showDeviceFrame: yes
skin.dynamic: yes
tag.display: Google APIs
vm.heapSize: 256
Steps to Reproduce Bug:network speed is too slow
Expected Behavior:
Observed Behavior: