Expose consumed inset values to modifiers [243119659]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Aug 19, 2022 08:01PM

Jetpack Compose version: 1.2.0

Jetpack Compose component(s) used: foundation

I have custom modifiers that would like to know which insets have been consumed by other insets padding modifiers or consumedWindowInsets, so they don't double apply.

If ModifierLocalConsumedWindowInsets was public then I could use ModifierLocalConsumer. Alternatively, some Modifier extension function which passes the consumed WindowInsets as an argument would be nice:

fun Modifier.withConsumedWindowInsets(
  factory: @Composable Modifier.(consumed: WindowInsets) -> Modifier
) {
  // ...
}

Comments

ma...@google.com <ma...@google.com> #2Aug 22, 2022 04:03PM

Reassigned to mo...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 815efc4dea3c65634090fd272b5bf9d9cf68d70b
Author: Matvei Malkov <malkov@google.com>
Date: Tue Aug 04 13:35:42 2020

Drawer API polish

Added few paramerets for better customization, refactored samples to make them copyable

Change-Id: I236555ff68b57685c4709ba24a6464e7fba0c10a
Relnote: modifier, backgroundColor, contentColor and scrimColor customization params has been added to Drawers
Fixes: 161804378
Test: should pass

M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/DrawerSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/DrawerTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Scaffold.kt

https://android-review.googlesource.com/1385874

mo...@google.com <mo...@google.com> #3Aug 22, 2022 05:52PM

Sounds useful. +Alex

va...@google.com <va...@google.com> #4Aug 22, 2022 05:56PM

Agreed, I think an API here that is planned to integrate well with b/237019262 would be useful.

mo...@google.com <mo...@google.com> Aug 29, 2022 11:38PM

Accepted by mo...@google.com.

ap...@google.com <ap...@google.com> #5Sep 1, 2022 06:07PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit f6c646af9c5d6eed33998affaccdba72dcc9b825
Author: George Mount <mount@google.com>
Date: Mon Aug 29 15:55:07 2022

Allow access to consumed WindowInsets

Fixes: 237019262
Fixes: 243119659

Relnote: "Added Modifier.withConsumedWindowInsets() to
to get consumed WindowInsets for use outside windowInsetsPadding.
Added MutableWindowInsets to allow easily changing WindowInsets
without recomposition."

Test: new tests
Change-Id: I7fd28c29953ca10b4182d07996f16b66263548b1

M compose/foundation/foundation-layout/src/test/kotlin/androidx/compose/foundation/layout/WindowInsetsTest.kt
M compose/foundation/foundation-layout/samples/src/main/java/androidx/compose/foundation/layout/samples/WindowInsetsPaddingSample.kt
M compose/foundation/foundation-layout/api/public_plus_experimental_1.3.0-beta02.txt
M compose/foundation/foundation-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/WindowInsetsPaddingTest.kt
M compose/foundation/foundation-layout/api/public_plus_experimental_current.txt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/WindowInsets.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/WindowInsetsPadding.kt

https://android-review.googlesource.com/2198790

na...@google.com <na...@google.com> #6Sep 21, 2022 05:53PM

This bug was linked in a change in the following release(s):

androidx.compose.foundation:foundation-layout:1.3.0-beta03

Issue 243119659