Expose consumed inset values to modifiers [243119659]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Aug 19, 2022 08:01PM

Jetpack Compose version: 1.2.0

Jetpack Compose component(s) used: foundation

I have custom modifiers that would like to know which insets have been consumed by other insets padding modifiers or consumedWindowInsets, so they don't double apply.

If ModifierLocalConsumedWindowInsets was public then I could use ModifierLocalConsumer. Alternatively, some Modifier extension function which passes the consumed WindowInsets as an argument would be nice:

fun Modifier.withConsumedWindowInsets(
  factory: @Composable Modifier.(consumed: WindowInsets) -> Modifier
) {
  // ...
}

Comments

ma...@google.com <ma...@google.com> #2Aug 22, 2022 04:03PM

Reassigned to mo...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

mo...@google.com <mo...@google.com> #3Aug 22, 2022 05:52PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

va...@google.com <va...@google.com> #4Aug 22, 2022 05:56PM

Agreed, I think an API here that is planned to integrate well with b/237019262 would be useful.

mo...@google.com <mo...@google.com> Aug 29, 2022 11:38PM

Accepted by mo...@google.com.

ap...@google.com <ap...@google.com> #5Sep 1, 2022 06:07PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit f6c646af9c5d6eed33998affaccdba72dcc9b825
Author: George Mount <mount@google.com>
Date: Mon Aug 29 15:55:07 2022

Allow access to consumed WindowInsets

Fixes: 237019262
Fixes: 243119659

Relnote: "Added Modifier.withConsumedWindowInsets() to
to get consumed WindowInsets for use outside windowInsetsPadding.
Added MutableWindowInsets to allow easily changing WindowInsets
without recomposition."

Test: new tests
Change-Id: I7fd28c29953ca10b4182d07996f16b66263548b1

M compose/foundation/foundation-layout/src/test/kotlin/androidx/compose/foundation/layout/WindowInsetsTest.kt
M compose/foundation/foundation-layout/samples/src/main/java/androidx/compose/foundation/layout/samples/WindowInsetsPaddingSample.kt
M compose/foundation/foundation-layout/api/public_plus_experimental_1.3.0-beta02.txt
M compose/foundation/foundation-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/WindowInsetsPaddingTest.kt
M compose/foundation/foundation-layout/api/public_plus_experimental_current.txt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/WindowInsets.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/WindowInsetsPadding.kt

https://android-review.googlesource.com/2198790

na...@google.com <na...@google.com> #6Sep 21, 2022 05:53PM

This bug was linked in a change in the following release(s):

androidx.compose.foundation:foundation-layout:1.3.0-beta03

Issue 243119659