[Compose Navigation] File Deeplink without Args crashes App on navigateUp [243183636]

Fixed

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

Aug 20, 2022 04:54PM

Component used: Compose Navigation Version used: 2.5.1 Devices/Android versions reproduced on:

Issue Description

I added Deeplink support for json files to one of my Compose Screens like this

                composable(
                    route = Screens.screenB,
                    deepLinks = listOf(
                        navDeepLink {
                            uriPattern = "content://"
                            mimeType = "application/json"
                            action = Intent.ACTION_VIEW
                        }
                    ),
                    // with this not commented out, the app doesn't crash
//                    arguments = listOf(
//                        navArgument(name = "bla") {
//                            type = NavType.StringType
//                            nullable = true
//                            defaultValue = null
//                        }
//                    )
                ) {
                    val viewModel = hiltViewModel<ScreenBViewModel>()
                    ScreenB(
                        viewModel = viewModel,
                        onBack = navController::navigateUp,
                    )
                }

After opening a json file the app navigates to the correct screen, but when the user clicks on the toolbar back button and navigateUp is triggered the app crashes instantly with following stacktrace:

java.lang.NullPointerException: Attempt to invoke virtual method 'void android.os.Bundle.unparcel()' on a null object reference
        at android.os.Bundle.putAll(Bundle.java:303)
        at androidx.navigation.NavController.tryRelaunchUpToGeneratedStack(NavController.kt:843)
        at androidx.navigation.NavController.navigateUp(NavController.kt:752)
        at com.tostert.navigationfiledeeplink.ComposableSingletons$MainActivityKt$lambda-1$1$1$3$1.invoke(MainActivity.kt:50)
        at com.tostert.navigationfiledeeplink.ComposableSingletons$MainActivityKt$lambda-1$1$1$3$1.invoke(MainActivity.kt:50)
        at androidx.compose.foundation.ClickableKt$clickable$4$gesture$1$2.invoke-k-4lQ0M(Clickable.kt:153)
        at androidx.compose.foundation.ClickableKt$clickable$4$gesture$1$2.invoke(Clickable.kt:142)
        at androidx.compose.foundation.gestures.TapGestureDetectorKt$detectTapAndPress$2$1$1.invokeSuspend(TapGestureDetector.kt:222)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTaskKt.resume(DispatchedTask.kt:178)
        at kotlinx.coroutines.DispatchedTaskKt.dispatch(DispatchedTask.kt:166)
        at kotlinx.coroutines.CancellableContinuationImpl.dispatchResume(CancellableContinuationImpl.kt:397)
        at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl(CancellableContinuationImpl.kt:431)
        at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl$default(CancellableContinuationImpl.kt:420)
        at kotlinx.coroutines.CancellableContinuationImpl.resumeWith(CancellableContinuationImpl.kt:328)
        at androidx.compose.ui.input.pointer.SuspendingPointerInputFilter$PointerEventHandlerCoroutine.offerPointerEvent(SuspendingPointerInputFilter.kt:563)
        at androidx.compose.ui.input.pointer.SuspendingPointerInputFilter.dispatchPointerEvent(SuspendingPointerInputFilter.kt:455)
        at androidx.compose.ui.input.pointer.SuspendingPointerInputFilter.onPointerEvent-H0pRuoY(SuspendingPointerInputFilter.kt:468)
        at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:310)
        at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:297)
        at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:297)
        at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:297)
        at androidx.compose.ui.input.pointer.NodeParent.dispatchMainEventPass(HitPathTracker.kt:179)
        at androidx.compose.ui.input.pointer.HitPathTracker.dispatchChanges(HitPathTracker.kt:98)
        at androidx.compose.ui.input.pointer.PointerInputEventProcessor.process-BIzXfog(PointerInputEventProcessor.kt:97)
        at androidx.compose.ui.platform.AndroidComposeView.sendMotionEvent-8iAsVTc(AndroidComposeView.android.kt:1280)
        at androidx.compose.ui.platform.AndroidComposeView.handleMotionEvent-8iAsVTc(AndroidComposeView.android.kt:1230)
        at androidx.compose.ui.platform.AndroidComposeView.dispatchTouchEvent(AndroidComposeView.android.kt:1169)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
2022-08-20 18:31:15.673 21442-21442/com.tostert.navigationfiledeeplink E/AndroidRuntime:     at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1899)
        at android.app.Activity.dispatchTouchEvent(Activity.java:4262)
        at androidx.appcompat.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:70)
        at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:456)
        at android.view.View.dispatchPointerEvent(View.java:15263)
        at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:6548)
        at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:6348)
        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5804)
        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5861)
        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5827)
        at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5992)
        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5835)
        at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:6049)
        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5808)
        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5861)
        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5827)
        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5835)
        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5808)
        at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:8857)
        at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:8808)
        at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:8777)
        at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:8980)
        at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:267)
        at android.os.MessageQueue.nativePollOnce(Native Method)
        at android.os.MessageQueue.next(MessageQueue.java:335)
        at android.os.Looper.loopOnce(Looper.java:161)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7898)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
    	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [androidx.compose.ui.platform.MotionDurationScaleImpl@5816ebb, androidx.compose.runtime.BroadcastFrameClock@77b4fd8, StandaloneCoroutine{Cancelling}@ae4ff31, AndroidUiDispatcher@a27c616]

After adding a default argument to the nav composable the app doesn't crash, but it feels like a dirty workaround because the argument is never actively used.

Is it possible to read the file uri from an argument? if yes, how does the deeplink and the argument need to be declared?

Sample Project: https://github.com/TobyEb/NavigationFileDeeplink

Comments

il...@google.com <il...@google.com> Oct 5, 2022 08:43PM

Assigned to fo...@google.com.

fo...@google.com <fo...@google.com> #2Oct 6, 2022 09:08PM

Reassigned to il...@google.com.

I'm also seeing this crash, its the largest crash in my app by far. Thanks for reporting this

il...@google.com <il...@google.com> #3Oct 10, 2022 11:44PM

Reassigned to fo...@google.com.

https://issuetracker.google.com/issues/340202286#comment38

I am on Samsung Galaxy Z Fold 5. Android 14. Very easy to reproduce when I unfold the phone and switch between navigation rail items very quickly. When the phone is folded the error cannot be reproduced (at least for me).

fo...@google.com <fo...@google.com> Oct 13, 2022 12:28AM

Reassigned to il...@google.com.

il...@google.com <il...@google.com> Oct 13, 2022 06:03PM

Reassigned to cl...@google.com.

ap...@google.com <ap...@google.com> #4Oct 14, 2022 08:18PM

Updated stats on my side :
98% affected (unique) users are Samsung devices (2% motorola) - from 100 bug occurences over 10k+ users
100% are on Android 14

cl...@google.com <cl...@google.com> #5Oct 14, 2022 08:20PM

Marked as fixed.

In our case, to reproduce the crash, we press simultaneously the Action Bar back arrow (navController::navigateUp) AND the hardware back button.

This way we get the stacktrace:

java.lang.ArrayIndexOutOfBoundsException: length=10; index=-1
    at java.util.ArrayList.get(ArrayList.java:439)
    at androidx.navigation.compose.NavHostKt$NavHost$25$1.invokeSuspend(NavHost.kt:518)

navigation-compose 2.8.3
activity-compose 1.9.3
Android 12 (API 31)

na...@google.com <na...@google.com> #6Nov 9, 2022 06:27PM

as I understand it doesn't happen with androidxNavigation = "2.7.7" version or lower, so let's not updated it until it's fixes