[Compose Navigation] File Deeplink without Args crashes App on navigateUp [243183636]

Fixed

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

Aug 20, 2022 04:54PM

Component used: Compose Navigation Version used: 2.5.1 Devices/Android versions reproduced on:

Issue Description

I added Deeplink support for json files to one of my Compose Screens like this

                composable(
                    route = Screens.screenB,
                    deepLinks = listOf(
                        navDeepLink {
                            uriPattern = "content://"
                            mimeType = "application/json"
                            action = Intent.ACTION_VIEW
                        }
                    ),
                    // with this not commented out, the app doesn't crash
//                    arguments = listOf(
//                        navArgument(name = "bla") {
//                            type = NavType.StringType
//                            nullable = true
//                            defaultValue = null
//                        }
//                    )
                ) {
                    val viewModel = hiltViewModel<ScreenBViewModel>()
                    ScreenB(
                        viewModel = viewModel,
                        onBack = navController::navigateUp,
                    )
                }

After opening a json file the app navigates to the correct screen, but when the user clicks on the toolbar back button and navigateUp is triggered the app crashes instantly with following stacktrace:

java.lang.NullPointerException: Attempt to invoke virtual method 'void android.os.Bundle.unparcel()' on a null object reference
        at android.os.Bundle.putAll(Bundle.java:303)
        at androidx.navigation.NavController.tryRelaunchUpToGeneratedStack(NavController.kt:843)
        at androidx.navigation.NavController.navigateUp(NavController.kt:752)
        at com.tostert.navigationfiledeeplink.ComposableSingletons$MainActivityKt$lambda-1$1$1$3$1.invoke(MainActivity.kt:50)
        at com.tostert.navigationfiledeeplink.ComposableSingletons$MainActivityKt$lambda-1$1$1$3$1.invoke(MainActivity.kt:50)
        at androidx.compose.foundation.ClickableKt$clickable$4$gesture$1$2.invoke-k-4lQ0M(Clickable.kt:153)
        at androidx.compose.foundation.ClickableKt$clickable$4$gesture$1$2.invoke(Clickable.kt:142)
        at androidx.compose.foundation.gestures.TapGestureDetectorKt$detectTapAndPress$2$1$1.invokeSuspend(TapGestureDetector.kt:222)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTaskKt.resume(DispatchedTask.kt:178)
        at kotlinx.coroutines.DispatchedTaskKt.dispatch(DispatchedTask.kt:166)
        at kotlinx.coroutines.CancellableContinuationImpl.dispatchResume(CancellableContinuationImpl.kt:397)
        at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl(CancellableContinuationImpl.kt:431)
        at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl$default(CancellableContinuationImpl.kt:420)
        at kotlinx.coroutines.CancellableContinuationImpl.resumeWith(CancellableContinuationImpl.kt:328)
        at androidx.compose.ui.input.pointer.SuspendingPointerInputFilter$PointerEventHandlerCoroutine.offerPointerEvent(SuspendingPointerInputFilter.kt:563)
        at androidx.compose.ui.input.pointer.SuspendingPointerInputFilter.dispatchPointerEvent(SuspendingPointerInputFilter.kt:455)
        at androidx.compose.ui.input.pointer.SuspendingPointerInputFilter.onPointerEvent-H0pRuoY(SuspendingPointerInputFilter.kt:468)
        at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:310)
        at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:297)
        at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:297)
        at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:297)
        at androidx.compose.ui.input.pointer.NodeParent.dispatchMainEventPass(HitPathTracker.kt:179)
        at androidx.compose.ui.input.pointer.HitPathTracker.dispatchChanges(HitPathTracker.kt:98)
        at androidx.compose.ui.input.pointer.PointerInputEventProcessor.process-BIzXfog(PointerInputEventProcessor.kt:97)
        at androidx.compose.ui.platform.AndroidComposeView.sendMotionEvent-8iAsVTc(AndroidComposeView.android.kt:1280)
        at androidx.compose.ui.platform.AndroidComposeView.handleMotionEvent-8iAsVTc(AndroidComposeView.android.kt:1230)
        at androidx.compose.ui.platform.AndroidComposeView.dispatchTouchEvent(AndroidComposeView.android.kt:1169)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2802)
2022-08-20 18:31:15.673 21442-21442/com.tostert.navigationfiledeeplink E/AndroidRuntime:     at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1899)
        at android.app.Activity.dispatchTouchEvent(Activity.java:4262)
        at androidx.appcompat.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:70)
        at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:456)
        at android.view.View.dispatchPointerEvent(View.java:15263)
        at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:6548)
        at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:6348)
        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5804)
        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5861)
        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5827)
        at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5992)
        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5835)
        at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:6049)
        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5808)
        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5861)
        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5827)
        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5835)
        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5808)
        at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:8857)
        at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:8808)
        at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:8777)
        at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:8980)
        at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:267)
        at android.os.MessageQueue.nativePollOnce(Native Method)
        at android.os.MessageQueue.next(MessageQueue.java:335)
        at android.os.Looper.loopOnce(Looper.java:161)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7898)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
    	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [androidx.compose.ui.platform.MotionDurationScaleImpl@5816ebb, androidx.compose.runtime.BroadcastFrameClock@77b4fd8, StandaloneCoroutine{Cancelling}@ae4ff31, AndroidUiDispatcher@a27c616]

After adding a default argument to the nav composable the app doesn't crash, but it feels like a dirty workaround because the argument is never actively used.

Is it possible to read the file uri from an argument? if yes, how does the deeplink and the argument need to be declared?

Sample Project: https://github.com/TobyEb/NavigationFileDeeplink

Comments

il...@google.com <il...@google.com> Oct 5, 2022 08:43PM

Assigned to fo...@google.com.

fo...@google.com <fo...@google.com> #2Oct 6, 2022 09:08PM

Reassigned to il...@google.com.

Oh I forgot to mention that I thought it might be connected to this issue: https://issuetracker.google.com/issues/243778589. But after trying 2.5.2 I can say that the issue persists.

il...@google.com <il...@google.com> #3Oct 10, 2022 11:44PM

Reassigned to fo...@google.com.

Please provide a minimal sample project along with the minimal steps to recreate the issue in the project.

fo...@google.com <fo...@google.com> Oct 13, 2022 12:28AM

Reassigned to il...@google.com.

il...@google.com <il...@google.com> Oct 13, 2022 06:03PM

Reassigned to cl...@google.com.

ap...@google.com <ap...@google.com> #4Oct 14, 2022 08:18PM

Sorry for the delay. I got a working example here: https://github.com/Del-S/issues. The project is set up to crash when navigating to ThirdFragment (nested nav graph) with poping the graph.

I poked into it a little bit and it seems to be connected to SafeArgs gradle plugin. When safe args is used to navigate to ThirdFragment (with nested graph poped) it will try to recreate te parent but there were no arguments passed so it crashes.

Steps to reproduce:

Navigate from Second Fragment to Child nav graph (with non-nullable parameters).
Navigate to Third fragment using SafeArgs and the app crashes.

Crash log:

Process: cz.dels.issues, PID: 1743
java.lang.NullPointerException: null cannot be cast to non-null type kotlin.Long
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:352)
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:342)
at androidx.navigation.NavArgument.verify(NavArgument.kt:76)
at androidx.navigation.NavDestination.addInDefaultArgs(NavDestination.kt:502)
at androidx.navigation.NavController.addEntryToBackStack(NavController.kt:1865)
at androidx.navigation.NavController.addEntryToBackStack$default(NavController.kt:1813)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1721)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1719)
at androidx.navigation.NavController$NavControllerNavigatorState.push(NavController.kt:287)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:246)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:162)
at androidx.navigation.NavController.navigateInternal(NavController.kt:260)
at androidx.navigation.NavController.navigate(NavController.kt:1719)
at androidx.navigation.NavController.navigate(NavController.kt:1545)
at androidx.navigation.NavController.navigate(NavController.kt:1472)
at androidx.navigation.NavController.navigate(NavController.kt:1930)
at cz.dels.issues.SecondFragment.onViewCreated$lambda-0(SecondFragment.kt:38)
at cz.dels.issues.SecondFragment.$r8$lambda$XDYnOS_cYrafiNQ5rcCu1WCn0IE(Unknown Source:0)
at cz.dels.issues.SecondFragment$$ExternalSyntheticLambda0.onClick(Unknown Source:2)

Note: If in step 2 SaveArgs is not used then navigation works correctly. More information is here: https://github.com/Del-S/issues/blob/master/app/src/main/java/cz/dels/issues/SecondFragment.kt#L37.

cl...@google.com <cl...@google.com> #5Oct 14, 2022 08:20PM

Marked as fixed.

Ups a typo: Navigate from ~~Second~~ First Fragment to Child nav graph (with non-nullable parameters).

Note: sorry for the spam but I am not able to edit my own comment.

na...@google.com <na...@google.com> #6Nov 9, 2022 06:27PM

This has been fixed and will be available in navigation 2.6.0-alpha08