Instantiated lint check does not handle AppComponentFactory well [243267012]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Aug 21, 2022 08:04PM

When using minSdk 28+ and AppComponentFactory, we can set up activities to use DI + constructor injection. However, the Instantiated lint check does not properly handle this well and is ultimately going to force us to disable it entirely.

It would be nice if this lint was more configurable or intelligent, such as recognizing @Inject-annotated constructors.

/home/runner/work/circuit/circuit/sample/src/main/AndroidManifest.xml:32: Error: This class should provide a default constructor (a public constructor with no arguments) (com.slack.circuit.sample.MainActivity) [Instantiatable]
            android:name=".MainActivity"
                          ~~~~~~~~~~~~~

   Explanation for issues of type "Instantiatable":
   Activities, services, broadcast receivers etc. registered in the manifest
   file (or for custom views, in a layout file) must be "instantiatable" by
   the system, which means that the class must be public, it must have an
   empty public constructor, and if it's an inner class, it must be a static
   inner class.

Studio Build: Chipmunk Patch 2
Version of Gradle Plugin: 7.2.2
Version of Gradle: N/A
Version of Java: N/A
OS: N/A

Note that this exists in the latest AGP alpha too (7.4.0-alpha09 at the time of writing)

Comments

za...@gmail.com <za...@gmail.com> #2Aug 21, 2022 08:05PM

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

za...@gmail.com <za...@gmail.com> #3Aug 21, 2022 08:07PM

Almost 2 months later and this is still broken

jo...@google.com <jo...@google.com> Aug 22, 2022 04:33PM

Assigned to an...@google.com.

za...@gmail.com <za...@gmail.com> #4Feb 14, 2023 06:33AM

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

gh...@google.com <gh...@google.com> Apr 12, 2023 06:44PM

Reassigned to gh...@google.com.

gh...@google.com <gh...@google.com> #5Apr 13, 2023 05:05PM

Marked as fixed.

jb...@google.com What is the update on this?

za...@gmail.com <za...@gmail.com> #6Apr 13, 2023 09:10PM

What is the status of this item?

gh...@google.com <gh...@google.com> #7Apr 13, 2023 09:40PM

This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.

za...@gmail.com <za...@gmail.com> #8Apr 20, 2023 10:21PM

Any ETA on next release?

zs...@salesforce.com <zs...@salesforce.com> #9Jul 6, 2023 06:24PM

Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.

gh...@google.com <gh...@google.com> #10Jul 6, 2023 06:34PM

Comfirmed that this seems to still be broken. Can we have an update please?

```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1

(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```

za...@gmail.com <za...@gmail.com> #11Jan 5, 2024 08:51PM

Hi, is there any update to this issue? Thanks.