Instantiated lint check does not handle AppComponentFactory well [243267012]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Aug 21, 2022 08:04PM

When using minSdk 28+ and AppComponentFactory, we can set up activities to use DI + constructor injection. However, the Instantiated lint check does not properly handle this well and is ultimately going to force us to disable it entirely.

It would be nice if this lint was more configurable or intelligent, such as recognizing @Inject-annotated constructors.

/home/runner/work/circuit/circuit/sample/src/main/AndroidManifest.xml:32: Error: This class should provide a default constructor (a public constructor with no arguments) (com.slack.circuit.sample.MainActivity) [Instantiatable]
            android:name=".MainActivity"
                          ~~~~~~~~~~~~~

   Explanation for issues of type "Instantiatable":
   Activities, services, broadcast receivers etc. registered in the manifest
   file (or for custom views, in a layout file) must be "instantiatable" by
   the system, which means that the class must be public, it must have an
   empty public constructor, and if it's an inner class, it must be a static
   inner class.

Studio Build: Chipmunk Patch 2
Version of Gradle Plugin: 7.2.2
Version of Gradle: N/A
Version of Java: N/A
OS: N/A

Note that this exists in the latest AGP alpha too (7.4.0-alpha09 at the time of writing)

Comments

za...@gmail.com <za...@gmail.com> #2Aug 21, 2022 08:05PM

Sorry the check is Instantiatable, not Instantiated

za...@gmail.com <za...@gmail.com> #3Aug 21, 2022 08:07PM

Here's an example: https://github.com/slackhq/circuit/pull/26

jo...@google.com <jo...@google.com> Aug 22, 2022 04:33PM

Assigned to an...@google.com.

za...@gmail.com <za...@gmail.com> #4Feb 14, 2023 06:33AM

Another related issue is ViewConstructor lint checks, which fail similarly when using assisted injection

gh...@google.com <gh...@google.com> Apr 12, 2023 06:44PM

Reassigned to gh...@google.com.

gh...@google.com <gh...@google.com> #5Apr 13, 2023 05:05PM

Marked as fixed.

I submitted Change I9d6ba5bb9 to suppress this Lint warning when some constructor has the @Inject annotation.

For more niche usages of AppComponentFactory, I think disabling the Instantiatable check is the right solution.

Thanks for the report!

za...@gmail.com <za...@gmail.com> #6Apr 13, 2023 09:10PM

Awesome! Should I file a separate request for doing the same (with @AssistedInject) in View constructors?

gh...@google.com <gh...@google.com> #7Apr 13, 2023 09:40PM

Are you referring to the ViewConstructor Lint check? To me this Lint check appears to be valid even when DI annotations are involved, because presumably DI annotations are ignored by the layout editor in Android Studio.

If I misunderstood, please file a bug and link it here; thanks!

za...@gmail.com <za...@gmail.com> #8Apr 20, 2023 10:21PM

https://issuetracker.google.com/issues/279001786

zs...@salesforce.com <zs...@salesforce.com> #9Jul 6, 2023 06:24PM

@matthew is there a way to see which AGP/lint version this landed in?

gh...@google.com <gh...@google.com> #10Jul 6, 2023 06:34PM

This should be in Studio Hedgehog Canary 1

(We have an internal tool that maps the ChangeId to a release version. I don't think this is easy to compute externally.)

za...@gmail.com <za...@gmail.com> #11Jan 5, 2024 08:51PM

@Matthew this sorted stalled halfway (the viewconstructor lint is still missing this support). Can you help route that issue I linked above?