Don't add ignorewarnings to R8 by default [243342123]

Fixed

Bug

Status Update

No update yet.

Description

ga...@google.com

created issue #1

Aug 22, 2022 08:20AM

For AGP 8.0 we should remove the injection of -ignorewarnings , and make missing classes an error.

Comments

bi...@google.com <bi...@google.com> #2Aug 27, 2022 12:38AM

Thank you for the report and the supplied dump with the reproduction. I can confirm that the NPE is also present on HEAD, and I will look into it.

Quite a few of the class files in the dump has malformed inner-class attribute, where R8 reports e.g.:

Info in /tmp/tmpo67ucguh/program.jar:ofifmwrrhhmodsc/ψξψξψξξ.class:
Malformed inner-class attribute:
	outerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ
	innerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ$ψξξψξξξ
	innerName: ψξψξψξξ$ψξξψξξξ

These are ignored, so they should not be the reason for the NPE, but something to also look into.

Message last modified on Aug 27, 2022 12:39AM

sg...@google.com <sg...@google.com> #3Aug 29, 2022 06:51AM

Project: r8
Branch: main

commit e59500ca4445f5fb5d2ccc1114acbf66df11d196
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:55 2023

Insert patched frame instructions in the right place

Fixes:

b/274337639

Change-Id: Iae204ed529f9af5bf5fa3eaacba45128dfa6fd9e

M src/main/java/com/android/tools/r8/graph/LazyCfCode.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77390

Message last modified on Aug 29, 2022 06:51AM

bi...@google.com <bi...@google.com> #4Aug 29, 2022 05:44PM

Project: r8
Branch: main

commit 780c2e83c8c033e7594d61894fa1b3dbcad6630b
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:13 2023

Add reproduction of

b/274337639

Bug:

b/274337639

Change-Id: I7573883d6a649eed47b10d7bf0cdea2e11710268

M build.gradle
M src/main/java/com/android/tools/r8/cf/code/frame/UninitializedNew.java
A src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77389

bi...@google.com <bi...@google.com> #5Aug 30, 2022 07:23PM

I will backport this to the 8.0 and 4.0 branches.

ga...@google.com <ga...@google.com> #6Aug 31, 2022 09:03AM

Thank you very much for taking a look at this!

Is this fix related to the nullpointer or the malformed inner-class attributes ?

Do you have a separated ticket for it? Could you share it?

ch...@google.com <ch...@google.com> #7Aug 31, 2022 09:09AM

Project: r8
Branch: 4.0

commit 6edb00fb23e41b28d4794cfa69d706d5c5aa3fba
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:55:01 2023

Version 4.0.56

Bug:

b/274337639

Change-Id: I88a20fc922ce892d38fa3a34f9a3f1f4714354ae

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77447

bi...@google.com <bi...@google.com> Aug 31, 2022 04:12PM

Accepted by bi...@google.com.

bi...@google.com <bi...@google.com> #8Sep 7, 2022 06:11PM

Project: r8
Branch: 4.0

commit d9215af3b02f64d1207b9ebd63a6925229307b9d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:50 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

https://r8-review.googlesource.com/77446

Message last modified on Sep 7, 2022 06:13PM

bi...@google.com <bi...@google.com> #9Sep 7, 2022 06:58PM

Project: r8
Branch: 4.0

commit 4fda9b9062c871ba0e31cb68d1518b13b993692f
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:33 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77445

bi...@google.com <bi...@google.com> #10Sep 10, 2022 12:05AM

Project: r8
Branch: 8.0

commit 6686e7dffea83ea894438b496c065d0a18cda206
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:53:01 2023

Version 8.0.37

Bug:

b/274337639

Change-Id: I43a723a94638088d921cd3fb6e22ef6e41f07d5f

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77444

sg...@google.com <sg...@google.com> #11Sep 12, 2022 06:54AM

Project: r8
Branch: 8.0

commit 57f55fb70aa678a61f9c7ff1826fbc695faeac7d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:52:27 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

https://r8-review.googlesource.com/77443

ga...@google.com <ga...@google.com> #12Sep 12, 2022 08:28AM

Project: r8
Branch: 8.0

commit cd00c053222b06bb27fdd90bbed56af9c9ef0744
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:51:57 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77442

bi...@google.com <bi...@google.com> #13Sep 12, 2022 04:37PM

b/274337639

https://r8-review.googlesource.com/77446

bi...@google.com <bi...@google.com> #14Sep 26, 2022 06:08PM

Marked as fixed.

Project: r8
Branch: 4.0

commit 4fda9b9062c871ba0e31cb68d1518b13b993692f
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:33 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77445

[Deleted User] <[Deleted User]> #15Sep 30, 2022 09:48AM

Answer to #comment6. This fix only addresses the NPE.

The malformed inner-class attributes is an issue with the input class files, and they where not related to the NPE. You will have to contact the supplier of the library where they are present if you would like to get rid of the "Info" messages (you will have to run ./gradlew --info ... to see them). From what I can see the issue is that the innerName: ψξψξψξξ$ψξξψξξξ should have been innerName: ψξξψξξξ.

ey...@gmail.com <ey...@gmail.com> #16Dec 1, 2022 07:45AM

Project: r8
Branch: 4.0

commit 49f738ff7377dacecf0fca39fec5146beb251ea3
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 18:14:15 2023

Version 4.0.57

Backport test to 4.0 test APIs.

Bug:

b/274337639

Change-Id: Iecf03a2ad9dcdbd53e6c572d2f08915248435682

M src/main/java/com/android/tools/r8/Version.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77450

sg...@google.com <sg...@google.com> #17Dec 1, 2022 08:23AM

Project: r8
Branch: 8.0

commit c11ddf096e58245c2c67514dc9e5a2098dd8f705
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 18:16:54 2023

Version 8.0.38

Backport test to 8.0 test APIs.

Bug:

b/274337639

Change-Id: I35ae6d701fa92a6a7a734f9c0296d1383fed8e20

M src/main/java/com/android/tools/r8/Version.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77451

ga...@google.com <ga...@google.com> #18Dec 8, 2022 03:53PM

deleted

Issue 243342123

Description

Issue summary

Comments

bi...@google.com <bi...@google.com> #2Aug 27, 2022 12:38AM

sg...@google.com <sg...@google.com> #3Aug 29, 2022 06:51AM

bi...@google.com <bi...@google.com> #4Aug 29, 2022 05:44PM

bi...@google.com <bi...@google.com> #5Aug 30, 2022 07:23PM

ga...@google.com <ga...@google.com> #6Aug 31, 2022 09:03AM

ch...@google.com <ch...@google.com> #7Aug 31, 2022 09:09AM

bi...@google.com <bi...@google.com> Aug 31, 2022 04:12PM

bi...@google.com <bi...@google.com> #8Sep 7, 2022 06:11PM

bi...@google.com <bi...@google.com> #9Sep 7, 2022 06:58PM

bi...@google.com <bi...@google.com> #10Sep 10, 2022 12:05AM

sg...@google.com <sg...@google.com> #11Sep 12, 2022 06:54AM

ga...@google.com <ga...@google.com> #12Sep 12, 2022 08:28AM

bi...@google.com <bi...@google.com> #13Sep 12, 2022 04:37PM

bi...@google.com <bi...@google.com> #14Sep 26, 2022 06:08PM

[Deleted User] <[Deleted User]> #15Sep 30, 2022 09:48AM

ey...@gmail.com <ey...@gmail.com> #16Dec 1, 2022 07:45AM

sg...@google.com <sg...@google.com> #17Dec 1, 2022 08:23AM

ga...@google.com <ga...@google.com> #18Dec 8, 2022 03:53PM

Add comment

Issue metadata