Using dynamic features and resource shrinking cause runtime crash [243399322]

Fixed

Bug

Status Update

No update yet.

Description

lu...@google.com

created issue #1

Aug 22, 2022 05:17PM

To reproduce:

Create a new project (issue present in 7.4.0-alpha09)
Add a dynamic feature module
Enable resource shrinking for debug / build a release
Deploy to device
Runtime error on device

Sample Runtime exception:

 java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.dynamicfeaturesresourceshrinker/com.example.dynamicfeaturesresourceshrinker.MainActivity}: android.content.res.Resources$NotFoundException: Drawable com.example.dynamicfeaturesresourceshrinker:drawable/abc_vector_test with resource ID #0x7f070055
                                                                                                    	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3707)
                                                                                                    	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3844)
                                                                                                    	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
                                                                                                    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2315)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:201)
                                                                                                    	at android.os.Looper.loop(Looper.java:288)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:7929)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
                                                                                                    Caused by: android.content.res.Resources$NotFoundException: Drawable com.example.dynamicfeaturesresourceshrinker:drawable/abc_vector_test with resource ID #0x7f070055
                                                                                                    Caused by: android.content.res.Resources$NotFoundException: File res/drawable/abc_vector_test.xml from drawable resource ID #0x7f070055
                                                                                                    	at android.content.res.ResourcesImpl.loadDrawableForCookie(ResourcesImpl.java:875)
                                                                                                    	at android.content.res.ResourcesImpl.loadDrawable(ResourcesImpl.java:669)
                                                                                                    	at android.content.res.Resources.loadDrawable(Resources.java:1002)
                                                                                                    	at android.content.res.Resources.getDrawableForDensity(Resources.java:992)
                                                                                                    	at android.content.res.Resources.getDrawable(Resources.java:931)
                                                                                                    	at android.content.Context.getDrawable(Context.java:810)
                                                                                                    	at androidx.core.content.ContextCompat$Api21Impl.getDrawable(ContextCompat.java:864)
                                                                                                    	at androidx.core.content.ContextCompat.getDrawable(ContextCompat.java:483)
                                                                                                    	at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:148)
                                                                                                    	at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:136)
                                                                                                    	at androidx.appcompat.widget.ResourceManagerInternal.checkVectorDrawableSetup(ResourceManagerInternal.java:493)
                                                                                                    	at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:141)
                                                                                                    	at androidx.appcompat.widget.AppCompatDrawableManager.getDrawable(AppCompatDrawableManager.java:480)
                                                                                                    	at androidx.appcompat.widget.TintTypedArray.getDrawableIfKnown(TintTypedArray.java:93)
                                                                                                    	at androidx.appcompat.app.AppCompatDelegateImpl.attachToWindow(AppCompatDelegateImpl.java:803)
                                                                                                    	at androidx.appcompat.app.AppCompatDelegateImpl.ensureWindow(AppCompatDelegateImpl.java:779)
                                                                                                    	at androidx.appcompat.app.AppCompatDelegateImpl.onCreate(AppCompatDelegateImpl.java:506)
                                                                                                    	at androidx.appcompat.app.AppCompatActivity$2.onContextAvailable(AppCompatActivity.java:131)
                                                                                                    	at androidx.activity.contextaware.ContextAwareHelper.dispatchOnContextAvailable(ContextAwareHelper.java:99)
                                                                                                    	at androidx.activity.ComponentActivity.onCreate(ComponentActivity.java:352)
                                                                                                    	at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:217)
                                                                                                    	at com.example.dynamicfeaturesresourceshrinker.MainActivity.onCreate(MainActivity.kt:20)
                                                                                                    	at android.app.Activity.performCreate(Activity.java:8290)
                                                                                                    	at android.app.Activity.performCreate(Activity.java:8269)
                                                                                                    	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1384)
                                                                                                    	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3688)
                                                                                                    	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3844)
                                                                                                    	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101)
2022-08-22 17:32:27.796  6108-6133  libEGL                  com...namicfeaturesresourceshrinker  D  loaded /vendor/lib64/egl/libGLESv2_emulation.so
2022-08-22 17:32:27.797  6108-6108  AndroidRuntime          com...namicfeaturesresourceshrinker  E  	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
                                                                                                    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2315)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:201)
                                                                                                    	at android.os.Looper.loop(Looper.java:288)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:7929)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
                                                                                                    Caused by: android.view.InflateException: Class not found x
                                                                                                    	at android.graphics.drawable.DrawableInflater.inflateFromClass(DrawableInflater.java:219)
                                                                                                    	at android.graphics.drawable.DrawableInflater.inflateFromXmlForDensity(DrawableInflater.java:138)
                                                                                                    	at android.graphics.drawable.Drawable.createFromXmlInnerForDensity(Drawable.java:1394)
                                                                                                    	at android.graphics.drawable.Drawable.createFromXmlForDensity(Drawable.java:1355)
                                                                                                    	at android.content.res.ResourcesImpl.loadXmlDrawable(ResourcesImpl.java:907)
                                                                                                    	at android.content.res.ResourcesImpl.loadDrawableForCookie(ResourcesImpl.java:861)
                                                                                                    	... 37 more
                                                                                                    Caused by: java.lang.ClassNotFoundException: Didn't find class "x" on path: DexPathList[[zip file "/data/app/~~JJPzuCKIrqWmDeUI8NSpqw==/com.example.dynamicfeaturesresourceshrinker-rSTCmERGJ999I4e_JFKBuw==/base.apk", zip file "/data/app/~~JJPzuCKIrqWmDeUI8NSpqw==/com.example.dynamicfeaturesresourceshrinker-rSTCmERGJ999I4e_JFKBuw==/split_dynamicfeature.apk"],nativeLibraryDirectories=[/data/app/~~JJPzuCKIrqWmDeUI8NSpqw==/com.example.dynamicfeaturesresourceshrinker-rSTCmERGJ999I4e_JFKBuw==/lib/x86_64, /system/lib64, /system_ext/lib64]]
                                                                                                    	at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:259)
                                                                                                    	at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
                                                                                                    	at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
                                                                                                    	at android.graphics.drawable.DrawableInflater.inflateFromClass(DrawableInflater.java:200)

The issue is present both the old and new resource shrinkers. So this issue doesn't appear to be related to b/237783271 as that particular issue isn't present in the old resource shrinker.

The resource that is being reported as android.content.res.Resources$NotFoundException exists within the APK's resource table and as a file, however the contents are shrunk (empty tag xml file). In the repro case the drawable resource is declared and by an app compat library called by the MainActivity in the app (base module).

Comments

lu...@google.com <lu...@google.com> #2Aug 23, 2022 10:06AM

Assigned to iu...@google.com.

I just tested with 8.1.36-dev and 8.2.0-dev and the issue is still present.

iu...@google.com <iu...@google.com> #3Aug 25, 2022 04:07PM

Can you share a reproduction of this, if possible a compiler dump, see https://r8.googlesource.com/r8/+/refs/heads/main/doc/compilerdump.md

If not publicly, then with ricow@google.com and christofferqa@google.com

lu...@google.com <lu...@google.com> #4Aug 25, 2022 04:25PM

I can't share a repro, and the full dump contains a lot of proprietary info. Is there a subset of the dump I can share that would be helpful?

DynamicFeaturesFailWithResourceShrinking.zip

594 KB

Download

sh...@adobe.com <sh...@adobe.com> #5Sep 16, 2022 09:12AM

Can you share the resulting apk and then the androidx.profileinstaller.ProfileInstallerInitializer$Choreographer16Impl class file from the dump (it should be in the program.jar inside the dump)

am...@zee.com <am...@zee.com> #6Sep 28, 2022 07:13AM

redacted

na...@gtempaccount.com <na...@gtempaccount.com> #7Oct 6, 2022 07:20AM

I've attached a zip with those files in a restricted comment.

lu...@google.com <lu...@google.com> #8Oct 6, 2022 08:31AM

Marked as fixed.

I can't repro the verification error with the attached apk, how do I repro, and what version of android did you repro on (dex2oat will fully compile this without issues on 6 and 12)

sh...@adobe.com <sh...@adobe.com> #9Oct 22, 2022 09:23AM

I can repro on 8, 11, and 13. It crashes as soon as the app is opened.

ab...@gmail.com <ab...@gmail.com> #10Nov 15, 2022 06:43AM

Comment has been deleted.

Message last modified on Jun 22, 2023 05:13PM

ju...@gmail.com <ju...@gmail.com> #11Jun 22, 2023 04:27PM

Oh I'm sorry, I was using the wrong mapping file. I'll get you that information shortly.

ki...@gmail.com <ki...@gmail.com> #12Dec 18, 2024 09:34AM

If you don't want to share it on this bug feel free to mail it to ricow@google.com and christofferqa@google.com

lu...@google.com <lu...@google.com> #13Dec 18, 2024 02:06PM

redacted

dh...@gmail.com <dh...@gmail.com> #14Dec 19, 2024 08:46AM

The code for ProcessRestarterImpl has a very strange pattern, probably from your dependency injection, where it will generate an array of type android/content/Intent

It will then call the Function0, which returns an Object, and store that into the array, which we pass on to call into ProcessPhoenix. This will actually type check, even when the types don't match, since you are allowed to put anything into the array (if the type is wrong, it would fail at runtime though when using the value)

R8 will inline the call to 'Lcom/jakewharton/processphoenix/ProcessPhoenix;triggerRebirth(Landroid/content/Context;[Landroid/content/Intent;)V', and since we track that only a single element was in the array it will simply reuse the value already in that register (i.e., not load from the array and check, simply use the 'java/lang/Object' value)

In this case, we should not do the elimination of the array load, since we can't guarantee the type