Status Update
No update yet.
Comments
lu...@google.com
As I understand it, we need to migrate namespace definitions both from AndroidManifest.xml and from implicit definitions from applicationId / testApplicationId? Is that right? So an 8.0 project would have a
namespace <n>
testNamespace <tn>
where <n> is taken from AndroidManifest.xml package definitions if present, and applicationId if not, and <tn> is testApplicationId if present and <n>.test if not?
iu...@google.com
Sorry for the confusion. AGP would change how it computes the namespace for the androidTest variant. All the Upgrade assistant would need to do is update the source code for the import of the R class.
lu...@google.com
OK! And, I think, this should happen at the same time as the namespace declaration is migrated from AndroidManifest.xml?
sh...@adobe.com
It's unrelated, but it is possible that we move 8.0 to also only declare the namespace into the DSL. I would make it a separate refactoring because they are not tied at all.
am...@zee.com
I would consider first adding the right new value to models (as a new property) and then, to avoid Studio interpreting manifests and build configurations, just update to whatever the synced value of this new property is.
na...@gtempaccount.com
Updated version of this in #16 below
Currently, AUA removes the package attribute from the main manifest and instead specifies that value via the namespace DSL.
In addition to that, AUA should:
(1) Check for apackageattribute in the (possibly non-existent) androidTestAndroidManifest.xml. If there's a value there, it should be removed from that manifest, and if it's not equal tonamespace + ".test", it should be specified via thetestNamespaceDSL.Ifnamespace==testNamespace, this is problematic because the androidTest and regularRclasses will have the same namespace. Not sure what the best behavior is here? Maybe an error explaining that the user should first reset the androidTest AndroidManifest'spackageattribute and change the androidTest source code package accordingly?
- (2)
Compare the newtestNamespacewith the oldAndroidProject.androidTestNamespacefrom the model. If they are different, search the androidTest source code for references to anRclass namespaced withAndroidProejct.androidTestNamespace, and change the namespace totestNamespace.
sh...@adobe.com
I have a draft implementation for the second part of (1) from namespace and testNamespace are equal. Is there any documentation we can point to explaining how the user should proceed? (My in-window space budget for explanatory text is pretty limited).
ab...@gmail.com
ju...@gmail.com
Yeah definitely, I can draft it and send you a CL. Thanks! Looks like we might need to update this section too: package attribute is only used to set the applicationId when you first create your project, right (assuming people are setting the namespace using the DSL)?
Would it also be helpful to add a release note about this? I guess it's technically not new with Chipmunk, but looks like we didn't mention it in the last couple stable releases.
ki...@gmail.com
Looks like we might need to update this section too:
https://developer.android.com/guide/topics/manifest/manifest-element#package
Yes, setting the package attribute in the manifest is deprecated, will cause build warnings in AGP 7.3.0, and will cause build errors in AGP 8.0.
Currently the package attribute is only used to set the applicationId when you first create your project, right (assuming people are setting the namespace using the DSL)?
The namespace DSL will always trump the package attribute, even when determining the applicationId. E.g., if a dev sets package to "com.example.package", namespace to "com.example.namespace", and doesn't set the applicationId explicitly in the DSL, the applicationId will be "com.example.namespace".
Would it also be helpful to add a release note about this? I guess it's technically not new with Chipmunk, but looks like we didn't mention it in the last couple stable releases.
I think a 7.3 release note and an 8.0 release note since we're warning starting in 7.3 and will break the build in 8.0 when the manifest has a package attribute.
lu...@google.com
Gotcha, thanks--sent you cl/449846661, to start. Is the warning/removal happening in certain Dolphin/EE preview releases, or not until the stable releases?
dh...@gmail.com
Thanks!
Yes, the warning started in AGP 7.3.0-alpha04.
I expect we'll switch to an error in an early AGP 8.0 alpha.
Description
To reproduce:
Sample Runtime exception:
The issue is present both the old and new resource shrinkers. So this issue doesn't appear to be related to
The resource that is being reported as
android.content.res.Resources$NotFoundExceptionexists within the APK's resource table and as a file, however the contents are shrunk (empty tag xml file). In the repro case the drawable resource is declared and by an app compat library called by the MainActivity in the app (base module).