Using dynamic features and resource shrinking cause runtime crash [243399322]

Fixed

Bug

Status Update

No update yet.

Description

lu...@google.com

created issue #1

Aug 22, 2022 05:17PM

To reproduce:

Create a new project (issue present in 7.4.0-alpha09)
Add a dynamic feature module
Enable resource shrinking for debug / build a release
Deploy to device
Runtime error on device

Sample Runtime exception:

 java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.dynamicfeaturesresourceshrinker/com.example.dynamicfeaturesresourceshrinker.MainActivity}: android.content.res.Resources$NotFoundException: Drawable com.example.dynamicfeaturesresourceshrinker:drawable/abc_vector_test with resource ID #0x7f070055
                                                                                                    	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3707)
                                                                                                    	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3844)
                                                                                                    	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
                                                                                                    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2315)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:201)
                                                                                                    	at android.os.Looper.loop(Looper.java:288)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:7929)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
                                                                                                    Caused by: android.content.res.Resources$NotFoundException: Drawable com.example.dynamicfeaturesresourceshrinker:drawable/abc_vector_test with resource ID #0x7f070055
                                                                                                    Caused by: android.content.res.Resources$NotFoundException: File res/drawable/abc_vector_test.xml from drawable resource ID #0x7f070055
                                                                                                    	at android.content.res.ResourcesImpl.loadDrawableForCookie(ResourcesImpl.java:875)
                                                                                                    	at android.content.res.ResourcesImpl.loadDrawable(ResourcesImpl.java:669)
                                                                                                    	at android.content.res.Resources.loadDrawable(Resources.java:1002)
                                                                                                    	at android.content.res.Resources.getDrawableForDensity(Resources.java:992)
                                                                                                    	at android.content.res.Resources.getDrawable(Resources.java:931)
                                                                                                    	at android.content.Context.getDrawable(Context.java:810)
                                                                                                    	at androidx.core.content.ContextCompat$Api21Impl.getDrawable(ContextCompat.java:864)
                                                                                                    	at androidx.core.content.ContextCompat.getDrawable(ContextCompat.java:483)
                                                                                                    	at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:148)
                                                                                                    	at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:136)
                                                                                                    	at androidx.appcompat.widget.ResourceManagerInternal.checkVectorDrawableSetup(ResourceManagerInternal.java:493)
                                                                                                    	at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:141)
                                                                                                    	at androidx.appcompat.widget.AppCompatDrawableManager.getDrawable(AppCompatDrawableManager.java:480)
                                                                                                    	at androidx.appcompat.widget.TintTypedArray.getDrawableIfKnown(TintTypedArray.java:93)
                                                                                                    	at androidx.appcompat.app.AppCompatDelegateImpl.attachToWindow(AppCompatDelegateImpl.java:803)
                                                                                                    	at androidx.appcompat.app.AppCompatDelegateImpl.ensureWindow(AppCompatDelegateImpl.java:779)
                                                                                                    	at androidx.appcompat.app.AppCompatDelegateImpl.onCreate(AppCompatDelegateImpl.java:506)
                                                                                                    	at androidx.appcompat.app.AppCompatActivity$2.onContextAvailable(AppCompatActivity.java:131)
                                                                                                    	at androidx.activity.contextaware.ContextAwareHelper.dispatchOnContextAvailable(ContextAwareHelper.java:99)
                                                                                                    	at androidx.activity.ComponentActivity.onCreate(ComponentActivity.java:352)
                                                                                                    	at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:217)
                                                                                                    	at com.example.dynamicfeaturesresourceshrinker.MainActivity.onCreate(MainActivity.kt:20)
                                                                                                    	at android.app.Activity.performCreate(Activity.java:8290)
                                                                                                    	at android.app.Activity.performCreate(Activity.java:8269)
                                                                                                    	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1384)
                                                                                                    	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3688)
                                                                                                    	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3844)
                                                                                                    	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101)
2022-08-22 17:32:27.796  6108-6133  libEGL                  com...namicfeaturesresourceshrinker  D  loaded /vendor/lib64/egl/libGLESv2_emulation.so
2022-08-22 17:32:27.797  6108-6108  AndroidRuntime          com...namicfeaturesresourceshrinker  E  	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
                                                                                                    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2315)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:201)
                                                                                                    	at android.os.Looper.loop(Looper.java:288)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:7929)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
                                                                                                    Caused by: android.view.InflateException: Class not found x
                                                                                                    	at android.graphics.drawable.DrawableInflater.inflateFromClass(DrawableInflater.java:219)
                                                                                                    	at android.graphics.drawable.DrawableInflater.inflateFromXmlForDensity(DrawableInflater.java:138)
                                                                                                    	at android.graphics.drawable.Drawable.createFromXmlInnerForDensity(Drawable.java:1394)
                                                                                                    	at android.graphics.drawable.Drawable.createFromXmlForDensity(Drawable.java:1355)
                                                                                                    	at android.content.res.ResourcesImpl.loadXmlDrawable(ResourcesImpl.java:907)
                                                                                                    	at android.content.res.ResourcesImpl.loadDrawableForCookie(ResourcesImpl.java:861)
                                                                                                    	... 37 more
                                                                                                    Caused by: java.lang.ClassNotFoundException: Didn't find class "x" on path: DexPathList[[zip file "/data/app/~~JJPzuCKIrqWmDeUI8NSpqw==/com.example.dynamicfeaturesresourceshrinker-rSTCmERGJ999I4e_JFKBuw==/base.apk", zip file "/data/app/~~JJPzuCKIrqWmDeUI8NSpqw==/com.example.dynamicfeaturesresourceshrinker-rSTCmERGJ999I4e_JFKBuw==/split_dynamicfeature.apk"],nativeLibraryDirectories=[/data/app/~~JJPzuCKIrqWmDeUI8NSpqw==/com.example.dynamicfeaturesresourceshrinker-rSTCmERGJ999I4e_JFKBuw==/lib/x86_64, /system/lib64, /system_ext/lib64]]
                                                                                                    	at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:259)
                                                                                                    	at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
                                                                                                    	at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
                                                                                                    	at android.graphics.drawable.DrawableInflater.inflateFromClass(DrawableInflater.java:200)

The issue is present both the old and new resource shrinkers. So this issue doesn't appear to be related to b/237783271 as that particular issue isn't present in the old resource shrinker.

The resource that is being reported as android.content.res.Resources$NotFoundException exists within the APK's resource table and as a file, however the contents are shrunk (empty tag xml file). In the repro case the drawable resource is declared and by an app compat library called by the MainActivity in the app (base module).

Comments

lu...@google.com <lu...@google.com> #2Aug 23, 2022 10:06AM

Assigned to iu...@google.com.

Thank you for the report and the supplied dump with the reproduction. I can confirm that the NPE is also present on HEAD, and I will look into it.

Quite a few of the class files in the dump has malformed inner-class attribute, where R8 reports e.g.:

Info in /tmp/tmpo67ucguh/program.jar:ofifmwrrhhmodsc/ψξψξψξξ.class:
Malformed inner-class attribute:
	outerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ
	innerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ$ψξξψξξξ
	innerName: ψξψξψξξ$ψξξψξξξ

These are ignored, so they should not be the reason for the NPE, but something to also look into.

iu...@google.com <iu...@google.com> #3Aug 25, 2022 04:07PM

Project: r8
Branch: main

commit e59500ca4445f5fb5d2ccc1114acbf66df11d196
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:55 2023

Insert patched frame instructions in the right place

Fixes:

b/274337639

Change-Id: Iae204ed529f9af5bf5fa3eaacba45128dfa6fd9e

M src/main/java/com/android/tools/r8/graph/LazyCfCode.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77390

lu...@google.com <lu...@google.com> #4Aug 25, 2022 04:25PM

Project: r8
Branch: main

commit 780c2e83c8c033e7594d61894fa1b3dbcad6630b
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:13 2023

Add reproduction of

b/274337639

Bug:

b/274337639

Change-Id: I7573883d6a649eed47b10d7bf0cdea2e11710268

M build.gradle
M src/main/java/com/android/tools/r8/cf/code/frame/UninitializedNew.java
A src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77389

DynamicFeaturesFailWithResourceShrinking.zip

594 KB

Download

sh...@adobe.com <sh...@adobe.com> #5Sep 16, 2022 09:12AM

I will backport this to the 8.0 and 4.0 branches.

am...@zee.com <am...@zee.com> #6Sep 28, 2022 07:13AM

Thank you very much for taking a look at this!

Is this fix related to the nullpointer or the malformed inner-class attributes ?

Do you have a separated ticket for it? Could you share it?

na...@gtempaccount.com <na...@gtempaccount.com> #7Oct 6, 2022 07:20AM

Project: r8
Branch: 4.0

commit 6edb00fb23e41b28d4794cfa69d706d5c5aa3fba
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:55:01 2023

Version 4.0.56

Bug:

b/274337639

Change-Id: I88a20fc922ce892d38fa3a34f9a3f1f4714354ae

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77447

lu...@google.com <lu...@google.com> #8Oct 6, 2022 08:31AM

Marked as fixed.

Project: r8
Branch: 4.0

commit d9215af3b02f64d1207b9ebd63a6925229307b9d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:50 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

https://r8-review.googlesource.com/77446

sh...@adobe.com <sh...@adobe.com> #9Oct 22, 2022 09:23AM

Project: r8
Branch: 4.0

commit 4fda9b9062c871ba0e31cb68d1518b13b993692f
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:33 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77445

ab...@gmail.com <ab...@gmail.com> #10Nov 15, 2022 06:43AM

Comment has been deleted.

Message last modified on Jun 22, 2023 05:13PM

ju...@gmail.com <ju...@gmail.com> #11Jun 22, 2023 04:27PM

Project: r8
Branch: 8.0

commit 57f55fb70aa678a61f9c7ff1826fbc695faeac7d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:52:27 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

https://r8-review.googlesource.com/77443

ki...@gmail.com <ki...@gmail.com> #12Dec 18, 2024 09:34AM

Project: r8
Branch: 8.0

commit cd00c053222b06bb27fdd90bbed56af9c9ef0744
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:51:57 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77442

lu...@google.com <lu...@google.com> #13Dec 18, 2024 02:06PM

b/274337639

https://r8-review.googlesource.com/77446

dh...@gmail.com <dh...@gmail.com> #14Dec 19, 2024 08:46AM

Project: r8
Branch: 4.0

commit 4fda9b9062c871ba0e31cb68d1518b13b993692f
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:33 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77445

Issue 243399322

Description

Issue summary

Comments

lu...@google.com <lu...@google.com> #2Aug 23, 2022 10:06AM

iu...@google.com <iu...@google.com> #3Aug 25, 2022 04:07PM

lu...@google.com <lu...@google.com> #4Aug 25, 2022 04:25PM

sh...@adobe.com <sh...@adobe.com> #5Sep 16, 2022 09:12AM

am...@zee.com <am...@zee.com> #6Sep 28, 2022 07:13AM

na...@gtempaccount.com <na...@gtempaccount.com> #7Oct 6, 2022 07:20AM

lu...@google.com <lu...@google.com> #8Oct 6, 2022 08:31AM

sh...@adobe.com <sh...@adobe.com> #9Oct 22, 2022 09:23AM

ab...@gmail.com <ab...@gmail.com> #10Nov 15, 2022 06:43AM

ju...@gmail.com <ju...@gmail.com> #11Jun 22, 2023 04:27PM

ki...@gmail.com <ki...@gmail.com> #12Dec 18, 2024 09:34AM

lu...@google.com <lu...@google.com> #13Dec 18, 2024 02:06PM

dh...@gmail.com <dh...@gmail.com> #14Dec 19, 2024 08:46AM

Add comment

Issue metadata