Using dynamic features and resource shrinking cause runtime crash [243399322]

Fixed

Bug

Status Update

No update yet.

Description

lu...@google.com

created issue #1

Aug 22, 2022 05:17PM

To reproduce:

Create a new project (issue present in 7.4.0-alpha09)
Add a dynamic feature module
Enable resource shrinking for debug / build a release
Deploy to device
Runtime error on device

Sample Runtime exception:

 java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.dynamicfeaturesresourceshrinker/com.example.dynamicfeaturesresourceshrinker.MainActivity}: android.content.res.Resources$NotFoundException: Drawable com.example.dynamicfeaturesresourceshrinker:drawable/abc_vector_test with resource ID #0x7f070055
                                                                                                    	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3707)
                                                                                                    	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3844)
                                                                                                    	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
                                                                                                    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2315)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:201)
                                                                                                    	at android.os.Looper.loop(Looper.java:288)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:7929)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
                                                                                                    Caused by: android.content.res.Resources$NotFoundException: Drawable com.example.dynamicfeaturesresourceshrinker:drawable/abc_vector_test with resource ID #0x7f070055
                                                                                                    Caused by: android.content.res.Resources$NotFoundException: File res/drawable/abc_vector_test.xml from drawable resource ID #0x7f070055
                                                                                                    	at android.content.res.ResourcesImpl.loadDrawableForCookie(ResourcesImpl.java:875)
                                                                                                    	at android.content.res.ResourcesImpl.loadDrawable(ResourcesImpl.java:669)
                                                                                                    	at android.content.res.Resources.loadDrawable(Resources.java:1002)
                                                                                                    	at android.content.res.Resources.getDrawableForDensity(Resources.java:992)
                                                                                                    	at android.content.res.Resources.getDrawable(Resources.java:931)
                                                                                                    	at android.content.Context.getDrawable(Context.java:810)
                                                                                                    	at androidx.core.content.ContextCompat$Api21Impl.getDrawable(ContextCompat.java:864)
                                                                                                    	at androidx.core.content.ContextCompat.getDrawable(ContextCompat.java:483)
                                                                                                    	at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:148)
                                                                                                    	at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:136)
                                                                                                    	at androidx.appcompat.widget.ResourceManagerInternal.checkVectorDrawableSetup(ResourceManagerInternal.java:493)
                                                                                                    	at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:141)
                                                                                                    	at androidx.appcompat.widget.AppCompatDrawableManager.getDrawable(AppCompatDrawableManager.java:480)
                                                                                                    	at androidx.appcompat.widget.TintTypedArray.getDrawableIfKnown(TintTypedArray.java:93)
                                                                                                    	at androidx.appcompat.app.AppCompatDelegateImpl.attachToWindow(AppCompatDelegateImpl.java:803)
                                                                                                    	at androidx.appcompat.app.AppCompatDelegateImpl.ensureWindow(AppCompatDelegateImpl.java:779)
                                                                                                    	at androidx.appcompat.app.AppCompatDelegateImpl.onCreate(AppCompatDelegateImpl.java:506)
                                                                                                    	at androidx.appcompat.app.AppCompatActivity$2.onContextAvailable(AppCompatActivity.java:131)
                                                                                                    	at androidx.activity.contextaware.ContextAwareHelper.dispatchOnContextAvailable(ContextAwareHelper.java:99)
                                                                                                    	at androidx.activity.ComponentActivity.onCreate(ComponentActivity.java:352)
                                                                                                    	at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:217)
                                                                                                    	at com.example.dynamicfeaturesresourceshrinker.MainActivity.onCreate(MainActivity.kt:20)
                                                                                                    	at android.app.Activity.performCreate(Activity.java:8290)
                                                                                                    	at android.app.Activity.performCreate(Activity.java:8269)
                                                                                                    	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1384)
                                                                                                    	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3688)
                                                                                                    	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3844)
                                                                                                    	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101)
2022-08-22 17:32:27.796  6108-6133  libEGL                  com...namicfeaturesresourceshrinker  D  loaded /vendor/lib64/egl/libGLESv2_emulation.so
2022-08-22 17:32:27.797  6108-6108  AndroidRuntime          com...namicfeaturesresourceshrinker  E  	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
                                                                                                    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2315)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:201)
                                                                                                    	at android.os.Looper.loop(Looper.java:288)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:7929)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
                                                                                                    Caused by: android.view.InflateException: Class not found x
                                                                                                    	at android.graphics.drawable.DrawableInflater.inflateFromClass(DrawableInflater.java:219)
                                                                                                    	at android.graphics.drawable.DrawableInflater.inflateFromXmlForDensity(DrawableInflater.java:138)
                                                                                                    	at android.graphics.drawable.Drawable.createFromXmlInnerForDensity(Drawable.java:1394)
                                                                                                    	at android.graphics.drawable.Drawable.createFromXmlForDensity(Drawable.java:1355)
                                                                                                    	at android.content.res.ResourcesImpl.loadXmlDrawable(ResourcesImpl.java:907)
                                                                                                    	at android.content.res.ResourcesImpl.loadDrawableForCookie(ResourcesImpl.java:861)
                                                                                                    	... 37 more
                                                                                                    Caused by: java.lang.ClassNotFoundException: Didn't find class "x" on path: DexPathList[[zip file "/data/app/~~JJPzuCKIrqWmDeUI8NSpqw==/com.example.dynamicfeaturesresourceshrinker-rSTCmERGJ999I4e_JFKBuw==/base.apk", zip file "/data/app/~~JJPzuCKIrqWmDeUI8NSpqw==/com.example.dynamicfeaturesresourceshrinker-rSTCmERGJ999I4e_JFKBuw==/split_dynamicfeature.apk"],nativeLibraryDirectories=[/data/app/~~JJPzuCKIrqWmDeUI8NSpqw==/com.example.dynamicfeaturesresourceshrinker-rSTCmERGJ999I4e_JFKBuw==/lib/x86_64, /system/lib64, /system_ext/lib64]]
                                                                                                    	at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:259)
                                                                                                    	at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
                                                                                                    	at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
                                                                                                    	at android.graphics.drawable.DrawableInflater.inflateFromClass(DrawableInflater.java:200)

The issue is present both the old and new resource shrinkers. So this issue doesn't appear to be related to b/237783271 as that particular issue isn't present in the old resource shrinker.

The resource that is being reported as android.content.res.Resources$NotFoundException exists within the APK's resource table and as a file, however the contents are shrunk (empty tag xml file). In the repro case the drawable resource is declared and by an app compat library called by the MainActivity in the app (base module).

Comments

lu...@google.com <lu...@google.com> #2Aug 23, 2022 10:06AM

Assigned to iu...@google.com.

Will be this fix also part of 4.2 please?

iu...@google.com <iu...@google.com> #3Aug 25, 2022 04:07PM

for the "out" bundle issue, this seems indeed an issue. for the second one reported adding "debugUpdateAPKArtifact" to the path, this WAI as there can more more than one transformer and we need to automatically separate them so they do not use the same output folder. for #3, I will look at it but it might be difficult to change it at this time.

lu...@google.com <lu...@google.com> #4Aug 25, 2022 04:25PM

I understand that if there is more transformer is necessary to make every folder different, but there is the main problem, that the final one (last transform) is inside of the intermediate folder. The last transformation should end in the standard location, right? Maybe also with the default name not?

DynamicFeaturesFailWithResourceShrinking.zip

594 KB

Download

sh...@adobe.com <sh...@adobe.com> #5Sep 16, 2022 09:12AM

Hello, this is a P1 S1 issue for a while now, and it's blocking us from upgrading to AGP 4.2 and further. What's the current status? And do you have plans to backport it to 4.2.x?

am...@zee.com <am...@zee.com> #6Sep 28, 2022 07:13AM

no we don't have a plan to backport this. why is this blocking you from upgrading ?

na...@gtempaccount.com <na...@gtempaccount.com> #7Oct 6, 2022 07:20AM

We sign apk's and bundles via internal service, and i don't know another way to interact with artifacts; Yesterday i ended up with some ugly workaround: https://github.com/avito-tech/avito-android/pull/1085/files#diff-b898cc20fedebe394439bb37ffb91d3366a1f9a6d359dbdebca79af8a079f911 I'd be glad if you'll point me out how can it be done better.

lu...@google.com <lu...@google.com> #8Oct 6, 2022 08:31AM

Marked as fixed.

I commented on the merge request but to summarize :

you can set your signing tasks output folder to wherever you need to be :

artifacts.use(target.tasks.signedApkTaskProvider(this)).configure { signedDirProperty.set(File("/path/to/where/you/want/your/signed/files")) }

if you don't set it, then we will set a directory automatically.

sh...@adobe.com <sh...@adobe.com> #9Oct 22, 2022 09:23AM

Thanks, Jerome!

ab...@gmail.com <ab...@gmail.com> #10Nov 15, 2022 06:43AM

Comment has been deleted.

Message last modified on Jun 22, 2023 05:13PM

ju...@gmail.com <ju...@gmail.com> #11Jun 22, 2023 04:27PM

correction, I was not correct about FILE being correct.

Instead of :

updatedArtifact: /usr/local/google/home/jedo/src/studio-main/out/apiTests/Kotlin/bugTest/app/build/outputs/bundle/debug/app-debug.aab

it should be

updatedArtifact: /usr/local/google/home/jedo/src/studio-main/out/apiTests/Kotlin/bugTest/app/build/outputs/app-debug.aab
``

ki...@gmail.com <ki...@gmail.com> #12Dec 18, 2024 09:34AM

Two requests are created as they are API changes b/241581686 (set artifact name for transformation) and b/241582907 (change string to OutputFile)

lu...@google.com <lu...@google.com> #13Dec 18, 2024 02:06PM

Fix will be available in Android Studio F/AGP 8.0 Canary 2 Release

dh...@gmail.com <dh...@gmail.com> #14Dec 19, 2024 08:46AM

I tried to use it and at first look, it looks like everything works as expected. Thanks!