SplashScreen - icon view is null [243457485]

Fixed

Bug

Status Update

No update yet.

Description

ra...@gmail.com

created issue #1

Aug 23, 2022 12:35PM

Component used: SplashScreen Version used: 1.0.0-rc01 Devices/Android versions reproduced on: 100% Android 13

Artifact used: androidx.core:core-splashscreen Theme used: Theme.SplashScreen Crash Reproducible: False Devices/Android versions reproduced on: Pixel 4a (5G) (Android 13), Pixel 6/6 PRO

crash logs:

Fatal Exception: java.lang.NullPointerException at androidx.core.splashscreen.SplashScreenViewProvider$ViewImpl31.getIconView(SplashScreenViewProvider.kt:125) at androidx.core.splashscreen.SplashScreenViewProvider.getIconView(SplashScreenViewProvider.java:66) at fm.dice.splash.presentation.views.SplashActivity.triggerViewExitAnimation$lambda-0(SplashActivity.java:101) at fm.dice.discount.presentation.views.EventClaimCodeActivity$$InternalSyntheticLambda$2$e3b1050cf4cd59cef767f70a2238c7fe944dade6077bc18a7c181ca18936655c$0.onAnimationUpdate$bridge(EventClaimCodeActivity.java:9) at android.animation.ValueAnimator.animateValue(ValueAnimator.java:1653) at android.animation.ValueAnimator.setCurrentFraction(ValueAnimator.java:775) at android.animation.ValueAnimator.setCurrentPlayTime(ValueAnimator.java:738) at android.animation.ValueAnimator.start(ValueAnimator.java:1170) at android.animation.ValueAnimator.start(ValueAnimator.java:1189) at fm.dice.splash.presentation.views.SplashActivity.triggerViewExitAnimation(SplashActivity.java:117) at fm.dice.splash.presentation.views.SplashActivity.access$triggerViewExitAnimation(SplashActivity.java:49) at fm.dice.splash.presentation.views.SplashActivity$onCreate$1.onSplashScreenExit(SplashActivity.kt:83) at androidx.core.splashscreen.SplashScreen$Impl31.setOnExitAnimationListener$lambda-0(SplashScreen.kt:459) at androidx.core.splashscreen.SplashScreen$Impl31.$r8$lambda$_AQ1xSddL7-kLq4WrGTBd4lTQaY(SplashScreen.kt:29) at androidx.core.splashscreen.SplashScreen$Impl31$$InternalSyntheticLambda$1$761acc8e6019f840a6c78651dfd204d1aa5d02a4d0503ed9e876fedb200d42e5$0.onSplashScreenExit(SplashScreen.java:4) at android.window.SplashScreen$SplashScreenManagerGlobal.dispatchOnExitAnimation(SplashScreen.java:271) at android.window.SplashScreen$SplashScreenManagerGlobal.handOverSplashScreenView(SplashScreen.java:258) at android.app.ActivityThread.reportSplashscreenViewShown(ActivityThread.java:4147) at android.app.ActivityThread.lambda$syncTransferSplashscreenViewTransaction$1$android-app-ActivityThread(ActivityThread.java:4164) at android.app.ActivityThread$$ExternalSyntheticLambda5.run(ActivityThread.java:6) at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1231) at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1239) at android.view.Choreographer.doCallbacks(Choreographer.java:899) at android.view.Choreographer.doFrame(Choreographer.java:827) at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1214) at android.os.Handler.handleCallback(Handler.java:942) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loopOnce(Looper.java:201) at android.os.Looper.loop(Looper.java:288) at android.app.ActivityThread.main(ActivityThread.java:7898) at java.lang.reflect.Method.invoke(Method.java) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

Comments

wi...@google.com <wi...@google.com> #2Aug 24, 2022 03:11AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ra...@gmail.com <ra...@gmail.com> #3Aug 24, 2022 08:25AM

right! but I see that value never returns null & the app crashed in API 31 & above.

reason: in the ViewImpl31 below line is accessing the value using "!!" and iconView also not nullable view override val iconView get() = platformView.iconView!!

ra...@gmail.com <ra...@gmail.com> #4Aug 25, 2022 08:56AM

hey team, do you need more info or can you recommend something?

wi...@google.com <wi...@google.com> #5Aug 25, 2022 08:59AM

No, this should fix from the compat library.
Maybe targeting for next release.

ra...@gmail.com <ra...@gmail.com> #6Aug 25, 2022 09:26AM

alright 👍🏻

ap...@google.com <ap...@google.com> #7Sep 20, 2022 03:13AM

Project: platform/frameworks/support
Branch: androidx-main

commit e231abf4623dd97b75b35ded10e6016ca57e8668
Author: wilsonshih <wilsonshih@google.com>
Date: Wed Aug 24 14:38:04 2022

Create empty view for SplashScreenViewProvider#iconView if needed

There can return nullable for SplashScreenView#getIconView, which
allow developers to customize exit animation for solid color splash
screen.

Bug: 243457485
Test: SplashscreenParametrizedTest SplashScreenTests

Change-Id: I4c323d4f9307af9759da548dcadcd7b8318ecf60

M core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreenViewProvider.kt

https://android-review.googlesource.com/2194437

wi...@google.com <wi...@google.com> #8Sep 20, 2022 03:13AM

Marked as fixed.

Fixed in library, please wait for next release.

da...@allaboutapps.at <da...@allaboutapps.at> #9Oct 17, 2022 12:26PM

It seems that we can mitigate the issue by setting the preferred style to icon_preferred in the theme (while waiting for this to get fixed)

<item name="android:windowSplashScreenBehavior">icon_preferred</item>

At least this way it shouldn't crash with a NPE

gb...@jeniusbank.com <gb...@jeniusbank.com> #10Nov 8, 2022 07:27PM

#9 doesn't fix the issue

gb...@manubank.com <gb...@manubank.com> #11Feb 9, 2023 11:21PM

will you ever release the fix? Splash screen library seems unmaintained and haven't seen a release for 6+ months.

se...@gmail.com <se...@gmail.com> #12Feb 21, 2023 04:14PM

So, guys? What are you waiting for? Please, release the fixed version of this library! You have NPE in your library (google library!!!)

kb...@jaguarlandrover.com <kb...@jaguarlandrover.com> #13Feb 27, 2023 10:39PM

Hey,

If it is fixed since September please consider releasing a minor or patch version.

ca...@greenfly.com <ca...@greenfly.com> #14Mar 18, 2023 03:48PM

Comment has been deleted.

Message last modified on Mar 18, 2023 03:48PM

wi...@google.com <wi...@google.com> #15Mar 20, 2023 02:14AM

https://developer.android.com/jetpack/androidx/releases/core#core-splashscreen-1.1.0-alpha01

je...@veo.co <je...@veo.co> #16Aug 22, 2023 07:25AM

Hi, I got the same crash after updating my application to target SDK level 33, after changing my splash screen dependency to the 1.1.0-alpha01 version I get this error:

Dependency 'androidx.core:core-splashscreen:1.1.0-alpha01' requires libraries and applications that
depend on it to compile against codename "UpsideDownCake" of the
Android APIs.

:app is currently compiled against android-33.

Recommended action: Use a different version of dependency 'androidx.core:core-splashscreen:1.1.0-alpha01',
or set compileSdkPreview to "UpsideDownCake" in your build.gradle
file if you intend to experiment with that preview SDK.

Any idea why this is happening?

wi...@google.com <wi...@google.com> #17Aug 22, 2023 08:19AM

Reassigned to al...@google.com.

Hey @alanv, any idea why the release said This compiles against Android UDC DP1 SDK

al...@google.com <al...@google.com> #18Aug 22, 2023 01:20PM

Reassigned to wi...@google.com.

Releases from androidx-platform-dev during the Android 14 pre-release timeline were built against preview SDKs and can only be compiled against the same preview SDKs.

You will need to run a new release from androidx-main.

je...@veo.co <je...@veo.co> #19Aug 23, 2023 09:02AM

What's the timeline on releasing the correct version of the patch?

wi...@google.com <wi...@google.com> Aug 23, 2023 09:30AM

Status: Assigned (reopened)

an...@gmail.com <an...@gmail.com> #20Aug 27, 2023 08:40PM

Hi, I got the same issue.

ap...@google.com <ap...@google.com> #21Aug 30, 2023 01:55AM

Project: platform/frameworks/support
Branch: androidx-main

commit 6ec30b56541bdc314f59f6564ca5122b535719c7
Author: wilsonshih <wilsonshih@google.com>
Date: Tue Aug 29 10:24:39 2023

Bump library version for core-splashscreen to 1.1.0-alpha02

Bug: 243457485
Test: NA
Change-Id: I7fc30ffe933609711e7f430238ede1c7565f14a3

M libraryversions.toml

https://android-review.googlesource.com/2730273

wi...@google.com <wi...@google.com> #22Aug 30, 2023 03:05AM

1.1.0-alpha02 scheduled on September 7, 2023

wi...@google.com <wi...@google.com> #23Sep 4, 2023 02:11AM

Comment has been deleted.

Message last modified on Sep 6, 2023 06:34AM

wi...@google.com <wi...@google.com> Sep 11, 2023 02:21AM

Marked as fixed.

ru...@gmail.com <ru...@gmail.com> #24Sep 13, 2023 11:19AM

Is there any official estimated time to release a stable version including this fix? I don't want to have an alpha version in my production app. Or should I stop using the Splashscreen library?

ni...@flycatcherapps.com <ni...@flycatcherapps.com> #25Mar 5, 2024 09:50AM

What is the estimated time to see this fix in production? Splash screen core 1.1.0-alpha02 was released on Sep 06, 2023 and no update since that time.

na...@google.com <na...@google.com> #26Apr 17, 2024 05:17PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.core:core-splashscreen:1.2.0-alpha01

ro...@gmail.com <ro...@gmail.com> #27Sep 2, 2024 05:27PM

Is there any updates ? still got null(iconView) Android 13

ro...@gmail.com <ro...@gmail.com> #28Sep 2, 2024 05:46PM

Android 12 also has the same issue

wi...@google.com <wi...@google.com> #29Sep 3, 2024 02:17AM

Re #27, mind provide a sample app? and what's version of library?

rh...@gmail.com <rh...@gmail.com> #30Sep 24, 2024 05:45PM

Having the same issue.. can this be released in a stable release? Our team would definitely prefer not to opt into an alpha version for use in an enterprise production environment.

Message last modified on Sep 25, 2024 05:45PM