SplashScreen - icon view is null [243457485]

Fixed

Bug

Status Update

No update yet.

Description

ra...@gmail.com

created issue #1

Aug 23, 2022 12:35PM

Component used: SplashScreen Version used: 1.0.0-rc01 Devices/Android versions reproduced on: 100% Android 13

Artifact used: androidx.core:core-splashscreen Theme used: Theme.SplashScreen Crash Reproducible: False Devices/Android versions reproduced on: Pixel 4a (5G) (Android 13), Pixel 6/6 PRO

crash logs:

Fatal Exception: java.lang.NullPointerException at androidx.core.splashscreen.SplashScreenViewProvider$ViewImpl31.getIconView(SplashScreenViewProvider.kt:125) at androidx.core.splashscreen.SplashScreenViewProvider.getIconView(SplashScreenViewProvider.java:66) at fm.dice.splash.presentation.views.SplashActivity.triggerViewExitAnimation$lambda-0(SplashActivity.java:101) at fm.dice.discount.presentation.views.EventClaimCodeActivity$$InternalSyntheticLambda$2$e3b1050cf4cd59cef767f70a2238c7fe944dade6077bc18a7c181ca18936655c$0.onAnimationUpdate$bridge(EventClaimCodeActivity.java:9) at android.animation.ValueAnimator.animateValue(ValueAnimator.java:1653) at android.animation.ValueAnimator.setCurrentFraction(ValueAnimator.java:775) at android.animation.ValueAnimator.setCurrentPlayTime(ValueAnimator.java:738) at android.animation.ValueAnimator.start(ValueAnimator.java:1170) at android.animation.ValueAnimator.start(ValueAnimator.java:1189) at fm.dice.splash.presentation.views.SplashActivity.triggerViewExitAnimation(SplashActivity.java:117) at fm.dice.splash.presentation.views.SplashActivity.access$triggerViewExitAnimation(SplashActivity.java:49) at fm.dice.splash.presentation.views.SplashActivity$onCreate$1.onSplashScreenExit(SplashActivity.kt:83) at androidx.core.splashscreen.SplashScreen$Impl31.setOnExitAnimationListener$lambda-0(SplashScreen.kt:459) at androidx.core.splashscreen.SplashScreen$Impl31.$r8$lambda$_AQ1xSddL7-kLq4WrGTBd4lTQaY(SplashScreen.kt:29) at androidx.core.splashscreen.SplashScreen$Impl31$$InternalSyntheticLambda$1$761acc8e6019f840a6c78651dfd204d1aa5d02a4d0503ed9e876fedb200d42e5$0.onSplashScreenExit(SplashScreen.java:4) at android.window.SplashScreen$SplashScreenManagerGlobal.dispatchOnExitAnimation(SplashScreen.java:271) at android.window.SplashScreen$SplashScreenManagerGlobal.handOverSplashScreenView(SplashScreen.java:258) at android.app.ActivityThread.reportSplashscreenViewShown(ActivityThread.java:4147) at android.app.ActivityThread.lambda$syncTransferSplashscreenViewTransaction$1$android-app-ActivityThread(ActivityThread.java:4164) at android.app.ActivityThread$$ExternalSyntheticLambda5.run(ActivityThread.java:6) at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1231) at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1239) at android.view.Choreographer.doCallbacks(Choreographer.java:899) at android.view.Choreographer.doFrame(Choreographer.java:827) at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1214) at android.os.Handler.handleCallback(Handler.java:942) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loopOnce(Looper.java:201) at android.os.Looper.loop(Looper.java:288) at android.app.ActivityThread.main(ActivityThread.java:7898) at java.lang.reflect.Method.invoke(Method.java) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

Comments

wi...@google.com <wi...@google.com> #2Aug 24, 2022 03:11AM

The issue is reproducible with core-ktx 1.2.0 and 1.3.0-rc01.

ra...@gmail.com <ra...@gmail.com> #3Aug 24, 2022 08:25AM

The Typeface.weight is not a weight of the underlying font file. It is a display style. On older APIs, the display style is adjusted if the Typeface is created from single font. However, after moving to CustomFallbackBuilder, that adjustment is removed since it can crate Typeface from multiple style font files.

Looks like it is good to set display style by ResourcesCompat.getFont for backward compatibility.

ra...@gmail.com <ra...@gmail.com> #4Aug 25, 2022 08:56AM

Hi Nona,

Can you please schedule a release after you merge the fix?

wi...@google.com <wi...@google.com> #5Aug 25, 2022 08:59AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3d6aa2e9b3243dcc4de1f54bd8d40339bd69cb05
Author: Seigo Nonaka <nona@google.com>
Date: Wed May 27 17:38:05 2020

Adjust the Typeface display style with the style of given font

This behavir is implicitly done by Typeface.Builder and
Typeface.createXXX function but not to be done by
Typeface.CustomFallbackBuilder since it is designed to be working
with multiple font files which has different style.

Looks like the style argument is ignored on older API implementation.

Bug: 156853883
Bug: 152023266
Test: ResourcesCompatTest#testGetFont_adjustDisplayStyle passes on 29
Test: ./gradlew core:core:connectedAndroidTest on API 29, 28, 23
Change-Id: I3a377c339a7aed50973cf11df86ddf0069f4ec25

A core/core/src/androidTest/assets/fonts/thin_italic.ttf
A core/core/src/androidTest/assets/fonts/thin_italic.ttx
M core/core/src/androidTest/java/androidx/core/content/res/ResourcesCompatTest.java
A core/core/src/androidTest/res/font/thin_italic.ttf
M core/core/src/main/java/androidx/core/graphics/TypefaceCompatApi29Impl.java

https://android-review.googlesource.com/1318947

ra...@gmail.com <ra...@gmail.com> #6Aug 25, 2022 09:26AM

The following changes were cherrypicked through Coastguard Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6222780589080576/#/history/all) Changes: aosp/1318947

ap...@google.com <ap...@google.com> #7Sep 20, 2022 03:13AM

Any way I can tell what version this will land in?

wi...@google.com <wi...@google.com> #8Sep 20, 2022 03:13AM

Marked as fixed.

should be in 1.5.0-alpha1 https://developer.android.com/jetpack/androidx/releases/core#1.5.0-alpha01

da...@allaboutapps.at <da...@allaboutapps.at> #9Oct 17, 2022 12:26PM

Great—works as expected, thanks!

gb...@jeniusbank.com <gb...@jeniusbank.com> #10Nov 8, 2022 07:27PM

#9 doesn't fix the issue

gb...@manubank.com <gb...@manubank.com> #11Feb 9, 2023 11:21PM

will you ever release the fix? Splash screen library seems unmaintained and haven't seen a release for 6+ months.

se...@gmail.com <se...@gmail.com> #12Feb 21, 2023 04:14PM

So, guys? What are you waiting for? Please, release the fixed version of this library! You have NPE in your library (google library!!!)

kb...@jaguarlandrover.com <kb...@jaguarlandrover.com> #13Feb 27, 2023 10:39PM

Hey,

If it is fixed since September please consider releasing a minor or patch version.

ca...@greenfly.com <ca...@greenfly.com> #14Mar 18, 2023 03:48PM

Comment has been deleted.

Message last modified on Mar 18, 2023 03:48PM

wi...@google.com <wi...@google.com> #15Mar 20, 2023 02:14AM

https://developer.android.com/jetpack/androidx/releases/core#core-splashscreen-1.1.0-alpha01

je...@veo.co <je...@veo.co> #16Aug 22, 2023 07:25AM

Hi, I got the same crash after updating my application to target SDK level 33, after changing my splash screen dependency to the 1.1.0-alpha01 version I get this error:

Dependency 'androidx.core:core-splashscreen:1.1.0-alpha01' requires libraries and applications that
depend on it to compile against codename "UpsideDownCake" of the
Android APIs.

:app is currently compiled against android-33.

Recommended action: Use a different version of dependency 'androidx.core:core-splashscreen:1.1.0-alpha01',
or set compileSdkPreview to "UpsideDownCake" in your build.gradle
file if you intend to experiment with that preview SDK.

Any idea why this is happening?

wi...@google.com <wi...@google.com> #17Aug 22, 2023 08:19AM

Reassigned to al...@google.com.

Hey @alanv, any idea why the release said This compiles against Android UDC DP1 SDK

al...@google.com <al...@google.com> #18Aug 22, 2023 01:20PM

Reassigned to wi...@google.com.

Releases from androidx-platform-dev during the Android 14 pre-release timeline were built against preview SDKs and can only be compiled against the same preview SDKs.

You will need to run a new release from androidx-main.

je...@veo.co <je...@veo.co> #19Aug 23, 2023 09:02AM

What's the timeline on releasing the correct version of the patch?

wi...@google.com <wi...@google.com> Aug 23, 2023 09:30AM

Status: Assigned (reopened)

an...@gmail.com <an...@gmail.com> #20Aug 27, 2023 08:40PM

Hi, I got the same issue.

ap...@google.com <ap...@google.com> #21Aug 30, 2023 01:55AM

Project: platform/frameworks/support
Branch: androidx-main

commit 6ec30b56541bdc314f59f6564ca5122b535719c7
Author: wilsonshih <wilsonshih@google.com>
Date: Tue Aug 29 10:24:39 2023

Bump library version for core-splashscreen to 1.1.0-alpha02

Bug: 243457485
Test: NA
Change-Id: I7fc30ffe933609711e7f430238ede1c7565f14a3

M libraryversions.toml

https://android-review.googlesource.com/2730273

wi...@google.com <wi...@google.com> #22Aug 30, 2023 03:05AM

1.1.0-alpha02 scheduled on September 7, 2023

wi...@google.com <wi...@google.com> #23Sep 4, 2023 02:11AM

Comment has been deleted.

Message last modified on Sep 6, 2023 06:34AM

wi...@google.com <wi...@google.com> Sep 11, 2023 02:21AM

Marked as fixed.

ru...@gmail.com <ru...@gmail.com> #24Sep 13, 2023 11:19AM

Is there any official estimated time to release a stable version including this fix? I don't want to have an alpha version in my production app. Or should I stop using the Splashscreen library?

ni...@flycatcherapps.com <ni...@flycatcherapps.com> #25Mar 5, 2024 09:50AM

What is the estimated time to see this fix in production? Splash screen core 1.1.0-alpha02 was released on Sep 06, 2023 and no update since that time.

na...@google.com <na...@google.com> #26Apr 17, 2024 05:17PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.core:core-splashscreen:1.2.0-alpha01

ro...@gmail.com <ro...@gmail.com> #27Sep 2, 2024 05:27PM

Is there any updates ? still got null(iconView) Android 13

ro...@gmail.com <ro...@gmail.com> #28Sep 2, 2024 05:46PM

Android 12 also has the same issue

wi...@google.com <wi...@google.com> #29Sep 3, 2024 02:17AM

Re #27, mind provide a sample app? and what's version of library?

rh...@gmail.com <rh...@gmail.com> #30Sep 24, 2024 05:45PM

Having the same issue.. can this be released in a stable release? Our team would definitely prefer not to opt into an alpha version for use in an enterprise production environment.

Message last modified on Sep 25, 2024 05:45PM