[Feature request] Can JankStats library provide total frame duration (for API >= 24) [243694893]

Fixed

Bug

Status Update

No update yet.

Description

ar...@pinterest.com

created issue #1

Aug 24, 2022 08:46PM

androidx.metrics module used: androidx.metrics:metrics-performance androidx.metrics version used: 1.0.0-alpha02 Devices/Android versions reproduced on: All versions

When you encountered this bug:

This is a feature request. Creating bug ticket here as there is no "Feature request" template for "androidx -> Metrics"

Request for including total frame duration field in FrameData for API 24.

It would have been helpful if JankStats library could provide total frame duration (for API >= 24). We were trying to replace our legacy implementation with the JankStats library. In our legacy implementation, we use total frame duration; but the data class FrameData does not contain total frame duration. Providing total frame duration for API 24 & above would give more flexibility to use this library (if someone wants to migrate from the legacy implementation to the JankStats).

More Details: Could you include a field (totalFrameDuration) in the next alpha release?

    frameStartNanos: Long,
    frameDurationUiNanos: Long,
    val frameDurationCpuNanos: Long,
    isJank: Boolean,
    states: List<StateInfo>
) : FrameData(frameStartNanos, frameDurationUiNanos, isJank, states) {

It would be great if you could include the total frame duration as one of the data class values.

I saw you included frameOverrunNanos (which is derived from total frame duration) for API 31

    frameStartNanos: Long,
    frameDurationUiNanos: Long,
    frameDurationCpuNanos: Long,
    val frameOverrunNanos: Long,
    isJank: Boolean,
    states: List<StateInfo>

) : FrameDataApi24(frameStartNanos, frameDurationUiNanos, frameDurationCpuNanos, isJank, states) {

Comments

li...@pinterest.com <li...@pinterest.com> #2Aug 24, 2022 10:47PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

ch...@google.com <ch...@google.com> #3Aug 26, 2022 09:51PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

ch...@google.com <ch...@google.com> #4Aug 27, 2022 12:13AM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

ap...@google.com <ap...@google.com> #5Aug 29, 2022 10:06PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

ch...@google.com <ch...@google.com> Aug 29, 2022 10:08PM

Marked as fixed.

li...@pinterest.com <li...@pinterest.com> #6Aug 30, 2022 12:00AM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

ch...@google.com <ch...@google.com> #7Aug 30, 2022 11:06PM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

li...@pinterest.com <li...@pinterest.com> #8Aug 31, 2022 07:58AM

Thank you, I'll try it and check.

na...@google.com <na...@google.com> #9Apr 5, 2023 06:27PM

Hello. I have similar experience.

I'm using mlkit-language 16.1.1
I didnot meet this error until using AGP 4.2
I can get this error since using AGP 7.0
This error raised on Release build only(minimized by R8)
This error raised without obfuscation.