Fixed
Status Update
Comments
li...@pinterest.com <li...@pinterest.com> #2
The issue is reproducible with core-ktx 1.2.0 and 1.3.0-rc01.
ch...@google.com <ch...@google.com> #3
The Typeface.weight is not a weight of the underlying font file. It is a display style. On older APIs, the display style is adjusted if the Typeface is created from single font. However, after moving to CustomFallbackBuilder, that adjustment is removed since it can crate Typeface from multiple style font files.
Looks like it is good to set display style by ResourcesCompat.getFont for backward compatibility.
ch...@google.com <ch...@google.com> #4
Hi Nona,
Can you please schedule a release after you merge the fix?
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 3d6aa2e9b3243dcc4de1f54bd8d40339bd69cb05
Author: Seigo Nonaka <nona@google.com>
Date: Wed May 27 17:38:05 2020
Adjust the Typeface display style with the style of given font
This behavir is implicitly done by Typeface.Builder and
Typeface.createXXX function but not to be done by
Typeface.CustomFallbackBuilder since it is designed to be working
with multiple font files which has different style.
Looks like the style argument is ignored on older API implementation.
Bug: 156853883
Bug: 152023266
Test: ResourcesCompatTest#testGetFont_adjustDisplayStyle passes on 29
Test: ./gradlew core:core:connectedAndroidTest on API 29, 28, 23
Change-Id: I3a377c339a7aed50973cf11df86ddf0069f4ec25
A core/core/src/androidTest/assets/fonts/thin_italic.ttf
A core/core/src/androidTest/assets/fonts/thin_italic.ttx
M core/core/src/androidTest/java/androidx/core/content/res/ResourcesCompatTest.java
A core/core/src/androidTest/res/font/thin_italic.ttf
M core/core/src/main/java/androidx/core/graphics/TypefaceCompatApi29Impl.java
https://android-review.googlesource.com/1318947
Branch: androidx-master-dev
commit 3d6aa2e9b3243dcc4de1f54bd8d40339bd69cb05
Author: Seigo Nonaka <nona@google.com>
Date: Wed May 27 17:38:05 2020
Adjust the Typeface display style with the style of given font
This behavir is implicitly done by Typeface.Builder and
Typeface.createXXX function but not to be done by
Typeface.CustomFallbackBuilder since it is designed to be working
with multiple font files which has different style.
Looks like the style argument is ignored on older API implementation.
Bug: 156853883
Bug: 152023266
Test: ResourcesCompatTest#testGetFont_adjustDisplayStyle passes on 29
Test: ./gradlew core:core:connectedAndroidTest on API 29, 28, 23
Change-Id: I3a377c339a7aed50973cf11df86ddf0069f4ec25
A core/core/src/androidTest/assets/fonts/thin_italic.ttf
A core/core/src/androidTest/assets/fonts/thin_italic.ttx
M core/core/src/androidTest/java/androidx/core/content/res/ResourcesCompatTest.java
A core/core/src/androidTest/res/font/thin_italic.ttf
M core/core/src/main/java/androidx/core/graphics/TypefaceCompatApi29Impl.java
ch...@google.com <ch...@google.com>
ch...@google.com <ch...@google.com> #7
Any way I can tell what version this will land in?
na...@google.com <na...@google.com> #9
Great—works as expected, thanks!
Description
androidx.metrics
module used: androidx.metrics:metrics-performanceandroidx.metrics
version used: 1.0.0-alpha02 Devices/Android versions reproduced on: All versionsWhen you encountered this bug:
Request for including total frame duration field in
FrameData
for API 24.It would have been helpful if JankStats library could provide total frame duration (for API >= 24). We were trying to replace our legacy implementation with the JankStats library. In our legacy implementation, we use total frame duration; but the data class
FrameData
does not contain total frame duration. Providing total frame duration for API 24 & above would give more flexibility to use this library (if someone wants to migrate from the legacy implementation to the JankStats).More Details: Could you include a field (totalFrameDuration) in the next alpha release?
It would be great if you could include the total frame duration as one of the data class values.
I saw you included
frameOverrunNanos
(which is derived from total frame duration) for API 31