Fixed
Status Update
No update yet.
Comments
jb...@google.com
With this change
The things we need to tackle after this CL lands are:
- Follow up on this CL (
https://android-review.googlesource.com/c/platform/external/perfetto/+/1680145 ). The binaries checked in, include this change but currently its failing presubmits because of a compiler warning. Something primiano@ is currently looking into. - Expand trace_processor_shells ABI support to include arm, and x86_64. Remove the explicit checks for API Q.
- Remove the use of @RequiresApi(29) in MacrobenchmarkRule / Lower it to API 21, andexplicit checks for API Q.
- verifyTraceEnabled(...) does seem to cause issues on lower versions of the platform. Something we need to investigate further. This does not happen consistently though.
- Fix our perfetto trace configs. There are options that are unsupported on older versions of the platform.
- M, and N dont support several ART compilation modes. No op on them.
kr...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
commit 22fe26bc907af50d557254d406eb38469a7bb81b
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Fri Apr 16 11:15:58 2021
Add unbundled perfetto support.
With this change, we are much closer in bringing Macrobenchmarks to API 21.
The things we need to tackle after this CL lands are:
* Follow up on this CL (https://android-review.googlesource.com/c/platform/external/perfetto/+/1680145 ).
The binaries checked in, include this change but currently its failing presubmits because of a compiler warning.
Something primiano@ is currently looking into.
* Expand trace_processor_shells ABI support to include arm, and x86_64.
Remove the explicit checks for API Q.
* Remove the use of @RequiresApi(...) in MacrobenchmarkRule, and explicit checks for API Q.
* verifyTraceEnabled(...) does seem to cause issues on lower versions of the platform. Something we need to investigate further.
This does not happen consistently though.
* Fix our perfetto trace configs. There are options that are unsupported on older versions of the platform.
* M, and N dont support several ART compilation modes. No op on them.
Test: PerfettoCaptureTest is now parameterized
Bug:
Change-Id: I888fa15e02acc4f99fbf548722a11a9953988357
M benchmark/macro/build.gradle
M benchmark/macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoCaptureTest.kt
M benchmark/macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoCapture.kt
M benchmark/macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoCaptureWrapper.kt
M benchmark/macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoHelper.kt
https://android-review.googlesource.com/1675367
Branch: androidx-main
commit 22fe26bc907af50d557254d406eb38469a7bb81b
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Fri Apr 16 11:15:58 2021
Add unbundled perfetto support.
With this change, we are much closer in bringing Macrobenchmarks to API 21.
The things we need to tackle after this CL lands are:
* Follow up on this CL (
The binaries checked in, include this change but currently its failing presubmits because of a compiler warning.
Something primiano@ is currently looking into.
* Expand trace_processor_shells ABI support to include arm, and x86_64.
Remove the explicit checks for API Q.
* Remove the use of @RequiresApi(...) in MacrobenchmarkRule, and explicit checks for API Q.
* verifyTraceEnabled(...) does seem to cause issues on lower versions of the platform. Something we need to investigate further.
This does not happen consistently though.
* Fix our perfetto trace configs. There are options that are unsupported on older versions of the platform.
* M, and N dont support several ART compilation modes. No op on them.
Test: PerfettoCaptureTest is now parameterized
Bug:
Change-Id: I888fa15e02acc4f99fbf548722a11a9953988357
M benchmark/macro/build.gradle
M benchmark/macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoCaptureTest.kt
M benchmark/macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoCapture.kt
M benchmark/macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoCaptureWrapper.kt
M benchmark/macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoHelper.kt
kr...@gmail.com
Project: platform/prebuilts/androidx/traceprocessor
Branch: androidx-main
commit 9f143a6b876ef5b2be841ed2ce1be138e325bf51
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Wed Mar 31 14:49:19 2021
Add stripped perfetto and trace_processor_shell binaries.
* These binaries are built from source (https://github.com/google/perfetto )
* Build instructions arehttps://perfetto.dev/docs/contributing/build-instructions
* The config looks something like:
```
target_os = "android"
target_cpu = "arm|arm64|arm_x86_x86"
is_debug = false
monolithic_binaries = true
```
* After building, we stripped the binaries using ndk `22.1.7171670` using `/path/to/sdk/ndk/22.1.7171670/toolchains/llvm/prebuilt/linux-x86_64/<variant>-linux-android/bin/strip`
Test: ./gradlew :benchmark:integration-tests:macrobenchmark:connectedDebugAndroidTest
Bug:
Change-Id: I052b6caf214a3d0dfd101302040f6ae43bc42b22
M README.md
A perfetto/perfetto_aarch64
A perfetto/perfetto_arm
A perfetto/perfetto_x86_64
M trace_processor_shell/trace_processor_shell_aarch64
A trace_processor_shell/trace_processor_shell_arm
A trace_processor_shell/trace_processor_shell_x86_64
A traced/traced_aarch64
A traced/traced_arm
A traced/traced_x86_64
A traced_probes/traced_probes_aarch64
A traced_probes/traced_probes_arm
A traced_probes/traced_probes_x86_64
https://android-review.googlesource.com/1660781
Branch: androidx-main
commit 9f143a6b876ef5b2be841ed2ce1be138e325bf51
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Wed Mar 31 14:49:19 2021
Add stripped perfetto and trace_processor_shell binaries.
* These binaries are built from source (
* Build instructions are
* The config looks something like:
```
target_os = "android"
target_cpu = "arm|arm64|arm_x86_x86"
is_debug = false
monolithic_binaries = true
```
* After building, we stripped the binaries using ndk `22.1.7171670` using `/path/to/sdk/ndk/22.1.7171670/toolchains/llvm/prebuilt/linux-x86_64/<variant>-linux-android/bin/strip`
Test: ./gradlew :benchmark:integration-tests:macrobenchmark:connectedDebugAndroidTest
Bug:
Change-Id: I052b6caf214a3d0dfd101302040f6ae43bc42b22
M README.md
A perfetto/perfetto_aarch64
A perfetto/perfetto_arm
A perfetto/perfetto_x86_64
M trace_processor_shell/trace_processor_shell_aarch64
A trace_processor_shell/trace_processor_shell_arm
A trace_processor_shell/trace_processor_shell_x86_64
A traced/traced_aarch64
A traced/traced_arm
A traced/traced_x86_64
A traced_probes/traced_probes_aarch64
A traced_probes/traced_probes_arm
A traced_probes/traced_probes_x86_64
kr...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
commit ce3df5c24d36ac56873d13bb27a084e54e420dd7
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue Apr 20 12:16:02 2021
Expand ABI support for `perfetto_trace_processor`.
Test: ./gradlew :benchmark:benchmark-macro:connectedCheck
Bug: Bug:
Change-Id: Ic7c5579b497890b2eab8f202b41d2a2c2560c1fb
M benchmark/macro/src/androidTest/java/androidx/benchmark/macro/StartupTimingMetricTest.kt
M benchmark/macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoTraceProcessorTest.kt
M benchmark/macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoTraceProcessor.kt
https://android-review.googlesource.com/1681590
Branch: androidx-main
commit ce3df5c24d36ac56873d13bb27a084e54e420dd7
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue Apr 20 12:16:02 2021
Expand ABI support for `perfetto_trace_processor`.
Test: ./gradlew :benchmark:benchmark-macro:connectedCheck
Bug: Bug:
Change-Id: Ic7c5579b497890b2eab8f202b41d2a2c2560c1fb
M benchmark/macro/src/androidTest/java/androidx/benchmark/macro/StartupTimingMetricTest.kt
M benchmark/macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoTraceProcessorTest.kt
M benchmark/macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoTraceProcessor.kt
kr...@gmail.com
Punting from initial alpha - unfortunately, the trace signals that perfetto uses for startup metrics MetricsLogger:launchObserverNotifyIntentStarted and launching: $packageName were added in Q, so we'll need to figure out an alternative timing mechanism on older devices. Quite likely that looks like looking for the end of drawFrame on RenderThread, but coming up with a clear definition with sample traces will take some time.
jb...@google.com
Do we have a pre-Q trace handy?
kr...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
commit 7fd221c0c8f7948351293a7fbf75eef0bf698a42
Author: Chris Craik <ccraik@google.com>
Date: Fri Apr 30 17:19:22 2021
Fix output issue on API 21, suppress still-broken tests
Bug: 183129298
Test: ./gradlew benchmark:b-c:cC benchmark:b-m:cC
Shell can't access externalCacheDir (but somehow can access cacheDir)
on API 21.
Also on API 21, UiDevice.executeShellCommand doesn't capture the
output of `echo foo`. executeShellScript still partially works
(e.g. `ls` works), but we'll need more investigation to better
understand shell command limitations on that API level.
Change-Id: I2bafe8218ed50ac54cd990190d2f9a2e2364028d
M benchmark/common/src/main/java/androidx/benchmark/Outputs.kt
A benchmark/macro/src/androidTest/java/androidx/benchmark/macro/OutputsTest.kt
M benchmark/macro/src/androidTest/java/androidx/benchmark/macro/perfetto/ShellUtilsTest.kt
M benchmark/macro/src/main/java/androidx/benchmark/macro/perfetto/ShellUtils.kt
https://android-review.googlesource.com/1692806
Branch: androidx-main
commit 7fd221c0c8f7948351293a7fbf75eef0bf698a42
Author: Chris Craik <ccraik@google.com>
Date: Fri Apr 30 17:19:22 2021
Fix output issue on API 21, suppress still-broken tests
Bug: 183129298
Test: ./gradlew benchmark:b-c:cC benchmark:b-m:cC
Shell can't access externalCacheDir (but somehow can access cacheDir)
on API 21.
Also on API 21, UiDevice.executeShellCommand doesn't capture the
output of `echo foo`. executeShellScript still partially works
(e.g. `ls` works), but we'll need more investigation to better
understand shell command limitations on that API level.
Change-Id: I2bafe8218ed50ac54cd990190d2f9a2e2364028d
M benchmark/common/src/main/java/androidx/benchmark/Outputs.kt
A benchmark/macro/src/androidTest/java/androidx/benchmark/macro/OutputsTest.kt
M benchmark/macro/src/androidTest/java/androidx/benchmark/macro/perfetto/ShellUtilsTest.kt
M benchmark/macro/src/main/java/androidx/benchmark/macro/perfetto/ShellUtils.kt
jb...@google.com
ap...@google.com
(Coming back to this after I/O) Carmen - filed
jb...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 3dff7103380e8f0561029da051bd444d8bbcd26b
Author: Chris Craik <ccraik@google.com>
Date: Wed Jul 28 16:58:05 2021
Only use atrace tags supported on the local platform version
Bug: 183129298
Test: PerfettoConfigTest
Test: AtraceTagTest
Codifies list of in-use atrace tags with which platform versions
they're supported on. Validated on API 21 -> 29 emulators.
Currently, the way we invoke perfetto doesn't tell us if starting the
process failed, so this eliminates one source of this failure.
Planned follow up work
- investigate shell wrapper issues on API 21/22.
- improve perfetto launch failures to throw clearly
- add additional config validation
- (low prior) stash shell session rooted status
Change-Id: I99f5db15d1d0ee84d340b6879ef363f41c4327b5
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MacrobenchmarkScopeTest.kt
A benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/AtraceTagTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoConfigTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/ShellUtilsTest.kt
A benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/AtraceTag.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoCapture.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoConfig.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/ShellUtils.kt
https://android-review.googlesource.com/1780588
Branch: androidx-main
commit 3dff7103380e8f0561029da051bd444d8bbcd26b
Author: Chris Craik <ccraik@google.com>
Date: Wed Jul 28 16:58:05 2021
Only use atrace tags supported on the local platform version
Bug: 183129298
Test: PerfettoConfigTest
Test: AtraceTagTest
Codifies list of in-use atrace tags with which platform versions
they're supported on. Validated on API 21 -> 29 emulators.
Currently, the way we invoke perfetto doesn't tell us if starting the
process failed, so this eliminates one source of this failure.
Planned follow up work
- investigate shell wrapper issues on API 21/22.
- improve perfetto launch failures to throw clearly
- add additional config validation
- (low prior) stash shell session rooted status
Change-Id: I99f5db15d1d0ee84d340b6879ef363f41c4327b5
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MacrobenchmarkScopeTest.kt
A benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/AtraceTagTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoConfigTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/ShellUtilsTest.kt
A benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/AtraceTag.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoCapture.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoConfig.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/ShellUtils.kt
kr...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
commit 48ae41ec2aada7a167afbd9e03ce67e9114aed23
Author: Chris Craik <ccraik@google.com>
Date: Thu Jul 29 09:43:38 2021
Fix ShellUtils on API 21/22 - chmod +x not supported
Bug: 183129298
Test: ShellUtilsTest # verified on API 21 through 29
Change-Id: I8f235b8044fb54f9f23129a62e8a732536900add
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/ShellUtilsTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/ShellUtils.kt
https://android-review.googlesource.com/1782028
Branch: androidx-main
commit 48ae41ec2aada7a167afbd9e03ce67e9114aed23
Author: Chris Craik <ccraik@google.com>
Date: Thu Jul 29 09:43:38 2021
Fix ShellUtils on API 21/22 - chmod +x not supported
Bug: 183129298
Test: ShellUtilsTest # verified on API 21 through 29
Change-Id: I8f235b8044fb54f9f23129a62e8a732536900add
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/ShellUtilsTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/ShellUtils.kt
na...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e137997eab441062cc59ddaec31cb6609cd47039
Author: Chris Craik <ccraik@google.com>
Date: Thu Jul 29 10:21:32 2021
Validate PerfettoTraceProcessor back to API 21
Bug: 183129298
Test: PerfettoTraceProcessor # validated on API 21 through 26
Also adds fixed-trace query test.
Change-Id: I1a47f77c218d1918bd2273e3f6b1f43451f6ac76
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoTraceProcessorTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoTraceProcessor.kt
https://android-review.googlesource.com/1782029
Branch: androidx-main
commit e137997eab441062cc59ddaec31cb6609cd47039
Author: Chris Craik <ccraik@google.com>
Date: Thu Jul 29 10:21:32 2021
Validate PerfettoTraceProcessor back to API 21
Bug: 183129298
Test: PerfettoTraceProcessor # validated on API 21 through 26
Also adds fixed-trace query test.
Change-Id: I1a47f77c218d1918bd2273e3f6b1f43451f6ac76
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoTraceProcessorTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoTraceProcessor.kt
Description
Version used: every version since 2.4.0 (latest tested version is 2.5.1)
Latest version working correctly: 2.3.5
Devices/Android versions reproduced on: Emulator API 30, Oppo CPH2251 API 30, Samsung Galaxy S21 API 31
Repro steps:
1. Define the following 3 graphs (sample project is attached to this bug report):
<?xml version="1.0" encoding="utf-8"?>
<navigation xmlns:android="
xmlns:app="
xmlns:tools="
android:id="@+id/level_0_graph"
app:startDestination="@id/level_0_fragment">
<fragment
android:id="@+id/level_0_fragment"
android:name="com.example.nestedpopupto.Level0Fragment"
tools:layout="@layout/fragment_level_0">
<action
android:id="@+id/to_level_1"
app:popUpTo="@id/level_0_graph"
app:destination="@id/level_1" />
</fragment>
<navigation
android:id="@+id/level_1"
app:startDestination="@id/level_1_graph">
<include app:graph="@navigation/level_1_graph" />
</navigation>
</navigation>
<?xml version="1.0" encoding="utf-8"?>
<navigation xmlns:android="
xmlns:app="
xmlns:tools="
android:id="@+id/level_1_graph"
app:startDestination="@id/level_1_fragment">
<fragment
android:id="@+id/level_1_fragment"
android:name="com.example.nestedpopupto.Level1Fragment"
tools:layout="@layout/fragment_level_1">
<action
android:id="@+id/to_level_2"
app:popUpTo="@id/level_1_graph"
app:destination="@id/level_2" />
</fragment>
<navigation
android:id="@+id/level_2"
app:startDestination="@id/level_2_graph">
<include app:graph="@navigation/level_2_graph" />
</navigation>
</navigation>
<navigation xmlns:android="
xmlns:app="
xmlns:tools="
android:id="@+id/level_2_graph"
app:startDestination="@id/level_2_fragment">
<fragment
android:id="@+id/level_2_fragment"
android:name="com.example.nestedpopupto.Level2Fragment"
tools:layout="@layout/fragment_level_2">
</fragment>
</navigation>
2. Use "to_level_1" to navigate to nested graph.
3. Use "to_level_2" action.
Result:
The action "to_level_2" will fail with the following stacktrace:
java.lang.IllegalArgumentException: No destination with ID 2131230965 is on the NavController's back stack. The current destination is Destination(com.example.nestedpopupto:id/level_2_fragment) class=com.example.nestedpopupto.Level2Fragment
at androidx.navigation.NavController.getBackStackEntry(NavController.kt:2209)
at androidx.navigation.NavController.addEntryToBackStack(NavController.kt:1918)
at androidx.navigation.NavController.addEntryToBackStack$default(NavController.kt:1813)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1721)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1719)
at androidx.navigation.NavController$NavControllerNavigatorState.push(NavController.kt:287)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:246)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:162)
at androidx.navigation.NavGraphNavigator.navigate(NavGraphNavigator.kt:83)
at androidx.navigation.NavGraphNavigator.navigate(NavGraphNavigator.kt:49)
at androidx.navigation.NavGraphNavigator.navigate(NavGraphNavigator.kt:83)
at androidx.navigation.NavGraphNavigator.navigate(NavGraphNavigator.kt:49)
at androidx.navigation.NavController.navigateInternal(NavController.kt:260)
at androidx.navigation.NavController.navigate(NavController.kt:1719)
at androidx.navigation.NavController.navigate(NavController.kt:1545)
at androidx.navigation.NavController.navigate(NavController.kt:1472)
at androidx.navigation.NavController.navigate(NavController.kt:1930)
at com.example.nestedpopupto.Level1Fragment.onViewCreated$lambda-0(Level1Fragment.kt:13)
The crash will NOT occur if any of the following is applied:
- the "to_level_2" action does not use "popUpTo"
- the "level_2_graph" is not wrapped with the <navigation>.
As one can see the "to_level_1" action is identical to the "to_level_2" action and is defined in an identical graph and it works correctly. It seems that the bug occurs only when navigation is performed in the graph that is included in an other graph.
In the end I would like to remind that everything works correctly with version 2.3.5 of the androidx.navigation.