Fixed

Bug

Status Update

No update yet.

Description

su...@twofortyfouram.com

created issue #1

Aug 27, 2022 05:16PM

OVERVIEW

Androidx ProfileInstaller library has an implementation bug that can trigger a NullPointerException. Specifically, sending an Intent action androidx.profileinstaller.action.SKIP_FILE without any extras triggers the issue.

STEPS TO REPRODUCE

Install an app using ProfileInstaller
Replacing ${PACKAGE_NAME} with the correct application package name, run the following ADB command: adb shell am broadcast -a androidx.profileinstaller.action.SKIP_FILE -n ${PACKAGE_NAME}/androidx.profileinstaller.ProfileInstallReceiver

RESULTS

Actual: App crashes

Caused by java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.os.Bundle.getString(java.lang.String)' on a null object reference
       at androidx.profileinstaller.ProfileInstallReceiver.onReceive(ProfileInstallReceiver.java:75)
       at android.app.ActivityThread.handleReceiver(ActivityThread.java:3187)
       at android.app.ActivityThread.-wrap17(ActivityThread.java)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1672)
       at android.os.Handler.dispatchMessage(Handler.java:106)
       at android.os.Looper.loop(Looper.java:164)
       at android.app.ActivityThread.main(ActivityThread.java:6494)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

Expected: App shouldn't crash

NOTES

The issue is caused by the Intent extras being null. A null check of the extras is needed.

See https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/ProfileInstallReceiver.java;l=74

Component used: ProfileInstaller Version used: 1.2 Devices/Android versions reproduced on: Nexus 5 Android 7, Pixel 6 Android 13

Comments

ap...@google.com <ap...@google.com> #2Aug 30, 2022 02:29AM

Marked as fixed.

jsjeon@ do you know why that might be?

na...@google.com <na...@google.com> #3Oct 24, 2022 01:37PM

Any concrete examples I can take a look at?

One possibility is, as explained at https://kotlinlang.org/docs/annotations.html#annotation-use-site-targets, property use-site target has a higher priority over field, and

but the property itself in Metalava's output is not.

here Metalava's output should be Java field and accessor methods, so I guess @Deprecated could be not properly propagated to field.

jk...@gmail.com <jk...@gmail.com> #4Oct 29, 2022 02:23AM

https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2369848/12/wear/compose/compose-material/src/commonMain/kotlin/androidx/wear/compose/material/ScalingLazyListItemInfo.kt

and

https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2369848/12/wear/compose/compose-material/api/current.txt#427

ia...@gmail.com <ia...@gmail.com> #5Mar 14, 2023 02:16AM

Project: platform/tools/metalava
Branch: metalava-main

commit ac6b7a3779511b5be53c4f8dfbdfcdf1508764e6
Author: Jinseong Jeon <jsjeon@google.com>
Date: Thu Mar 02 23:37:39 2023

Propagate deprecation of containing class to property

...in the same way method/field are deprecated

Bug: 271441831
Test: unit test added
Change-Id: I899b80a484866a44be9aa244d00552ebce148335

M src/main/java/com/android/tools/metalava/ApiAnalyzer.kt
M src/test/java/com/android/tools/metalava/ApiFileTest.kt

https://android-review.googlesource.com/2468803

mi...@gmail.com <mi...@gmail.com> #6Mar 14, 2023 01:05PM

Project: platform/prebuilts/androidx/external
Branch: androidx-main

commit b712ab052930d4900a7f060d67bbd3cee2933970
Author: Jinseong Jeon <jsjeon@google.com>
Date: Sun Mar 05 22:51:50 2023

Update Metalava for build ID 9692962

./development/importMaven/importMaven.sh \
--metalava-build-id 9692962 \
--redownload com.android.tools.metalava:metalava:1.0.0-alpha07

Bug: 271441831
Bug: 271662790
Change-Id: Ide5946ed2a6b4248ffe5e822c760ed0b05034afd

M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.jar
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.jar.md5
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.jar.sha1
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.module
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.module.md5
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.module.sha1
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.pom
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.pom.md5
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.pom.sha1

https://android-review.googlesource.com/2471011

ap...@google.com <ap...@google.com> #7Mar 15, 2023 08:05PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5d6108703fa3db420dde7b7ee805ca4172ed44fa
Author: Jinseong Jeon <jsjeon@google.com>
Date: Sun Mar 05 23:03:10 2023

Update current API signature after Metalava update

Relnote: propagation of @Deprecated class to property
Bug: 271441831
Test: ./gradlew updateApi
Change-Id: I882d15d1d0d17f2227262e682d05d9dc7d082e8a

M annotation/annotation-experimental/api/current.txt
M annotation/annotation-experimental/api/public_plus_experimental_current.txt
M annotation/annotation-experimental/api/restricted_current.txt
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M paging/paging-common/api/current.txt
M paging/paging-common/api/public_plus_experimental_current.txt
M paging/paging-common/api/restricted_current.txt
M paging/paging-runtime/api/current.txt
M paging/paging-runtime/api/public_plus_experimental_current.txt
M paging/paging-runtime/api/restricted_current.txt
M wear/compose/compose-material/api/current.txt
M wear/compose/compose-material/api/public_plus_experimental_current.txt
M wear/compose/compose-material/api/restricted_current.txt
M wear/watchface/watchface-client/api/current.txt
M wear/watchface/watchface-client/api/public_plus_experimental_current.txt
M wear/watchface/watchface-client/api/restricted_current.txt
M wear/watchface/watchface/api/current.txt
M wear/watchface/watchface/api/public_plus_experimental_current.txt
M wear/watchface/watchface/api/restricted_current.txt

https://android-review.googlesource.com/2469886

ap...@google.com <ap...@google.com> #8Mar 15, 2023 08:46PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.wear.compose:compose-material:1.2.0-alpha07

ap...@google.com <ap...@google.com> #9Mar 15, 2023 09:09PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.wear.watchface:watchface:1.2.0-alpha08
androidx.wear.watchface:watchface-client:1.2.0-alpha08

ap...@google.com <ap...@google.com> #10Mar 15, 2023 09:10PM

Project: platform/frameworks/support
Branch: androidx-main

commit a8729785427262edc8c694584fb5cbaf323bfb80
Author: Chris Craik <ccraik@google.com>
Date: Wed Mar 15 11:24:39 2023

Bump activity's profileinstaller dependency to 1.3

Bug: 243851384
Test: None

Change-Id: Idc9af745ac5774491215980d26b0169b39195f30

M activity/activity/build.gradle

https://android-review.googlesource.com/2491995

ap...@google.com <ap...@google.com> #11Mar 16, 2023 05:13PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4bb158a35205ce4c0480d89ac325bf8ac86d3526
Author: Chris Craik <ccraik@google.com>
Date: Wed Mar 15 11:20:54 2023

Bump lifecycle's profileinstaller dependency to 1.3

Test: ./gradlew room:integ-test:room-testapp:cC -P android.testInstrumentationRunnerArguments.class=androidx.room.integration.testapp.test.QueryExecutorTest # API 17 emulator
Bug: 243851384

QueryExecutorTest was failing on API 17 due to non-native multidex
issues. Wasn't able to workaround in multidex proguard rules because
issues also occurred in the androidTest, which is also multidex.

Change-Id: I792343d042365e2db5940367a1e9fad377aedc26

M lifecycle/lifecycle-runtime/build.gradle
M room/integration-tests/testapp/build.gradle
D room/integration-tests/testapp/multidex-config.txt
A room/integration-tests/testapp/

multidex-rules.pro

https://android-review.googlesource.com/2490599

pr...@google.com <pr...@google.com> #12Mar 22, 2023 08:22PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.activity:activity:1.7.0
androidx.benchmark:benchmark-macro:1.2.0-alpha12
androidx.compose.ui:ui:1.4.0
androidx.constraintlayout:constraintlayout:2.2.0-alpha09
androidx.fragment:fragment:1.6.0-alpha08
androidx.lifecycle:lifecycle-runtime:2.6.1
androidx.navigation:navigation-common:2.6.0-alpha08
androidx.tv:tv-foundation:1.0.0-alpha05
androidx.tv:tv-material:1.0.0-alpha05
androidx.wear.compose:compose-foundation:1.2.0-alpha07
androidx.wear.compose:compose-material:1.2.0-alpha07
androidx.wear.compose:compose-material-core:1.2.0-alpha07
androidx.wear.compose:compose-navigation:1.2.0-alpha07

na...@google.com <na...@google.com> #13Jul 26, 2023 05:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.appcompat:appcompat:1.7.0-alpha03
androidx.lifecycle:lifecycle-runtime:2.7.0-alpha01

pr...@google.com <pr...@google.com> #14Oct 18, 2023 08:42PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.recyclerview:recyclerview:1.4.0-alpha01

ro...@gmail.com <ro...@gmail.com> #15Sep 10, 2024 08:56AM

Profile Installer

IssueTracker

NPE in ProfileInstallReceiver

Status Update

Description

OVERVIEW

STEPS TO REPRODUCE

RESULTS

NOTES

Comments

ap...@google.com <ap...@google.com> #2Aug 30, 2022 02:29AM

na...@google.com <na...@google.com> #3Oct 24, 2022 01:37PM

jk...@gmail.com <jk...@gmail.com> #4Oct 29, 2022 02:23AM

ia...@gmail.com <ia...@gmail.com> #5Mar 14, 2023 02:16AM

mi...@gmail.com <mi...@gmail.com> #6Mar 14, 2023 01:05PM

ap...@google.com <ap...@google.com> #7Mar 15, 2023 08:05PM

ap...@google.com <ap...@google.com> #8Mar 15, 2023 08:46PM

ap...@google.com <ap...@google.com> #9Mar 15, 2023 09:09PM

ap...@google.com <ap...@google.com> #10Mar 15, 2023 09:10PM

ap...@google.com <ap...@google.com> #11Mar 16, 2023 05:13PM

pr...@google.com <pr...@google.com> #12Mar 22, 2023 08:22PM

na...@google.com <na...@google.com> #13Jul 26, 2023 05:21PM

pr...@google.com <pr...@google.com> #14Oct 18, 2023 08:42PM

ro...@gmail.com <ro...@gmail.com> #15Sep 10, 2024 08:56AM

Issue 243851384

Description

OVERVIEW

STEPS TO REPRODUCE

RESULTS

NOTES

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Aug 30, 2022 02:29AM

na...@google.com <na...@google.com> #3Oct 24, 2022 01:37PM

jk...@gmail.com <jk...@gmail.com> #4Oct 29, 2022 02:23AM

ia...@gmail.com <ia...@gmail.com> #5Mar 14, 2023 02:16AM

mi...@gmail.com <mi...@gmail.com> #6Mar 14, 2023 01:05PM

ap...@google.com <ap...@google.com> #7Mar 15, 2023 08:05PM

ap...@google.com <ap...@google.com> #8Mar 15, 2023 08:46PM

ap...@google.com <ap...@google.com> #9Mar 15, 2023 09:09PM

ap...@google.com <ap...@google.com> #10Mar 15, 2023 09:10PM

ap...@google.com <ap...@google.com> #11Mar 16, 2023 05:13PM

pr...@google.com <pr...@google.com> #12Mar 22, 2023 08:22PM

na...@google.com <na...@google.com> #13Jul 26, 2023 05:21PM

pr...@google.com <pr...@google.com> #14Oct 18, 2023 08:42PM

ro...@gmail.com <ro...@gmail.com> #15Sep 10, 2024 08:56AM

Add comment

Issue metadata