Status Update
Comments
mk...@google.com <mk...@google.com>
ch...@google.com <ch...@google.com> #2
We're seeing a similar error in our code. Appears to be a combination of AGP 8.6.0 and Kotlin 2 needed to hit it.
private fun Intent.stripUnwantedFlags() {
// Explicitly remove the new task and clear task flags (Our browser activity is a single
// task activity and we never want to start a second task here).
flags = flags and Intent.FLAG_ACTIVITY_NEW_TASK.inv()
flags = flags and Intent.FLAG_ACTIVITY_CLEAR_TASK.inv()
// IntentReceiverActivity is started with the "excludeFromRecents" flag (set in manifest). We
// do not want to propagate this flag from the intent receiver activity to the browser.
flags = flags and Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS.inv()
}
All 3 lines then hit:
Must be one or more of: Intent.FLAG_GRANT_READ_URI_PERMISSION, Intent.FLAG_GRANT_WRITE_URI_PERMISSION, Intent.FLAG_FROM_BACKGROUND, Intent.FLAG_DEBUG_LOG_RESOLUTION, Intent.FLAG_EXCLUDE_STOPPED_PACKAGES, Intent.FLAG_INCLUDE_STOPPED_PACKAGES, Intent.FLAG_GRANT_PERSISTABLE_URI_PERMISSION, Intent.FLAG_GRANT_PREFIX_URI_PERMISSION, Intent.FLAG_ACTIVITY_MATCH_EXTERNAL, Intent.FLAG_ACTIVITY_NO_HISTORY, Intent.FLAG_ACTIVITY_SINGLE_TOP, Intent.FLAG_ACTIVITY_NEW_TASK, Intent.FLAG_ACTIVITY_MULTIPLE_TASK, Intent.FLAG_ACTIVITY_CLEAR_TOP, Intent.FLAG_ACTIVITY_FORWARD_RESULT, Intent.FLAG_ACTIVITY_PREVIOUS_IS_TOP, Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS, Intent.FLAG_ACTIVITY_BROUGHT_TO_FRONT, Intent.FLAG_ACTIVITY_RESET_TASK_IF_NEEDED, Intent.FLAG_ACTIVITY_LAUNCHED_FROM_HISTORY, Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET, Intent.FLAG_ACTIVITY_NEW_DOCUMENT, Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET, Intent.FLAG_ACTIVITY_NO_USER_ACTION, Intent.FLAG_ACTIVITY_REORDER_TO_FRONT, Intent.FLAG_ACTIVITY_NO_ANIMATION, Intent.FLAG_ACTIVITY_CLEAR_TASK, Intent.FLAG_ACTIVITY_TASK_ON_HOME, Intent.FLAG_ACTIVITY_RETAIN_IN_RECENTS, Intent.FLAG_ACTIVITY_LAUNCH_ADJACENT, Intent.FLAG_ACTIVITY_REQUIRE_NON_BROWSER, Intent.FLAG_ACTIVITY_REQUIRE_DEFAULT, Intent.FLAG_RECEIVER_REGISTERED_ONLY, Intent.FLAG_RECEIVER_REPLACE_PENDING, Intent.FLAG_RECEIVER_FOREGROUND, Intent.FLAG_RECEIVER_NO_ABORT, Intent.FLAG_RECEIVER_VISIBLE_TO_INSTANT_APPS
an...@airbnb.com <an...@airbnb.com> #3
The initial report (
However,
sg...@google.com <sg...@google.com> #4
Thanks for fixing! What release should we be able to verify the fix in? And is there any chance of a backport for 8.6.1?
an...@airbnb.com <an...@airbnb.com> #7
Thanks for the update!
ap...@google.com <ap...@google.com> #8
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Ladybug Feature Drop | 2024.2.2 Canary 2
- Android Gradle Plugin 8.8.0-alpha02
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
ap...@google.com <ap...@google.com> #9
The fixes for this issue are now also available in:
- Android Studio Ladybug | 2024.2.1 RC 1
- Android Gradle Plugin 8.7.0-rc01
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
ap...@google.com <ap...@google.com> #10
Branch: 4.0
commit eb26fd0b5deacc28a6d9f6ef3c9680af3a3dc485
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 11:40:28 2022
Reland "Fix inadequate detection of package private accesses"
This reverts commit b9028365137393aa8632b29dbabcbec522ebad8f.
Bug:
Change-Id: If19f6bb899ced9d0dcb0598c06b3d7814542c0b1
M src/main/java/com/android/tools/r8/horizontalclassmerging/PolicyScheduler.java
M src/main/java/com/android/tools/r8/shaking/VerticalClassMerger.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinAccessorTest.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinPropertiesTest.java
M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java
M src/test/java/com/android/tools/r8/internal/YouTubeV1719Test.java
ap...@google.com <ap...@google.com> #11
Branch: 4.0
commit 8bc9ca96c37f141b5d6617a6b4ab87c350cac1a7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 11:39:47 2022
Retain package of classes with package private field types
Bug:
Change-Id: If89c88ccb88d9caf86f53101d86cfa1f2d3f09da
M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java
ap...@google.com <ap...@google.com> #12
Branch: 3.3
commit e007b08a5957f42e1ff182863486264cabb3da5a
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 12:07:03 2022
Version 3.3.77
Bug:
Change-Id: I09d1feb551e563538d8caf0af373560041556f31
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #13
Branch: 3.3
commit 510d6d21cf43ba07b3659b37e725273f8372b7d4
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 12:04:19 2022
Reland "Fix inadequate detection of package private accesses"
This reverts commit b9028365137393aa8632b29dbabcbec522ebad8f.
Bug:
Change-Id: If19f6bb899ced9d0dcb0598c06b3d7814542c0b1
M src/main/java/com/android/tools/r8/horizontalclassmerging/PolicyScheduler.java
M src/main/java/com/android/tools/r8/shaking/VerticalClassMerger.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinAccessorTest.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinPropertiesTest.java
M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java
ap...@google.com <ap...@google.com> #14
Branch: 3.3
commit c3e2a3a4ae8bff0defdb80f47228976f7d35e002
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 12:02:43 2022
Retain package of classes with package private field types
Bug:
Change-Id: If89c88ccb88d9caf86f53101d86cfa1f2d3f09da
M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java
ch...@google.com <ch...@google.com> #15
Sorry for the delay in getting this landed on the release branches. A fix should now have landed in R8 versions 3.3.77 and 4.0.27. It would be great if you could confirm if this works for you.
an...@airbnb.com <an...@airbnb.com> #16
Just tested it and I can confirm that that fixes the issue for us. I used 3.3.77. Thank you!
pa...@gmail.com <pa...@gmail.com> #17
Pavan Raghupatiwar
Description
After updating to AGP 7.3 (and also to latest release of R8 3.3.75 we are seeing this crash in our app.
When I look at the processed code something looks like to have gotten inlined across packages and now this is violating the package private visibility of
com.airbnb.android.feat.wishlistdetails.v2.NewWishlistDetailsFragment.ıɿ
Don't worry about the odd symbols we are using a custom dictionary, but I don't think this is the issue here.
I also created a dump and shared it with you.