java.lang.IllegalAccessError with R8 3.3.75 [243955191]

Verified

Bug

adexe s nau

Status Update

No update yet.

Description

an...@airbnb.com

created issue #1

Aug 27, 2022 02:21AM

After updating to AGP 7.3 (and also to latest release of R8 3.3.75 we are seeing this crash in our app.

When I look at the processed code something looks like to have gotten inlined across packages and now this is violating the package private visibility of com.airbnb.android.feat.wishlistdetails.v2.NewWishlistDetailsFragment.ıɿ

Don't worry about the odd symbols we are using a custom dictionary, but I don't think this is the issue here.

I also created a dump and shared it with you.

    java.lang.IllegalAccessError: Field 'com.airbnb.android.feat.wishlistdetails.v2.NewWishlistDetailsFragment.ıɿ' is inaccessible to class 'com.airbnb.android.feat.checkout.china.fragments.a' (declaration of 'com.airbnb.android.feat.checkout.china.fragments.a' appears in /data/app/~~PtSrEOcwfv7c4Qck1uE7eQ==/com.airbnb.android-Uz6dcHiw-M1deDn7Kdl5Pg==/base.apk!classes3.dex)
        at com.airbnb.android.feat.checkout.china.fragments.a.і(:90)
        at com.airbnb.n2.comp.designsystem.dls.inputs.chip.BaseChipStyleApplier$BaseStyleBuilder.ϟ(:6)
        at com.airbnb.android.feat.wishlistdetails.v2.g.ȷ(:152)
        at com.airbnb.n2.comp.designsystem.dls.inputs.chip.ChipV2Model_.łǃ(:18)
        at com.airbnb.android.feat.wishlistdetails.v2.NewWishlistDetailsFragment$epoxyController$1.invoke(:48)
        at com.airbnb.android.lib.mvrx.MvRxEpoxyControllerKt$simpleController$1$1.invoke(:7)
        at com.airbnb.mvrx.StateContainerKt.ǃ(:5)
        at com.airbnb.android.lib.mvrx.MvRxEpoxyControllerKt$simpleController$1.invoke(:12)
        at com.airbnb.android.lib.mvrx.MvRxEpoxyController.buildModels(:3)
        at com.airbnb.epoxy.EpoxyController$1.run(:55)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.os.HandlerThread.run(HandlerThread.java:67)

https://drive.google.com/file/d/1850lYXP2Vs4tV1bYsYPi9lYnhClIcTJU/view?usp=drive_web (airbnb_dump.zip)

Comments

mk...@google.com <mk...@google.com> Aug 29, 2022 07:25AM

Reassigned to ch...@google.com.

ch...@google.com <ch...@google.com> #2Aug 31, 2022 10:47AM

Thanks for sharing the dump. I seem to be able to reproduce the issue, although I am not finding the exact same illegal access from com.airbnb.android.feat.checkout.china.fragments.a. I am diagnosing the issue and hope to have a fix soon.

an...@airbnb.com <an...@airbnb.com> #3Sep 1, 2022 05:32PM

Thank you, let me know if I can provide any additional information. Should I include a full binary?

sg...@google.com <sg...@google.com> #4Sep 1, 2022 05:55PM

Christoffer found the issue, and has a fix ready, https://r8-review.googlesource.com/c/r8/+/71020. Hopefuly we will merge to release branches tomorrow so you can get a chance to test it soon.

ap...@google.com <ap...@google.com> #5Sep 2, 2022 04:37AM

Project: r8
Branch: main

commit c3aae70e896177017da7b5e9321eea69c6eb3c0d
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Sep 01 19:53:13 2022

Reproduce IllegalAccessError from inadequate package private detection

Bug:

b/243955191

Change-Id: I82ffefc42e0f6537974c7428160a93f42052008a

A src/test/java/com/android/tools/r8/classmerging/horizontal/InitClassToPackagePrivateFieldWithCrossPackageMergingTest.java
M src/test/java/com/android/tools/r8/utils/codeinspector/HorizontallyMergedClassesInspector.java

https://r8-review.googlesource.com/71040

ap...@google.com <ap...@google.com> #6Sep 2, 2022 04:37AM

Project: r8
Branch: main

commit 65be8bcf65bac299cf8d84d600c65119ff0a2258
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Sep 01 19:53:23 2022

Fix inadequate detection of package private accesses

Bug:

b/243955191

Bug:

b/244415116

Change-Id: Iac4cb138badafe277130d01340c2eab6840ed1e6

M src/main/java/com/android/tools/r8/shaking/VerticalClassMerger.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinPropertiesTest.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinAccessorTest.java
M src/test/java/com/android/tools/r8/classmerging/horizontal/InitClassToPackagePrivateFieldWithCrossPackageMergingTest.java
M src/test/java/com/android/tools/r8/internal/YouTubeV1719Test.java

https://r8-review.googlesource.com/71020

an...@airbnb.com <an...@airbnb.com> #7Sep 2, 2022 04:29PM

Yay, thank you, let me know once a release is available and and I give it a try.

ap...@google.com <ap...@google.com> #8Sep 7, 2022 09:26AM

Project: r8
Branch: main

commit 96d8e7fc8c39d8dc0da4053744048abcb19074f7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 09:41:37 2022

Reland "Fix inadequate detection of package private accesses"

This reverts commit b9028365137393aa8632b29dbabcbec522ebad8f.

Bug:

b/243955191

Change-Id: If19f6bb899ced9d0dcb0598c06b3d7814542c0b1

M src/main/java/com/android/tools/r8/horizontalclassmerging/PolicyScheduler.java
M src/main/java/com/android/tools/r8/shaking/VerticalClassMerger.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinAccessorTest.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinPropertiesTest.java
M src/test/java/com/android/tools/r8/classmerging/horizontal/InitClassToPackagePrivateFieldWithCrossPackageMergingTest.java
M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java
M src/test/java/com/android/tools/r8/internal/YouTubeV1719Test.java

https://r8-review.googlesource.com/71234

ap...@google.com <ap...@google.com> #9Sep 7, 2022 11:49AM

Project: r8
Branch: 4.0

commit 30357b5696fee0b4c6d1bae1dde5c95356083202
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 11:41:05 2022

Version 4.0.27

Bug:

b/243955191

Change-Id: Id6bfacfe5274c976d13b27aa5b2d7cc572e346b4

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/71293

ap...@google.com <ap...@google.com> #10Sep 7, 2022 11:49AM

Project: r8
Branch: 4.0

commit eb26fd0b5deacc28a6d9f6ef3c9680af3a3dc485
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 11:40:28 2022

Reland "Fix inadequate detection of package private accesses"

This reverts commit b9028365137393aa8632b29dbabcbec522ebad8f.

Bug:

b/243955191

Change-Id: If19f6bb899ced9d0dcb0598c06b3d7814542c0b1

M src/main/java/com/android/tools/r8/horizontalclassmerging/PolicyScheduler.java
M src/main/java/com/android/tools/r8/shaking/VerticalClassMerger.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinAccessorTest.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinPropertiesTest.java
M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java
M src/test/java/com/android/tools/r8/internal/YouTubeV1719Test.java

https://r8-review.googlesource.com/71292

ap...@google.com <ap...@google.com> #11Sep 7, 2022 11:49AM

Project: r8
Branch: 4.0

commit 8bc9ca96c37f141b5d6617a6b4ab87c350cac1a7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 11:39:47 2022

Retain package of classes with package private field types

Bug:

b/243955191

Change-Id: If89c88ccb88d9caf86f53101d86cfa1f2d3f09da

M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java

https://r8-review.googlesource.com/71291

ap...@google.com <ap...@google.com> #12Sep 7, 2022 12:07PM

Project: r8
Branch: 3.3

commit e007b08a5957f42e1ff182863486264cabb3da5a
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 12:07:03 2022

Version 3.3.77

Bug:

b/243955191

Change-Id: I09d1feb551e563538d8caf0af373560041556f31

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/71297

ap...@google.com <ap...@google.com> #13Sep 7, 2022 12:07PM

Project: r8
Branch: 3.3

commit 510d6d21cf43ba07b3659b37e725273f8372b7d4
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 12:04:19 2022

Reland "Fix inadequate detection of package private accesses"

This reverts commit b9028365137393aa8632b29dbabcbec522ebad8f.

Bug:

b/243955191

https://r8-review.googlesource.com/71296

ap...@google.com <ap...@google.com> #14Sep 7, 2022 12:07PM

Project: r8
Branch: 3.3

commit c3e2a3a4ae8bff0defdb80f47228976f7d35e002
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 12:02:43 2022

Retain package of classes with package private field types

Bug:

b/243955191

Change-Id: If89c88ccb88d9caf86f53101d86cfa1f2d3f09da

M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java

https://r8-review.googlesource.com/71295

ch...@google.com <ch...@google.com> #15Sep 7, 2022 12:09PM

Verified by ch...@google.com.

Sorry for the delay in getting this landed on the release branches. A fix should now have landed in R8 versions 3.3.77 and 4.0.27. It would be great if you could confirm if this works for you.

an...@airbnb.com <an...@airbnb.com> #16Sep 8, 2022 04:27PM

Just tested it and I can confirm that that fixes the issue for us. I used 3.3.77. Thank you!

pa...@gmail.com <pa...@gmail.com> #17Nov 4, 2022 03:33PM

Pavan Raghupatiwar

pa...@gmail.com <pa...@gmail.com> #18Nov 4, 2022 03:41PM

https://docs.google.com/forms/d/13iDyb-cS8Zju61VXKy3VmP_XUMdsCHv84MnUqXbbOUo/edit?usp=drive_web (Untitled form)

ch...@gmail.com <ch...@gmail.com> #19Nov 24, 2022 05:26AM

Comment has been deleted.

Message last modified on Nov 24, 2022 05:27AM

ch...@gmail.com <ch...@gmail.com> #20
Restricted
Nov 24, 2022 05:30AM

Comment has been deleted.

Issue 243955191

Description

Issue summary

Comments

mk...@google.com <mk...@google.com> Aug 29, 2022 07:25AM

ch...@google.com <ch...@google.com> #2Aug 31, 2022 10:47AM

an...@airbnb.com <an...@airbnb.com> #3Sep 1, 2022 05:32PM

sg...@google.com <sg...@google.com> #4Sep 1, 2022 05:55PM

ap...@google.com <ap...@google.com> #5Sep 2, 2022 04:37AM

ap...@google.com <ap...@google.com> #6Sep 2, 2022 04:37AM

an...@airbnb.com <an...@airbnb.com> #7Sep 2, 2022 04:29PM

ap...@google.com <ap...@google.com> #8Sep 7, 2022 09:26AM

ap...@google.com <ap...@google.com> #9Sep 7, 2022 11:49AM

ap...@google.com <ap...@google.com> #10Sep 7, 2022 11:49AM

ap...@google.com <ap...@google.com> #11Sep 7, 2022 11:49AM

ap...@google.com <ap...@google.com> #12Sep 7, 2022 12:07PM

ap...@google.com <ap...@google.com> #13Sep 7, 2022 12:07PM

ap...@google.com <ap...@google.com> #14Sep 7, 2022 12:07PM

ch...@google.com <ch...@google.com> #15Sep 7, 2022 12:09PM

an...@airbnb.com <an...@airbnb.com> #16Sep 8, 2022 04:27PM

pa...@gmail.com <pa...@gmail.com> #17Nov 4, 2022 03:33PM

pa...@gmail.com <pa...@gmail.com> #18Nov 4, 2022 03:41PM

ch...@gmail.com <ch...@gmail.com> #19Nov 24, 2022 05:26AM

ch...@gmail.com <ch...@gmail.com> #20 Restricted Nov 24, 2022 05:30AM

Add comment

Issue metadata

ch...@gmail.com <ch...@gmail.com> #20
Restricted
Nov 24, 2022 05:30AM