Verified
Status Update
Comments
mk...@google.com <mk...@google.com>
ch...@google.com <ch...@google.com> #2
Fixed in r1313.
an...@airbnb.com <an...@airbnb.com> #3
[Empty comment from Monorail migration]
sg...@google.com <sg...@google.com> #4
[Empty comment from Monorail migration]
ap...@google.com <ap...@google.com> #5
ap...@google.com <ap...@google.com> #6
Project: r8
Branch: main
commit 65be8bcf65bac299cf8d84d600c65119ff0a2258
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Sep 01 19:53:23 2022
Fix inadequate detection of package private accesses
Bug: b/243955191
Bug: b/244415116
Change-Id: Iac4cb138badafe277130d01340c2eab6840ed1e6
M src/main/java/com/android/tools/r8/shaking/VerticalClassMerger.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinPropertiesTest.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinAccessorTest.java
M src/test/java/com/android/tools/r8/classmerging/horizontal/InitClassToPackagePrivateFieldWithCrossPackageMergingTest.java
M src/test/java/com/android/tools/r8/internal/YouTubeV1719Test.java
https://r8-review.googlesource.com/71020
Branch: main
commit 65be8bcf65bac299cf8d84d600c65119ff0a2258
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Sep 01 19:53:23 2022
Fix inadequate detection of package private accesses
Bug:
Bug:
Change-Id: Iac4cb138badafe277130d01340c2eab6840ed1e6
M src/main/java/com/android/tools/r8/shaking/VerticalClassMerger.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinPropertiesTest.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinAccessorTest.java
M src/test/java/com/android/tools/r8/classmerging/horizontal/InitClassToPackagePrivateFieldWithCrossPackageMergingTest.java
M src/test/java/com/android/tools/r8/internal/YouTubeV1719Test.java
an...@airbnb.com <an...@airbnb.com> #7
Yay, thank you, let me know once a release is available and and I give it a try.
ap...@google.com <ap...@google.com> #8
Project: r8
Branch: main
commit 96d8e7fc8c39d8dc0da4053744048abcb19074f7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 09:41:37 2022
Reland "Fix inadequate detection of package private accesses"
This reverts commit b9028365137393aa8632b29dbabcbec522ebad8f.
Bug: b/243955191
Change-Id: If19f6bb899ced9d0dcb0598c06b3d7814542c0b1
M src/main/java/com/android/tools/r8/horizontalclassmerging/PolicyScheduler.java
M src/main/java/com/android/tools/r8/shaking/VerticalClassMerger.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinAccessorTest.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinPropertiesTest.java
M src/test/java/com/android/tools/r8/classmerging/horizontal/InitClassToPackagePrivateFieldWithCrossPackageMergingTest.java
M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java
M src/test/java/com/android/tools/r8/internal/YouTubeV1719Test.java
https://r8-review.googlesource.com/71234
Branch: main
commit 96d8e7fc8c39d8dc0da4053744048abcb19074f7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 09:41:37 2022
Reland "Fix inadequate detection of package private accesses"
This reverts commit b9028365137393aa8632b29dbabcbec522ebad8f.
Bug:
Change-Id: If19f6bb899ced9d0dcb0598c06b3d7814542c0b1
M src/main/java/com/android/tools/r8/horizontalclassmerging/PolicyScheduler.java
M src/main/java/com/android/tools/r8/shaking/VerticalClassMerger.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinAccessorTest.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinPropertiesTest.java
M src/test/java/com/android/tools/r8/classmerging/horizontal/InitClassToPackagePrivateFieldWithCrossPackageMergingTest.java
M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java
M src/test/java/com/android/tools/r8/internal/YouTubeV1719Test.java
ap...@google.com <ap...@google.com> #9
Project: r8
Branch: 4.0
commit 30357b5696fee0b4c6d1bae1dde5c95356083202
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 11:41:05 2022
Version 4.0.27
Bug: b/243955191
Change-Id: Id6bfacfe5274c976d13b27aa5b2d7cc572e346b4
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/71293
Branch: 4.0
commit 30357b5696fee0b4c6d1bae1dde5c95356083202
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 11:41:05 2022
Version 4.0.27
Bug:
Change-Id: Id6bfacfe5274c976d13b27aa5b2d7cc572e346b4
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #10
Project: r8
Branch: 4.0
commit eb26fd0b5deacc28a6d9f6ef3c9680af3a3dc485
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 11:40:28 2022
Reland "Fix inadequate detection of package private accesses"
This reverts commit b9028365137393aa8632b29dbabcbec522ebad8f.
Bug: b/243955191
Change-Id: If19f6bb899ced9d0dcb0598c06b3d7814542c0b1
M src/main/java/com/android/tools/r8/horizontalclassmerging/PolicyScheduler.java
M src/main/java/com/android/tools/r8/shaking/VerticalClassMerger.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinAccessorTest.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinPropertiesTest.java
M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java
M src/test/java/com/android/tools/r8/internal/YouTubeV1719Test.java
https://r8-review.googlesource.com/71292
Branch: 4.0
commit eb26fd0b5deacc28a6d9f6ef3c9680af3a3dc485
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 11:40:28 2022
Reland "Fix inadequate detection of package private accesses"
This reverts commit b9028365137393aa8632b29dbabcbec522ebad8f.
Bug:
Change-Id: If19f6bb899ced9d0dcb0598c06b3d7814542c0b1
M src/main/java/com/android/tools/r8/horizontalclassmerging/PolicyScheduler.java
M src/main/java/com/android/tools/r8/shaking/VerticalClassMerger.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinAccessorTest.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinPropertiesTest.java
M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java
M src/test/java/com/android/tools/r8/internal/YouTubeV1719Test.java
ap...@google.com <ap...@google.com> #11
Project: r8
Branch: 4.0
commit 8bc9ca96c37f141b5d6617a6b4ab87c350cac1a7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 11:39:47 2022
Retain package of classes with package private field types
Bug: b/243955191
Change-Id: If89c88ccb88d9caf86f53101d86cfa1f2d3f09da
M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java
https://r8-review.googlesource.com/71291
Branch: 4.0
commit 8bc9ca96c37f141b5d6617a6b4ab87c350cac1a7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 11:39:47 2022
Retain package of classes with package private field types
Bug:
Change-Id: If89c88ccb88d9caf86f53101d86cfa1f2d3f09da
M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java
ap...@google.com <ap...@google.com> #12
Project: r8
Branch: 3.3
commit e007b08a5957f42e1ff182863486264cabb3da5a
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 12:07:03 2022
Version 3.3.77
Bug: b/243955191
Change-Id: I09d1feb551e563538d8caf0af373560041556f31
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/71297
Branch: 3.3
commit e007b08a5957f42e1ff182863486264cabb3da5a
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 12:07:03 2022
Version 3.3.77
Bug:
Change-Id: I09d1feb551e563538d8caf0af373560041556f31
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #13
Project: r8
Branch: 3.3
commit 510d6d21cf43ba07b3659b37e725273f8372b7d4
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 12:04:19 2022
Reland "Fix inadequate detection of package private accesses"
This reverts commit b9028365137393aa8632b29dbabcbec522ebad8f.
Bug: b/243955191
Change-Id: If19f6bb899ced9d0dcb0598c06b3d7814542c0b1
M src/main/java/com/android/tools/r8/horizontalclassmerging/PolicyScheduler.java
M src/main/java/com/android/tools/r8/shaking/VerticalClassMerger.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinAccessorTest.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinPropertiesTest.java
M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java
https://r8-review.googlesource.com/71296
Branch: 3.3
commit 510d6d21cf43ba07b3659b37e725273f8372b7d4
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 12:04:19 2022
Reland "Fix inadequate detection of package private accesses"
This reverts commit b9028365137393aa8632b29dbabcbec522ebad8f.
Bug:
Change-Id: If19f6bb899ced9d0dcb0598c06b3d7814542c0b1
M src/main/java/com/android/tools/r8/horizontalclassmerging/PolicyScheduler.java
M src/main/java/com/android/tools/r8/shaking/VerticalClassMerger.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinAccessorTest.java
M src/test/java/com/android/tools/r8/kotlin/R8KotlinPropertiesTest.java
M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java
ap...@google.com <ap...@google.com> #14
Project: r8
Branch: 3.3
commit c3e2a3a4ae8bff0defdb80f47228976f7d35e002
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 12:02:43 2022
Retain package of classes with package private field types
Bug: b/243955191
Change-Id: If89c88ccb88d9caf86f53101d86cfa1f2d3f09da
M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java
https://r8-review.googlesource.com/71295
Branch: 3.3
commit c3e2a3a4ae8bff0defdb80f47228976f7d35e002
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Sep 07 12:02:43 2022
Retain package of classes with package private field types
Bug:
Change-Id: If89c88ccb88d9caf86f53101d86cfa1f2d3f09da
M src/main/java/com/android/tools/r8/horizontalclassmerging/policies/RespectPackageBoundaries.java
ch...@google.com <ch...@google.com> #15
Sorry for the delay in getting this landed on the release branches. A fix should now have landed in R8 versions 3.3.77 and 4.0.27. It would be great if you could confirm if this works for you.
an...@airbnb.com <an...@airbnb.com> #16
Just tested it and I can confirm that that fixes the issue for us. I used 3.3.77. Thank you!
pa...@gmail.com <pa...@gmail.com> #17
Pavan Raghupatiwar
ch...@gmail.com <ch...@gmail.com> #19
Comment has been deleted.
ch...@gmail.com <ch...@gmail.com> #20 Restricted
Restricted
Comment has been deleted.
Description
After updating to AGP 7.3 (and also to latest release of R8 3.3.75 we are seeing this crash in our app.
When I look at the processed code something looks like to have gotten inlined across packages and now this is violating the package private visibility of
com.airbnb.android.feat.wishlistdetails.v2.NewWishlistDetailsFragment.ıɿ
Don't worry about the odd symbols we are using a custom dictionary, but I don't think this is the issue here.
I also created a dump and shared it with you.