CTRL+backspace in an empty TextField causes java.lang.IllegalArgumentException: offset(-1) is out of bounds [0, 0] [244185537]

Fixed

Bug

Status Update

No update yet.

Description

az...@gmail.com

created issue #1

Aug 29, 2022 06:10PM

Jetpack Compose version: 1.3.0-beta01
Jetpack Compose component used: TextField
Kotlin version: 1.7.10
Devices/Android versions reproduced on: Pixel 4a 5G, Android 13
Keyboard: Remote control via vysor.io

Repro on Android:

git clone git@github.com:android/compose-samples.git
cd compose-samples/Jetchat
git checkout compose-latest
./gradlew installDebug
Start Jetchat and somehow send a CTRL+Backspace to the TextField (I used vysor.io)

Repro on Desktop:

git clone git@github.com:JetBrains/compose-jb.git
cd compose-jb/examples/widgets-gallery
modify gradle.properties and set
- kotlin.version=1.7.10
- compose.version=1.2.0-alpha01-dev770
./gradlew run
Do CTRL+Backspace on 1 of the TextField

Issue in compose-jb: https://github.com/JetBrains/compose-jb/issues/565

Stacktrace:

08-29 19:53:12.330 13155 13155 E AndroidRuntime: java.lang.IllegalArgumentException: offset(-1) is out of bounds [0, 0]
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.ui.text.MultiParagraph.requireIndexInRangeInclusiveEnd(MultiParagraph.kt:756)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.ui.text.MultiParagraph.getWordBoundary--jx7JFs(MultiParagraph.kt:590)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.ui.text.TextLayoutResult.getWordBoundary--jx7JFs(TextLayoutResult.kt:521)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.foundation.text.selection.BaseTextPreparedSelection.getPrevWordOffset(TextPreparedSelection.kt:278)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.foundation.text.selection.BaseTextPreparedSelection.getPrevWordOffset$default(TextPreparedSelection.kt:272)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.foundation.text.selection.BaseTextPreparedSelection.getPreviousWordOffset(TextPreparedSelection.kt:198)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.foundation.text.TextFieldKeyInput$process$2$5.invoke(TextFieldKeyInput.kt:148)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.foundation.text.TextFieldKeyInput$process$2$5.invoke(TextFieldKeyInput.kt:147)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.foundation.text.selection.TextFieldPreparedSelection.deleteIfSelectedOr(TextPreparedSelection.kt:397)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.foundation.text.TextFieldKeyInput$process$2.invoke(TextFieldKeyInput.kt:147)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.foundation.text.TextFieldKeyInput$process$2.invoke(TextFieldKeyInput.kt:103)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.foundation.text.TextFieldKeyInput.commandExecutionContext(TextFieldKeyInput.kt:223)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.foundation.text.TextFieldKeyInput.process-ZmokQxo(TextFieldKeyInput.kt:103)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.foundation.text.TextFieldKeyInputKt$textFieldKeyInput$2$1.invoke-ZmokQxo(TextFieldKeyInput.kt:255)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.foundation.text.TextFieldKeyInputKt$textFieldKeyInput$2$1.invoke(TextFieldKeyInput.kt:255)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.ui.input.key.KeyInputModifier.propagateKeyEvent-ZmokQxo(KeyInputModifier.kt:124)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.ui.input.key.KeyInputModifier.processKeyInput-ZmokQxo(KeyInputModifier.kt:103)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.ui.platform.AndroidComposeView.sendKeyEvent-ZmokQxo(AndroidComposeView.android.kt:620)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.ui.platform.AndroidComposeView.dispatchKeyEvent(AndroidComposeView.android.kt:628)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1965)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1965)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1965)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1965)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1965)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1965)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1965)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.compose.ui.platform.AndroidComposeView.dispatchKeyEvent(AndroidComposeView.android.kt:633)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1965)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1965)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1965)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1965)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1965)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1965)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at com.android.internal.policy.DecorView.superDispatchKeyEvent(DecorView.java:486)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at com.android.internal.policy.PhoneWindow.superDispatchKeyEvent(PhoneWindow.java:1889)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at android.app.Activity.dispatchKeyEvent(Activity.java:4222)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.core.app.ComponentActivity.superDispatchKeyEvent(ComponentActivity.java:124)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.core.view.KeyEventDispatcher.dispatchKeyEvent(KeyEventDispatcher.java:86)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.core.app.ComponentActivity.dispatchKeyEvent(ComponentActivity.java:142)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.appcompat.app.AppCompatActivity.dispatchKeyEvent(AppCompatActivity.java:601)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.appcompat.view.WindowCallbackWrapper.dispatchKeyEvent(WindowCallbackWrapper.java:60)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at androidx.appcompat.app.AppCompatDelegateImpl$AppCompatWindowCallback.dispatchKeyEvent(AppCompatDelegateImpl.java:3106)
08-29 19:53:12.330 13155 13155 E AndroidRuntime:        at com.android.internal.policy.DecorView.dispatchKeyEvent(DecorView.java:400)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.ViewRootImpl$ViewPostImeInputStage.processKeyEvent(ViewRootImpl.java:6478)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:6344)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5804)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5861)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5827)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5992)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5835)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:6049)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5808)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5861)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5827)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5835)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5808)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5861)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5827)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:6025)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.ViewRootImpl$ImeInputStage.onFinishedInputEvent(ViewRootImpl.java:6205)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.inputmethod.InputMethodManager$PendingEvent.run(InputMethodManager.java:3646)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.inputmethod.InputMethodManager.invokeFinishedInputEventCallback(InputMethodManager.java:3166)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.inputmethod.InputMethodManager.finishedInputEvent(InputMethodManager.java:3157)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.inputmethod.InputMethodManager$ImeInputEventSender.onInputEventFinished(InputMethodManager.java:3623)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.view.InputEventSender.dispatchInputEventFinished(InputEventSender.java:154)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.os.MessageQueue.nativePollOnce(Native Method)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.os.MessageQueue.next(MessageQueue.java:335)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.os.Looper.loopOnce(Looper.java:161)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:288)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:7898)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
08-29 19:53:12.331 13155 13155 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

Comments

d-...@mercari.com <d-...@mercari.com> #2Dec 12, 2022 01:01PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

gr...@google.com <gr...@google.com> Jan 17, 2023 11:38PM

Reassigned to gr...@google.com.

gr...@google.com <gr...@google.com> #3Feb 7, 2023 11:07PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

Message last modified on Feb 7, 2023 11:08PM

ap...@google.com <ap...@google.com> #4Feb 8, 2023 02:07AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit fc58ea85d1c91b769de0d28a52903eb573376665
Author: Grant Toepfer <grantapher@google.com>
Date: Tue Feb 07 16:17:44 2023

Fix crash when ctrl+backspace on empty TextField

Also add tailrec to the affected function and its neighbor.

Fixes:

b/244185537

Test: Checked manually in demo app
Test: ./gradlew :compose:foundation:foundation:connectedAndroidTest -Pandroid.testInstrumentationRunnerArguments.class=androidx.compose.foundation.text.TextPreparedSelectionTest
Change-Id: I0427f936ddc519955d4b8092a86e10e0825c8696

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/TextPreparedSelectionTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextPreparedSelection.kt

https://android-review.googlesource.com/2425401

na...@google.com <na...@google.com> #5Feb 22, 2023 07:11PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.4.0-beta02

Issue 244185537