Status Update
Comments
de...@gmail.com <de...@gmail.com> #4
The release notes documentation has been edited to clarify this change in behavior for line height.
To support non-standard text sizes, we encourage users to follow the Material design system and use a different style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified)
, or create a custom Typography
entirely.
se...@google.com <se...@google.com>
cn...@gmail.com <cn...@gmail.com> #5
li...@gmail.com <li...@gmail.com> #6
In my case, I have multiple font sizes in the same Text
(using SpanStyle
in AnnotatedString
). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).
de...@gmail.com <de...@gmail.com> #8
Is there a rough ETA?
se...@google.com <se...@google.com> #9
We have a modal implementation with proper dialog functionality in review, aiming to land this as alpha by EOM but will try and keep folks posted if that changes.
de...@gmail.com <de...@gmail.com> #10
Do you have a Gerrit link to the review?
an...@gmail.com <an...@gmail.com> #12
b9...@gmail.com <b9...@gmail.com> #13
ap...@google.com <ap...@google.com> #14
Branch: androidx-main
commit 896d4c78e8aff51f39f1edd6883f8ddc3549b1a8
Author: serniebanders <serniebanders@google.com>
Date: Tue Dec 06 14:01:07 2022
[Material3][BottomSheet] M3 Modal Bottom Sheet implementation.
Bug: 244189383
Relnote: Modal bottom sheet implementation for Material 3, including ModalBottomSheet and ModalBottomSheetDefaults. Also introduces SheetState and rememberSheetState which can be used for future sheet components.
Test: Ported relevant tests from M2 Modal bottom sheet and popup.
Change-Id: I0853a6ec6d06166787701db1edb4a09b90dd563e
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Components.kt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Examples.kt
A compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/BottomSheetSamples.kt
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
A compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt
A compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SwipeableV2.kt
A compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/tokens/SheetBottomTokens.kt
se...@google.com <se...@google.com>
b9...@gmail.com <b9...@gmail.com> #15
ch...@appswithlove.com <ch...@appswithlove.com> #16
se...@google.com <se...@google.com> #17
Given that this tracker is closed, do you mind filing a bug for this along with details to reproduce. Thanks!
pr...@google.com <pr...@google.com> #18
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.1.0-alpha06
dp...@phunware.com <dp...@phunware.com> #19
This isn't fully fixed yet though, since we still don't have a standard bottom sheet. That ticket only added the modal version of it. Right?
ma...@gmail.com <ma...@gmail.com> #20
I have a strange behavior where a textfield would not work to write inside it when has a bottom sheet as a parent. I can give more details but basically another textfield remains focused and it looks like both fields are focused (the one outside sheet and the one inside sheet, but when you write only the one outside works).
sk...@gmail.com <sk...@gmail.com> #21
I've just reported this
jo...@google.com <jo...@google.com> #22
#20, if the issue reported by #21 isn't the same as yours, can you file an issue with a repro?
na...@gmail.com <na...@gmail.com> #23
ma...@gmail.com <ma...@gmail.com> #24
#22 it's exactly the same issue, easy to reproduce.
Get a Column with an OutlinedTextField or any input text field with a Bottom Sheet that contains another input text. You cannot type into the one inside the bottom sheet.
In my opinion the problem is not that the bottom sheet covers the keyboard, indeed it does that, but I was testing from the emulator and I was typing on the physical keyboard, I think it's more like a focus issue but we count on you guys to figure it out.
jo...@google.com <jo...@google.com> #25
#24, gotcha! Please follow along in the other issue then :)
de...@gmail.com <de...@gmail.com> #26
The BottomSheet still has serious problems with positioning. Depending on the height of the content, the BottomSheet floats in the middle of the screen or something similar, so that a lot of the app is still visible below the BottomSheet.
Is this already known, or should I create a ticket?
se...@google.com <se...@google.com> #27
Yes, see
For other issues please file new bugs so we can more effectively triage than coming back to this tracker.
at...@gmail.com <at...@gmail.com> #28
ja...@gmail.com <ja...@gmail.com> #29
This import is not working for me
ja...@gmail.com <ja...@gmail.com> #30
const val composeVersion = "1.4.3"
compileOptions {
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}
kotlinOptions {
jvmTarget = '17'
}
Using the above version of Material3. Please share any suggestions.
Description
Feature Request to add BottomSheets to Compose for Material 3. Bottom sheets - Material Design 3 . The Guidelines are also still missing.
See