In Scaffold(), Vignette() with will block HorizontalPageIndicator() [244207528]

Fixed

Bug

Status Update

No update yet.

Description

6x...@gmail.com

created issue #1

Aug 30, 2022 12:04PM

Component used: Scaffold(), Vignette() and HorizontalPageIndicator()
Version used:

compose_version = '1.2.0-rc03'
wear_compose_version = '1.0.0-beta02'

Devices/Android versions reproduced on: both Wear OS 2.x and 3

Simple Code Attached:

    Scaffold(
        pageIndicator = {
            // If possible, please provide an accompanist pager state adapter.
            HorizontalPageIndicator(pageIndicatorState = aPageState)
        },
        vignette = {
            Vignette(vignettePosition = VignettePosition.TopAndBottom)
        }
    ) {
        SomeComposables()
    }

Comments

6x...@gmail.com <6x...@gmail.com> #2Aug 30, 2022 12:08PM

To fix this, all you need to do is copy the Scaffold Composable and change the inner code:
From

@Composable
public fun Scaffold(
    modifier: Modifier = Modifier,
    vignette: @Composable (() -> Unit)? = null,
    positionIndicator: @Composable (() -> Unit)? = null,
    pageIndicator: @Composable (() -> Unit)? = null,
    timeText: @Composable (() -> Unit)? = null,
    content: @Composable () -> Unit
) {
    Box(modifier = modifier) {
        content()
        positionIndicator?.invoke()
        pageIndicator?.invoke()
        vignette?.invoke()
        timeText?.invoke()
    }
}

@Composable
public fun Scaffold(
    modifier: Modifier = Modifier,
    vignette: @Composable (() -> Unit)? = null,
    positionIndicator: @Composable (() -> Unit)? = null,
    pageIndicator: @Composable (() -> Unit)? = null,
    timeText: @Composable (() -> Unit)? = null,
    content: @Composable () -> Unit
) {
    Box(modifier = modifier) {
        content()
        positionIndicator?.invoke()
        vignette?.invoke()
        pageIndicator?.invoke()
        timeText?.invoke()
    }
}

Message last modified on Aug 30, 2022 12:09PM

jn...@google.com <jn...@google.com> #3Aug 31, 2022 10:18AM

Assigned to jn...@google.com.

Thanks for the report we will look to correct asap

ap...@google.com <ap...@google.com> #4Aug 31, 2022 10:53AM

Project: platform/frameworks/support
Branch: androidx-main

commit 66a77b4d349aafeb0b5fe35c8a4fa30626ef5edc
Author: jnichol <jnichol@google.com>
Date: Wed Aug 31 11:15:23 2022

Fix the z-order of the items in Compose for Wear OS Scaffold

The z-order of the items in the Compose for Wear OS scaffold is wrong. The indicators (position and page) should sit on top of the vignette.

Bug: 244207528
Test: ./gradlew :wear:compose:compose-material:connectedCheck --info --daemon
Relnote: "We have corrected the z-order of position and page indictors in the Scaffold. The indicators will now sit on top of the vignette and so will not be obscured by the vignette if it is present."
Change-Id: Ib988f8f73d99fc2cfe5d29d0ea0198e68c391a18

M wear/compose/compose-material/src/commonMain/kotlin/androidx/wear/compose/material/Scaffold.kt

https://android-review.googlesource.com/2202016

jn...@google.com <jn...@google.com> Sep 1, 2022 10:38AM

Marked as fixed.

na...@google.com <na...@google.com> #5Aug 21, 2024 07:55PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.wear.compose:compose-material:1.4.0-rc01

Issue 244207528